From: Steve Dickson <steved@redhat.com>
To: Giulio Benetti <giulio.benetti@benettiengineering.com>,
Petr Vorel <pvorel@suse.cz>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH v3] nfsrahead: fix linking while static linking
Date: Mon, 22 Aug 2022 15:17:02 -0400 [thread overview]
Message-ID: <12ece17b-b2d9-6621-0af7-26a12470bc99@redhat.com> (raw)
In-Reply-To: <881E6E82-812C-4BD8-849C-4DEE484AE4F0@benettiengineering.com>
On 8/11/22 4:36 PM, Giulio Benetti wrote:
> Hi Petr,
>
>> Il giorno 11 ago 2022, alle ore 22:20, Petr Vorel <pvorel@suse.cz> ha scritto:
>>
>> Hi,
>>
>> Reviewed-by: Petr Vorel <pvorel@suse.cz>
>>
>> nit (not worth of reposting): I'm not a native speaker, but IMHO subject should
>> be without while, e.g. "fix order on static linking"
>
> Totally, it sounds awful as it is now.
> I ask maintainers if it’s possible to reword like Petr
> pointed.
Will do!
steved.
>
> Thank you all.
>
> Best regards
> Giulio
>
>>
>> Kind regards,
>> Petr
>
next prev parent reply other threads:[~2022-08-22 19:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-09 22:12 [PATCH] nfsrahead: fix linking while static linking Giulio Benetti
2022-08-09 22:23 ` Giulio Benetti
2022-08-09 22:33 ` [PATCH v2] " Giulio Benetti
2022-08-10 21:43 ` Giulio Benetti
2022-08-10 21:45 ` [PATCH v3] " Giulio Benetti
2022-08-11 20:20 ` Petr Vorel
2022-08-11 20:36 ` Giulio Benetti
2022-08-22 19:17 ` Steve Dickson [this message]
2022-08-22 20:33 ` Giulio Benetti
2022-09-13 15:55 ` Steve Dickson
2022-09-13 15:56 ` Petr Vorel
2022-09-13 21:06 ` Giulio Benetti
2022-09-13 17:38 ` Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12ece17b-b2d9-6621-0af7-26a12470bc99@redhat.com \
--to=steved@redhat.com \
--cc=giulio.benetti@benettiengineering.com \
--cc=linux-nfs@vger.kernel.org \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.