From: Kevin Wells <kevin.wells@nxp.com>
To: Linus Walleij <linus.ml.walleij@gmail.com>,
"wellsk40@gmail.com" <wellsk40@gmail.com>
Cc: "rabin.vincent@stericsson.com" <rabin.vincent@stericsson.com>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
"sameo@linux.intel.com" <sameo@linux.intel.com>,
"Lukasz.Baj@tieto.com" <Lukasz.Baj@tieto.com>,
"srinidhi.kasagar@stericsson.com"
<srinidhi.kasagar@stericsson.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"u.kleine-koenig@pengutronix.de" <u.kleine-koenig@pengutronix.de>,
"tj@kernel.org" <tj@kernel.org>,
"spi-devel-general@lists.sourceforge.net"
<spi-devel-general@lists.sourceforge.net>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: RE: amba_pl022 spi->mode fix/cleanup patches
Date: Mon, 13 Sep 2010 18:52:51 +0200 [thread overview]
Message-ID: <083DF309106F364B939360100EC290F80AD49D5232@eu1rdcrdc1wx030.exi.nxp.com> (raw)
In-Reply-To: <AANLkTimtR6+TFX8w1_6MEEqbvk5-StkUTn5kKd4q3DeZ@mail.gmail.com>
>
> 2010/9/10 <wellsk40@gmail.com>:
>
> > This patch series updates drivers and platforms that depend on the
> > amba_pl022 driver and use the pl022_config_chip structure for
> > setting up the SPI mode and data transfer width.
>
> I get regressions from the ab8500-spi.c driver from this patch:
>
> > ssp-pl022 ssp0: ARM PL022 driver, device ID: 0x01080022
> > pl022: mapped registers from 0x80002000 to d0834000
> > ab8500-spi spi0.0: unknown chip, revision: 0x80
> > ab8500-spi: probe of spi0.0 failed with error -22
>
> The 0x80 above used to be 0x00 before these patches.
> So all of a sudden bit 7 gets set...
>
> I don't know why this happens, probably some flag that used to
> be set had not been properly propagated in the first patch to alter
> the AB8500 device registration?
>
I found a bug in the SPI driver for the SPHA field. This would effect
SPI mode 1/3 users. Can you please try it once more with the fix?
(see fix in patch email)
I was hoping these changes would be very minor, but I have limited
hardware to do SPI testing without resorting to loopback mode.
Thanks!
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: kevin.wells@nxp.com (Kevin Wells)
To: linux-arm-kernel@lists.infradead.org
Subject: amba_pl022 spi->mode fix/cleanup patches
Date: Mon, 13 Sep 2010 18:52:51 +0200 [thread overview]
Message-ID: <083DF309106F364B939360100EC290F80AD49D5232@eu1rdcrdc1wx030.exi.nxp.com> (raw)
In-Reply-To: <AANLkTimtR6+TFX8w1_6MEEqbvk5-StkUTn5kKd4q3DeZ@mail.gmail.com>
>
> 2010/9/10 <wellsk40@gmail.com>:
>
> > This patch series updates drivers and platforms that depend on the
> > amba_pl022 driver and use the pl022_config_chip structure for
> > setting up the SPI mode and data transfer width.
>
> I get regressions from the ab8500-spi.c driver from this patch:
>
> > ssp-pl022 ssp0: ARM PL022 driver, device ID: 0x01080022
> > pl022: mapped registers from 0x80002000 to d0834000
> > ab8500-spi spi0.0: unknown chip, revision: 0x80
> > ab8500-spi: probe of spi0.0 failed with error -22
>
> The 0x80 above used to be 0x00 before these patches.
> So all of a sudden bit 7 gets set...
>
> I don't know why this happens, probably some flag that used to
> be set had not been properly propagated in the first patch to alter
> the AB8500 device registration?
>
I found a bug in the SPI driver for the SPHA field. This would effect
SPI mode 1/3 users. Can you please try it once more with the fix?
(see fix in patch email)
I was hoping these changes would be very minor, but I have limited
hardware to do SPI testing without resorting to loopback mode.
Thanks!
Kevin
next prev parent reply other threads:[~2010-09-13 16:59 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-10 16:19 amba_pl022 spi->mode fix/cleanup patches wellsk40
2010-09-10 16:19 ` wellsk40 at gmail.com
2010-09-10 16:19 ` [PATCH 1/5] mfd/ab8500: Setup SPI transfer for 24 bits wellsk40
2010-09-10 16:19 ` wellsk40 at gmail.com
2010-09-10 16:19 ` [PATCH 2/5] ARM: LPC32XX: Add missing SPI mode and remove unused fields wellsk40
2010-09-10 16:19 ` wellsk40 at gmail.com
2010-09-10 16:19 ` wellsk40-Re5JQEeQqe8AvxtiuMwx3w
2010-09-10 16:19 ` [PATCH 3/5] ARM: U300: spi->mode and spi_bits_per_words updates wellsk40
2010-09-10 16:19 ` wellsk40 at gmail.com
2010-09-10 16:19 ` [PATCH 4/5] ARM: Ux500: Change SPI mode and remove unused fields wellsk40
2010-09-10 16:19 ` wellsk40 at gmail.com
2010-09-10 16:19 ` wellsk40-Re5JQEeQqe8AvxtiuMwx3w
2010-09-10 16:19 ` [PATCH 5/5] spi: amba_pl022: Remove unused fields from pl022_config_chip wellsk40
2010-09-10 16:19 ` wellsk40 at gmail.com
2010-09-13 13:22 ` Linus Walleij
2010-09-13 13:22 ` Linus Walleij
2010-09-13 14:55 ` Linus Walleij
2010-09-13 14:55 ` Linus Walleij
2010-09-13 15:19 ` amba_pl022 spi->mode fix/cleanup patches Linus Walleij
2010-09-13 15:19 ` Linus Walleij
2010-09-13 15:19 ` Linus Walleij
2010-09-13 16:52 ` Kevin Wells [this message]
2010-09-13 16:52 ` Kevin Wells
2010-09-13 16:52 ` Kevin Wells
2010-09-16 3:14 ` Grant Likely
2010-09-16 3:14 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=083DF309106F364B939360100EC290F80AD49D5232@eu1rdcrdc1wx030.exi.nxp.com \
--to=kevin.wells@nxp.com \
--cc=Lukasz.Baj@tieto.com \
--cc=linus.ml.walleij@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=rabin.vincent@stericsson.com \
--cc=sameo@linux.intel.com \
--cc=spi-devel-general@lists.sourceforge.net \
--cc=srinidhi.kasagar@stericsson.com \
--cc=tj@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wellsk40@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.