From: Lubomir Rintel <lkundrak@v3.sk>
To: Florian Fainelli <f.fainelli@gmail.com>, Olof Johansson <olof@lixom.net>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Jason Cooper <jason@lakedaemon.net>,
Stephen Boyd <sboyd@kernel.org>, Marc Zyngier <maz@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Russell King <linux@armlinux.org.uk>,
Kishon Vijay Abraham I <kishon@ti.com>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Thomas Gleixner <tglx@linutronix.de>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 16/20] ARM: mmp: add SMP support
Date: Fri, 23 Aug 2019 09:13:33 +0200 [thread overview]
Message-ID: <0897fa54f487f481bf8770ed516578b6f4f53380.camel@v3.sk> (raw)
In-Reply-To: <6f9d2285-5ca4-a63a-610e-890b49a4f816@gmail.com>
On Thu, 2019-08-22 at 09:36 -0700, Florian Fainelli wrote:
> On 8/22/19 2:26 AM, Lubomir Rintel wrote:
> > Used to bring up the second core on MMP3.
> >
> > Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> >
> > ---
> > Changes since v1:
> > - Wrap SW_BRANCH_VIRT_ADDR with __pa_symbol()
> >
> > arch/arm/mach-mmp/Makefile | 3 +++
> > arch/arm/mach-mmp/platsmp.c | 33 +++++++++++++++++++++++++++++++++
> > 2 files changed, 36 insertions(+)
> > create mode 100644 arch/arm/mach-mmp/platsmp.c
> >
> > diff --git a/arch/arm/mach-mmp/Makefile b/arch/arm/mach-mmp/Makefile
> > index 322c1c97dc900..7b3a7f979eece 100644
> > --- a/arch/arm/mach-mmp/Makefile
> > +++ b/arch/arm/mach-mmp/Makefile
> > @@ -22,6 +22,9 @@ ifeq ($(CONFIG_PM),y)
> > obj-$(CONFIG_CPU_PXA910) += pm-pxa910.o
> > obj-$(CONFIG_CPU_MMP2) += pm-mmp2.o
> > endif
> > +ifeq ($(CONFIG_SMP),y)
> > +obj-$(CONFIG_MACH_MMP3_DT) += platsmp.o
> > +endif
> >
> > # board support
> > obj-$(CONFIG_MACH_ASPENITE) += aspenite.o
> > diff --git a/arch/arm/mach-mmp/platsmp.c b/arch/arm/mach-mmp/platsmp.c
> > new file mode 100644
> > index 0000000000000..98d5ef23623cb
> > --- /dev/null
> > +++ b/arch/arm/mach-mmp/platsmp.c
> > @@ -0,0 +1,33 @@
> > +// SPDX-License-Identifier: GPL-2.0-or-later
> > +/*
> > + * Copyright (C) 2019 Lubomir Rintel <lkundrak@v3.sk>
> > + */
> > +#include <linux/io.h>
> > +#include <asm/smp_scu.h>
> > +#include <asm/smp.h>
> > +#include "addr-map.h"
> > +
> > +#define SW_BRANCH_VIRT_ADDR CIU_REG(0x24)
> > +
> > +static int mmp3_boot_secondary(unsigned int cpu, struct task_struct *idle)
> > +{
> > + /*
> > + * Apparently, the boot ROM on the second core spins on this
> > + * register becoming non-zero and then jumps to the address written
> > + * there. No IPIs involved.
> > + */
> > + __raw_writel(virt_to_phys(secondary_startup),
> > + __pa_symbol(SW_BRANCH_VIRT_ADDR));
>
> That looks wrong, the __pa_symbol() is applicable to secondary_startup,
> while SW_BRANCH_VIRT_ADDR does not need that.
Whoops, sorry for that. Will fix in the next patch version in a few
days.
Thanks
Lubo
WARNING: multiple messages have this Message-ID (diff)
From: Lubomir Rintel <lkundrak@v3.sk>
To: Florian Fainelli <f.fainelli@gmail.com>, Olof Johansson <olof@lixom.net>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Jason Cooper <jason@lakedaemon.net>,
Stephen Boyd <sboyd@kernel.org>, Marc Zyngier <maz@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Russell King <linux@armlinux.org.uk>,
Kishon Vijay Abraham I <kishon@ti.com>,
Rob Herring <robh+dt@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 16/20] ARM: mmp: add SMP support
Date: Fri, 23 Aug 2019 09:13:33 +0200 [thread overview]
Message-ID: <0897fa54f487f481bf8770ed516578b6f4f53380.camel@v3.sk> (raw)
In-Reply-To: <6f9d2285-5ca4-a63a-610e-890b49a4f816@gmail.com>
On Thu, 2019-08-22 at 09:36 -0700, Florian Fainelli wrote:
> On 8/22/19 2:26 AM, Lubomir Rintel wrote:
> > Used to bring up the second core on MMP3.
> >
> > Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> >
> > ---
> > Changes since v1:
> > - Wrap SW_BRANCH_VIRT_ADDR with __pa_symbol()
> >
> > arch/arm/mach-mmp/Makefile | 3 +++
> > arch/arm/mach-mmp/platsmp.c | 33 +++++++++++++++++++++++++++++++++
> > 2 files changed, 36 insertions(+)
> > create mode 100644 arch/arm/mach-mmp/platsmp.c
> >
> > diff --git a/arch/arm/mach-mmp/Makefile b/arch/arm/mach-mmp/Makefile
> > index 322c1c97dc900..7b3a7f979eece 100644
> > --- a/arch/arm/mach-mmp/Makefile
> > +++ b/arch/arm/mach-mmp/Makefile
> > @@ -22,6 +22,9 @@ ifeq ($(CONFIG_PM),y)
> > obj-$(CONFIG_CPU_PXA910) += pm-pxa910.o
> > obj-$(CONFIG_CPU_MMP2) += pm-mmp2.o
> > endif
> > +ifeq ($(CONFIG_SMP),y)
> > +obj-$(CONFIG_MACH_MMP3_DT) += platsmp.o
> > +endif
> >
> > # board support
> > obj-$(CONFIG_MACH_ASPENITE) += aspenite.o
> > diff --git a/arch/arm/mach-mmp/platsmp.c b/arch/arm/mach-mmp/platsmp.c
> > new file mode 100644
> > index 0000000000000..98d5ef23623cb
> > --- /dev/null
> > +++ b/arch/arm/mach-mmp/platsmp.c
> > @@ -0,0 +1,33 @@
> > +// SPDX-License-Identifier: GPL-2.0-or-later
> > +/*
> > + * Copyright (C) 2019 Lubomir Rintel <lkundrak@v3.sk>
> > + */
> > +#include <linux/io.h>
> > +#include <asm/smp_scu.h>
> > +#include <asm/smp.h>
> > +#include "addr-map.h"
> > +
> > +#define SW_BRANCH_VIRT_ADDR CIU_REG(0x24)
> > +
> > +static int mmp3_boot_secondary(unsigned int cpu, struct task_struct *idle)
> > +{
> > + /*
> > + * Apparently, the boot ROM on the second core spins on this
> > + * register becoming non-zero and then jumps to the address written
> > + * there. No IPIs involved.
> > + */
> > + __raw_writel(virt_to_phys(secondary_startup),
> > + __pa_symbol(SW_BRANCH_VIRT_ADDR));
>
> That looks wrong, the __pa_symbol() is applicable to secondary_startup,
> while SW_BRANCH_VIRT_ADDR does not need that.
Whoops, sorry for that. Will fix in the next patch version in a few
days.
Thanks
Lubo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-08-23 7:13 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-22 9:26 [PATCH v2 00/20] Initial support for Marvell MMP3 SoC Lubomir Rintel
2019-08-22 9:26 ` Lubomir Rintel
2019-08-22 9:26 ` [PATCH v2 01/20] dt-bindings: arm: cpu: Add Marvell MMP3 SMP enable method Lubomir Rintel
2019-08-22 9:26 ` Lubomir Rintel
2019-08-22 9:26 ` [PATCH v2 02/20] dt-bindings: arm: Convert Marvell MMP board/soc bindings to json-schema Lubomir Rintel
2019-08-22 9:26 ` Lubomir Rintel
2019-08-27 11:59 ` Rob Herring
2019-08-27 11:59 ` Rob Herring
2019-08-27 11:59 ` Rob Herring
2019-08-27 13:23 ` Lubomir Rintel
2019-08-27 13:23 ` Lubomir Rintel
2019-08-27 13:23 ` Lubomir Rintel
2019-08-27 13:36 ` Rob Herring
2019-08-27 13:36 ` Rob Herring
2019-08-27 13:36 ` Rob Herring
2019-08-22 9:26 ` [PATCH v2 03/20] dt-bindings: arm: mrvl: Document MMP3 compatible string Lubomir Rintel
2019-08-22 9:26 ` Lubomir Rintel
2019-08-27 12:00 ` Rob Herring
2019-08-27 12:00 ` Rob Herring
2019-08-27 12:00 ` Rob Herring
2019-08-22 9:26 ` [PATCH v2 04/20] dt-bindings: mrvl,intc: Add a MMP3 interrupt controller Lubomir Rintel
2019-08-22 9:26 ` [PATCH v2 04/20] dt-bindings: mrvl, intc: " Lubomir Rintel
2019-08-27 22:23 ` [PATCH v2 04/20] dt-bindings: mrvl,intc: " Rob Herring
2019-08-27 22:23 ` Rob Herring
2019-08-27 22:23 ` Rob Herring
2019-08-22 9:26 ` [PATCH v2 05/20] dt-bindings: phy-mmp3-usb: Add bindings Lubomir Rintel
2019-08-22 9:26 ` Lubomir Rintel
2019-08-27 22:24 ` Rob Herring
2019-08-27 22:24 ` Rob Herring
2019-08-27 22:24 ` Rob Herring
2019-08-22 9:26 ` [PATCH v2 06/20] irqchip/mmp: do not use of_address_to_resource() to get mux regs Lubomir Rintel
2019-08-22 9:26 ` Lubomir Rintel
2019-09-06 11:08 ` [tip: irq/core] irqchip/mmp: Do " tip-bot2 for Lubomir Rintel
2020-03-09 16:25 ` [PATCH v2 06/20] irqchip/mmp: do " Rob Herring
2020-03-09 16:25 ` Rob Herring
2020-03-09 16:28 ` Rob Herring
2020-03-09 16:28 ` Rob Herring
2019-08-22 9:26 ` [PATCH v2 07/20] irqchip/mmp: add missing chained_irq_{enter,exit}() Lubomir Rintel
2019-08-22 9:26 ` Lubomir Rintel
2019-09-06 11:08 ` [tip: irq/core] irqchip/mmp: Add " tip-bot2 for Lubomir Rintel
2019-08-22 9:26 ` [PATCH v2 08/20] irqchip/mmp: mask off interrupts from other cores Lubomir Rintel
2019-08-22 9:26 ` Lubomir Rintel
2019-09-06 11:08 ` [tip: irq/core] irqchip/mmp: Mask " tip-bot2 for Andres Salomon
2019-08-22 9:26 ` [PATCH v2 09/20] irqchip/mmp: coexist with GIC root IRQ controller Lubomir Rintel
2019-08-22 9:26 ` Lubomir Rintel
2019-09-06 11:08 ` [tip: irq/core] irqchip/mmp: Coexist " tip-bot2 for Lubomir Rintel
2019-08-22 9:26 ` [PATCH v2 10/20] ARM: l2c: add definition for FWA in PL310 aux register Lubomir Rintel
2019-08-22 9:26 ` Lubomir Rintel
2019-08-22 9:26 ` [PATCH v2 11/20] ARM: mmp: don't select CACHE_TAUROS2 on all ARCH_MMP Lubomir Rintel
2019-08-22 9:26 ` Lubomir Rintel
2019-08-22 9:26 ` Lubomir Rintel
2019-08-22 9:26 ` [PATCH v2 12/20] ARM: mmp: map the PGU as well Lubomir Rintel
2019-08-22 9:26 ` Lubomir Rintel
2019-08-22 9:26 ` [PATCH v2 13/20] ARM: mmp: DT: convert timer driver to use TIMER_OF_DECLARE Lubomir Rintel
2019-08-22 9:26 ` Lubomir Rintel
2019-08-22 9:26 ` [PATCH v2 14/20] ARM: mmp: define MMP_CHIPID by the means of CIU_REG() Lubomir Rintel
2019-08-22 9:26 ` Lubomir Rintel
2019-08-22 9:26 ` [PATCH v2 15/20] ARM: mmp: add support for MMP3 SoC Lubomir Rintel
2019-08-22 9:26 ` Lubomir Rintel
2019-08-22 9:26 ` [PATCH v2 16/20] ARM: mmp: add SMP support Lubomir Rintel
2019-08-22 9:26 ` Lubomir Rintel
2019-08-22 16:36 ` Florian Fainelli
2019-08-22 16:36 ` Florian Fainelli
2019-08-23 7:13 ` Lubomir Rintel [this message]
2019-08-23 7:13 ` Lubomir Rintel
2019-08-22 9:26 ` [PATCH v2 17/20] ARM: mmp: move cputype.h to include/linux/soc/ Lubomir Rintel
2019-08-22 9:26 ` Lubomir Rintel
2019-08-22 9:26 ` [PATCH v2 18/20] ARM: mmp: remove MMP3 USB PHY registers from regs-usb.h Lubomir Rintel
2019-08-22 9:26 ` Lubomir Rintel
2019-08-22 9:26 ` [PATCH v2 19/20] phy: phy-mmp3-usb: add a new driver Lubomir Rintel
2019-08-22 9:26 ` Lubomir Rintel
2019-08-22 9:26 ` [PATCH v2 20/20] ARM: dts: mmp3: Add MMP3 SoC dts file Lubomir Rintel
2019-08-22 9:26 ` Lubomir Rintel
2019-08-22 10:31 ` [PATCH v2 00/20] Initial support for Marvell MMP3 SoC Marc Zyngier
2019-08-22 10:31 ` Marc Zyngier
2019-08-22 16:23 ` Olof Johansson
2019-08-22 16:23 ` Olof Johansson
2019-08-23 7:21 ` Lubomir Rintel
2019-08-23 7:21 ` Lubomir Rintel
2019-08-23 9:42 ` Marc Zyngier
2019-08-23 9:42 ` Marc Zyngier
2019-08-26 11:59 ` Lubomir Rintel
2019-08-26 11:59 ` Lubomir Rintel
2019-08-30 14:26 ` Marc Zyngier
2019-08-30 14:26 ` Marc Zyngier
2019-08-30 14:26 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0897fa54f487f481bf8770ed516578b6f4f53380.camel@v3.sk \
--to=lkundrak@v3.sk \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=jason@lakedaemon.net \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=mturquette@baylibre.com \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.