From: Ralph Campbell <rcampbell@nvidia.com>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: <linux-rdma@vger.kernel.org>, <linux-mm@kvack.org>,
<nouveau@lists.freedesktop.org>, <kvm-ppc@vger.kernel.org>,
<linux-kselftest@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
"Jerome Glisse" <jglisse@redhat.com>,
John Hubbard <jhubbard@nvidia.com>,
"Christoph Hellwig" <hch@lst.de>,
Andrew Morton <akpm@linux-foundation.org>,
Shuah Khan <shuah@kernel.org>, Ben Skeggs <bskeggs@redhat.com>,
Bharata B Rao <bharata@linux.ibm.com>
Subject: Re: [PATCH v4 3/6] mm/notifier: add migration invalidation type
Date: Tue, 28 Jul 2020 13:57:31 -0700 [thread overview]
Message-ID: <08eb43d9-9650-f050-9cfb-d8ba5df6c5dd@nvidia.com> (raw)
In-Reply-To: <20200728191518.GA159104@nvidia.com>
On 7/28/20 12:15 PM, Jason Gunthorpe wrote:
> On Thu, Jul 23, 2020 at 03:30:01PM -0700, Ralph Campbell wrote:
>> static inline int mm_has_notifiers(struct mm_struct *mm)
>> @@ -513,6 +519,7 @@ static inline void mmu_notifier_range_init(struct mmu_notifier_range *range,
>> range->start = start;
>> range->end = end;
>> range->flags = flags;
>> + range->migrate_pgmap_owner = NULL;
>> }
>
> Since this function is commonly called and nobody should read
> migrate_pgmap_owner unless MMU_NOTIFY_MIGRATE is set as the event,
> this assignment can be dropped.
>
> Jason
I agree.
Acked-by: Ralph Campbell <rcampbell@nvidia.com>
WARNING: multiple messages have this Message-ID (diff)
From: Ralph Campbell <rcampbell@nvidia.com>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: linux-rdma@vger.kernel.org, linux-mm@kvack.org,
nouveau@lists.freedesktop.org, kvm-ppc@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
Jerome Glisse <jglisse@redhat.com>,
John Hubbard <jhubbard@nvidia.com>,
Christoph Hellwig <hch@lst.de>,
Andrew Morton <akpm@linux-foundation.org>,
Shuah Khan <shuah@kernel.org>, Ben Skeggs <bskeggs@redhat.com>,
Bharata B Rao <bharata@linux.ibm.com>
Subject: Re: [PATCH v4 3/6] mm/notifier: add migration invalidation type
Date: Tue, 28 Jul 2020 13:57:31 -0700 [thread overview]
Message-ID: <08eb43d9-9650-f050-9cfb-d8ba5df6c5dd@nvidia.com> (raw)
In-Reply-To: <20200728191518.GA159104@nvidia.com>
On 7/28/20 12:15 PM, Jason Gunthorpe wrote:
> On Thu, Jul 23, 2020 at 03:30:01PM -0700, Ralph Campbell wrote:
>> static inline int mm_has_notifiers(struct mm_struct *mm)
>> @@ -513,6 +519,7 @@ static inline void mmu_notifier_range_init(struct mmu_notifier_range *range,
>> range->start = start;
>> range->end = end;
>> range->flags = flags;
>> + range->migrate_pgmap_owner = NULL;
>> }
>
> Since this function is commonly called and nobody should read
> migrate_pgmap_owner unless MMU_NOTIFY_MIGRATE is set as the event,
> this assignment can be dropped.
>
> Jason
I agree.
Acked-by: Ralph Campbell <rcampbell@nvidia.com>
WARNING: multiple messages have this Message-ID (diff)
From: Ralph Campbell <rcampbell@nvidia.com>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: linux-rdma@vger.kernel.org, linux-mm@kvack.org,
nouveau@lists.freedesktop.org, kvm-ppc@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
Jerome Glisse <jglisse@redhat.com>,
John Hubbard <jhubbard@nvidia.com>,
Christoph Hellwig <hch@lst.de>,
Andrew Morton <akpm@linux-foundation.org>,
Shuah Khan <shuah@kernel.org>, Ben Skeggs <bskeggs@redhat.com>,
Bharata B Rao <bharata@linux.ibm.com>
Subject: Re: [PATCH v4 3/6] mm/notifier: add migration invalidation type
Date: Tue, 28 Jul 2020 20:57:31 +0000 [thread overview]
Message-ID: <08eb43d9-9650-f050-9cfb-d8ba5df6c5dd@nvidia.com> (raw)
In-Reply-To: <20200728191518.GA159104@nvidia.com>
On 7/28/20 12:15 PM, Jason Gunthorpe wrote:
> On Thu, Jul 23, 2020 at 03:30:01PM -0700, Ralph Campbell wrote:
>> static inline int mm_has_notifiers(struct mm_struct *mm)
>> @@ -513,6 +519,7 @@ static inline void mmu_notifier_range_init(struct mmu_notifier_range *range,
>> range->start = start;
>> range->end = end;
>> range->flags = flags;
>> + range->migrate_pgmap_owner = NULL;
>> }
>
> Since this function is commonly called and nobody should read
> migrate_pgmap_owner unless MMU_NOTIFY_MIGRATE is set as the event,
> this assignment can be dropped.
>
> Jason
I agree.
Acked-by: Ralph Campbell <rcampbell@nvidia.com>
next prev parent reply other threads:[~2020-07-28 20:57 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-23 22:29 [PATCH v4 0/6] mm/migrate: avoid device private invalidations Ralph Campbell
2020-07-23 22:29 ` Ralph Campbell
2020-07-23 22:29 ` Ralph Campbell
2020-07-23 22:29 ` [PATCH v4 1/6] nouveau: fix storing invalid ptes Ralph Campbell
2020-07-23 22:29 ` Ralph Campbell
2020-07-23 22:29 ` Ralph Campbell
2020-07-23 22:30 ` [PATCH v4 2/6] mm/migrate: add a flags parameter to migrate_vma Ralph Campbell
2020-07-23 22:30 ` Ralph Campbell
2020-07-23 22:30 ` Ralph Campbell
2020-07-23 22:30 ` [PATCH v4 3/6] mm/notifier: add migration invalidation type Ralph Campbell
2020-07-23 22:30 ` Ralph Campbell
2020-07-23 22:30 ` Ralph Campbell
2020-07-28 19:15 ` Jason Gunthorpe
2020-07-28 19:15 ` Jason Gunthorpe
2020-07-28 19:15 ` Jason Gunthorpe
2020-07-28 20:57 ` Ralph Campbell [this message]
2020-07-28 20:57 ` Ralph Campbell
2020-07-28 20:57 ` Ralph Campbell
2020-07-23 22:30 ` [PATCH v4 4/6] nouveau/svm: use the new migration invalidation Ralph Campbell
2020-07-23 22:30 ` Ralph Campbell
2020-07-23 22:30 ` Ralph Campbell
2020-07-23 22:30 ` [PATCH v4 5/6] mm/hmm/test: " Ralph Campbell
2020-07-23 22:30 ` Ralph Campbell
2020-07-23 22:30 ` Ralph Campbell
2020-07-23 22:30 ` [PATCH v4 6/6] mm/migrate: remove range invalidation in migrate_vma_pages() Ralph Campbell
2020-07-23 22:30 ` Ralph Campbell
2020-07-23 22:30 ` Ralph Campbell
2020-07-23 22:30 ` Ralph Campbell
2020-07-28 19:19 ` Jason Gunthorpe
2020-07-28 19:19 ` Jason Gunthorpe
2020-07-28 19:19 ` Jason Gunthorpe
2020-07-28 22:04 ` Ralph Campbell
2020-07-28 22:04 ` Ralph Campbell
2020-07-28 22:04 ` Ralph Campbell
2020-07-31 19:15 ` Jason Gunthorpe
2020-07-31 19:15 ` Jason Gunthorpe
2020-07-31 19:31 ` Ralph Campbell
2020-07-31 19:31 ` Ralph Campbell
2020-07-31 19:31 ` Ralph Campbell
2020-07-28 19:22 ` [PATCH v4 0/6] mm/migrate: avoid device private invalidations Jason Gunthorpe
2020-07-28 19:22 ` Jason Gunthorpe
2020-07-28 19:22 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08eb43d9-9650-f050-9cfb-d8ba5df6c5dd@nvidia.com \
--to=rcampbell@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=bharata@linux.ibm.com \
--cc=bskeggs@redhat.com \
--cc=hch@lst.de \
--cc=jgg@nvidia.com \
--cc=jglisse@redhat.com \
--cc=jhubbard@nvidia.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rdma@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.