Re: [PATCH net-next v5 4/7] net: stmmac: Support a generic PCS field in mac_device_info

From: Andrew Lunn <andrew@lunn.ch>
To: Romain Gantois <romain.gantois@bootlin.com>
Cc: "Russell King" <linux@armlinux.org.uk>,
	"Heiner Kallweit" <hkallweit1@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
	"Jose Abreu" <joabreu@synopsys.com>,
	"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
	"Clément Léger" <clement.leger@bootlin.com>,
	"Maxime Chevallier" <maxime.chevallier@bootlin.com>,
	"Miquel Raynal" <miquel.raynal@bootlin.com>,
	"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
	netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org,
	linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH net-next v5 4/7] net: stmmac: Support a generic PCS field in mac_device_info
Date: Mon, 4 Mar 2024 14:43:04 +0100	[thread overview]
Message-ID: <092bdca1-78f1-46f1-bd17-ac714102e097@lunn.ch> (raw)
In-Reply-To: <20240301-rxc_bugfix-v5-4-8dac30230050@bootlin.com>

On Fri, Mar 01, 2024 at 04:35:01PM +0100, Romain Gantois wrote:
> Global stmmac support for early initialization of PCS devices requires a
> generic PCS reference that can be passed to phylink_pcs_pre_init().
> Currently, the mac_device_info struct contains only one PCS field, which is
> specific to the Lynx model.
> 
> As PCS models are hardware-specific, it is more appropriate to have a
> generic PCS field in the mac_device_info struct.
> 
> Refactor the lynx_pcs field into a generic phylink_pcs field.
> 
> Signed-off-by: Romain Gantois <romain.gantois@bootlin.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew