From: Pramod Kumar <pramodku@broadcom.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>, Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Russell King <linux@arm.linux.org.uk>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
Jason Uy <jasonuy@broadcom.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Thomas Gleixner <tglx@linutronix.de>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jonas Gorski <jogo@openwrt.org>
Subject: RE: [PATCH 05/11] dt-binding: Add ngpios property to GPIO controller node
Date: Wed, 28 Oct 2015 05:14:34 +0000 [thread overview]
Message-ID: <0C803592FC378B4E83922050AB46442A2AD73E7A@SJEXCHMB10.corp.ad.broadcom.com> (raw)
In-Reply-To: <CACRpkdZRmJTF9_yzVJx_vPKH6M6PivcrPiLD7xMEs5HDvsLw7g@mail.gmail.com>
Hi Linus,
> -----Original Message-----
> From: Linus Walleij [mailto:linus.walleij@linaro.org]
> Sent: 27 October 2015 15:11
> To: Pramod Kumar
> Cc: Rob Herring; Pawel Moll; Mark Rutland; Ian Campbell; Kumar Gala; Ray Jui;
> Scott Branden; Russell King; linux-gpio@vger.kernel.org; bcm-kernel-feedback-
> list; Jason Uy; Masahiro Yamada; Thomas Gleixner; Laurent Pinchart;
> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
> kernel@vger.kernel.org; Jonas Gorski
> Subject: Re: [PATCH 05/11] dt-binding: Add ngpios property to GPIO controller
> node
>
> On Mon, Oct 19, 2015 at 7:43 AM, Pramod Kumar <pramodku@broadcom.com>
> wrote:
>
> > Add ngpios property to the gpio controller's DT node so that
> > controller driver extracts total number of gpio lines present in
> > controller from DT and removes dependency on driver.
> >
> > Signed-off-by: Pramod Kumar <pramodku@broadcom.com>
> > Reviewed-by: Ray Jui <rjui@broadcom.com>
> > Reviewed-by: Scott Branden <sbranden@broadcom.com>
> (...)
> > +- ngpios:
> > + Total number of GPIOs the controller provides
>
> This description is wrong. The number of GPIOs the controller *provides* is to
> be determined by the compatible-string.
>
> ngpios is used to restrict the number of lines *used* or *routed* from the
> number *available*. (I hope that is what the code does as well.) Such as if 12
> GPIOs are used of the 32 available on 32bits in a register.
>
> Update this description to say what it really means.
>
> Yours,
> Linus Walleij
Thanks for reviewing . Will update the description.
Regards,
Pramod
WARNING: multiple messages have this Message-ID (diff)
From: Pramod Kumar <pramodku@broadcom.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
"Mark Rutland" <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>, Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Russell King <linux@arm.linux.org.uk>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
Jason Uy <jasonuy@broadcom.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Thomas Gleixner <tglx@linutronix.de>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jonas Gorski <jogo@openwrt.org>
Subject: RE: [PATCH 05/11] dt-binding: Add ngpios property to GPIO controller node
Date: Wed, 28 Oct 2015 05:14:34 +0000 [thread overview]
Message-ID: <0C803592FC378B4E83922050AB46442A2AD73E7A@SJEXCHMB10.corp.ad.broadcom.com> (raw)
In-Reply-To: <CACRpkdZRmJTF9_yzVJx_vPKH6M6PivcrPiLD7xMEs5HDvsLw7g@mail.gmail.com>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1757 bytes --]
Hi Linus,
> -----Original Message-----
> From: Linus Walleij [mailto:linus.walleij@linaro.org]
> Sent: 27 October 2015 15:11
> To: Pramod Kumar
> Cc: Rob Herring; Pawel Moll; Mark Rutland; Ian Campbell; Kumar Gala; Ray Jui;
> Scott Branden; Russell King; linux-gpio@vger.kernel.org; bcm-kernel-feedback-
> list; Jason Uy; Masahiro Yamada; Thomas Gleixner; Laurent Pinchart;
> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
> kernel@vger.kernel.org; Jonas Gorski
> Subject: Re: [PATCH 05/11] dt-binding: Add ngpios property to GPIO controller
> node
>
> On Mon, Oct 19, 2015 at 7:43 AM, Pramod Kumar <pramodku@broadcom.com>
> wrote:
>
> > Add ngpios property to the gpio controller's DT node so that
> > controller driver extracts total number of gpio lines present in
> > controller from DT and removes dependency on driver.
> >
> > Signed-off-by: Pramod Kumar <pramodku@broadcom.com>
> > Reviewed-by: Ray Jui <rjui@broadcom.com>
> > Reviewed-by: Scott Branden <sbranden@broadcom.com>
> (...)
> > +- ngpios:
> > + Total number of GPIOs the controller provides
>
> This description is wrong. The number of GPIOs the controller *provides* is to
> be determined by the compatible-string.
>
> ngpios is used to restrict the number of lines *used* or *routed* from the
> number *available*. (I hope that is what the code does as well.) Such as if 12
> GPIOs are used of the 32 available on 32bits in a register.
>
> Update this description to say what it really means.
>
> Yours,
> Linus Walleij
Thanks for reviewing . Will update the description.
Regards,
Pramod
ÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a¢f£¢·hšïêÿ‘êçz_è®\x03(階ŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨èÚ&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥
WARNING: multiple messages have this Message-ID (diff)
From: pramodku@broadcom.com (Pramod Kumar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 05/11] dt-binding: Add ngpios property to GPIO controller node
Date: Wed, 28 Oct 2015 05:14:34 +0000 [thread overview]
Message-ID: <0C803592FC378B4E83922050AB46442A2AD73E7A@SJEXCHMB10.corp.ad.broadcom.com> (raw)
In-Reply-To: <CACRpkdZRmJTF9_yzVJx_vPKH6M6PivcrPiLD7xMEs5HDvsLw7g@mail.gmail.com>
Hi Linus,
> -----Original Message-----
> From: Linus Walleij [mailto:linus.walleij at linaro.org]
> Sent: 27 October 2015 15:11
> To: Pramod Kumar
> Cc: Rob Herring; Pawel Moll; Mark Rutland; Ian Campbell; Kumar Gala; Ray Jui;
> Scott Branden; Russell King; linux-gpio at vger.kernel.org; bcm-kernel-feedback-
> list; Jason Uy; Masahiro Yamada; Thomas Gleixner; Laurent Pinchart;
> devicetree at vger.kernel.org; linux-arm-kernel at lists.infradead.org; linux-
> kernel at vger.kernel.org; Jonas Gorski
> Subject: Re: [PATCH 05/11] dt-binding: Add ngpios property to GPIO controller
> node
>
> On Mon, Oct 19, 2015 at 7:43 AM, Pramod Kumar <pramodku@broadcom.com>
> wrote:
>
> > Add ngpios property to the gpio controller's DT node so that
> > controller driver extracts total number of gpio lines present in
> > controller from DT and removes dependency on driver.
> >
> > Signed-off-by: Pramod Kumar <pramodku@broadcom.com>
> > Reviewed-by: Ray Jui <rjui@broadcom.com>
> > Reviewed-by: Scott Branden <sbranden@broadcom.com>
> (...)
> > +- ngpios:
> > + Total number of GPIOs the controller provides
>
> This description is wrong. The number of GPIOs the controller *provides* is to
> be determined by the compatible-string.
>
> ngpios is used to restrict the number of lines *used* or *routed* from the
> number *available*. (I hope that is what the code does as well.) Such as if 12
> GPIOs are used of the 32 available on 32bits in a register.
>
> Update this description to say what it really means.
>
> Yours,
> Linus Walleij
Thanks for reviewing . Will update the description.
Regards,
Pramod
next prev parent reply other threads:[~2015-10-28 5:14 UTC|newest]
Thread overview: 122+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-19 5:43 [PATCH 00/11] Generalized broadcom cygnus gpio driver Pramod Kumar
2015-10-19 5:43 ` Pramod Kumar
2015-10-19 5:43 ` Pramod Kumar
2015-10-19 5:43 ` [PATCH 01/11] dt-bindings: pinctrl: Optional DT property to support pin mappings Pramod Kumar
2015-10-19 5:43 ` Pramod Kumar
2015-10-19 5:43 ` Pramod Kumar
2015-10-22 18:45 ` Rob Herring
2015-10-22 18:45 ` Rob Herring
2015-10-22 18:45 ` Rob Herring
2015-10-27 9:43 ` Linus Walleij
2015-10-27 9:43 ` Linus Walleij
2015-10-27 9:43 ` Linus Walleij
2015-10-19 5:43 ` [PATCH 02/11] pinctrl: Remove GPIO to Pinctrl pin mapping from driver Pramod Kumar
2015-10-19 5:43 ` Pramod Kumar
2015-10-19 5:43 ` Pramod Kumar
2015-10-27 9:45 ` Linus Walleij
2015-10-27 9:45 ` Linus Walleij
2015-10-27 9:45 ` Linus Walleij
[not found] ` <1445233398-27129-1-git-send-email-pramodku-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2015-10-19 5:43 ` [PATCH 03/11] dts: pinctrl: Add GPIO to Pinctrl pin mapping in DT Pramod Kumar
2015-10-19 5:43 ` Pramod Kumar
2015-10-19 5:43 ` Pramod Kumar
[not found] ` <1445233398-27129-4-git-send-email-pramodku-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2015-10-27 9:46 ` Linus Walleij
2015-10-27 9:46 ` Linus Walleij
2015-10-27 9:46 ` Linus Walleij
2015-11-18 18:39 ` Florian Fainelli
2015-11-18 18:39 ` Florian Fainelli
2015-11-19 3:34 ` Pramod Kumar
2015-11-19 3:34 ` Pramod Kumar
2015-11-19 3:34 ` Pramod Kumar
2015-10-19 5:43 ` [PATCH 08/11] pinctrl: Add new compatible string to GPIO controller driver Pramod Kumar
2015-10-19 5:43 ` Pramod Kumar
2015-10-19 5:43 ` Pramod Kumar
[not found] ` <1445233398-27129-9-git-send-email-pramodku-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2015-10-27 9:54 ` Linus Walleij
2015-10-27 9:54 ` Linus Walleij
2015-10-27 9:54 ` Linus Walleij
2015-10-19 5:43 ` [PATCH 04/11] dt-binding: Add new compatible string for gpio " Pramod Kumar
2015-10-19 5:43 ` Pramod Kumar
2015-10-19 5:43 ` Pramod Kumar
2015-10-22 18:40 ` Rob Herring
2015-10-22 18:40 ` Rob Herring
2015-10-22 18:40 ` Rob Herring
2015-10-27 9:49 ` Linus Walleij
2015-10-27 9:49 ` Linus Walleij
2015-10-27 9:49 ` Linus Walleij
2015-10-19 5:43 ` [PATCH 05/11] dt-binding: Add ngpios property to GPIO controller node Pramod Kumar
2015-10-19 5:43 ` Pramod Kumar
2015-10-19 5:43 ` Pramod Kumar
2015-10-22 18:43 ` Rob Herring
2015-10-22 18:43 ` Rob Herring
2015-10-22 18:43 ` Rob Herring
[not found] ` <CAL_Jsq+Xwf7==J1LLnUDtj-cgJWRizbKXcYtwfEe5iv8VS-Uwg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-10-22 18:52 ` Ray Jui
2015-10-22 18:52 ` Ray Jui
2015-10-22 18:52 ` Ray Jui
2015-10-22 23:41 ` Rob Herring
2015-10-22 23:41 ` Rob Herring
2015-10-22 23:41 ` Rob Herring
2015-10-23 9:08 ` Laurent Pinchart
2015-10-23 9:08 ` Laurent Pinchart
2015-10-23 9:08 ` Laurent Pinchart
2015-10-23 11:51 ` Rob Herring
2015-10-23 11:51 ` Rob Herring
2015-10-23 11:51 ` Rob Herring
2015-10-23 13:02 ` Laurent Pinchart
2015-10-23 13:02 ` Laurent Pinchart
2015-10-23 13:02 ` Laurent Pinchart
2015-10-23 16:08 ` Ray Jui
2015-10-23 16:08 ` Ray Jui
2015-10-23 16:08 ` Ray Jui
[not found] ` <562A5B75.7010804-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2015-10-26 17:08 ` Pramod Kumar
2015-10-26 17:08 ` Pramod Kumar
2015-10-26 17:08 ` Pramod Kumar
2015-10-26 17:12 ` Ray Jui
2015-10-26 17:12 ` Ray Jui
2015-10-26 17:12 ` Ray Jui
2015-10-26 18:06 ` Pramod Kumar
2015-10-26 18:06 ` Pramod Kumar
2015-10-26 18:06 ` Pramod Kumar
[not found] ` <0C803592FC378B4E83922050AB46442A2AD729D4-HXj2mutaA2qau4nib9vn7Zr/X4hKkxxPpWgKQ6/u3Fg@public.gmane.org>
2015-10-26 18:08 ` Ray Jui
2015-10-26 18:08 ` Ray Jui
2015-10-26 18:08 ` Ray Jui
2015-10-27 9:41 ` Linus Walleij
2015-10-27 9:41 ` Linus Walleij
2015-10-27 9:41 ` Linus Walleij
2015-10-28 5:14 ` Pramod Kumar [this message]
2015-10-28 5:14 ` Pramod Kumar
2015-10-28 5:14 ` Pramod Kumar
2015-10-19 5:43 ` [PATCH 06/11] dts: define ngpios property in gpio controller's node Pramod Kumar
2015-10-19 5:43 ` Pramod Kumar
2015-10-19 5:43 ` Pramod Kumar
2015-10-19 5:43 ` [PATCH 07/11] pinctrl: use ngpios propety from DT Pramod Kumar
2015-10-19 5:43 ` Pramod Kumar
2015-10-19 5:43 ` Pramod Kumar
2015-10-27 9:51 ` Linus Walleij
2015-10-27 9:51 ` Linus Walleij
2015-10-27 9:51 ` Linus Walleij
[not found] ` <CACRpkdY1GDs6ypqCiY3iiv3DkfnHchnY+bWPoCqU=_sgn9f5vQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-10-28 11:52 ` Pramod Kumar
2015-10-28 11:52 ` Pramod Kumar
2015-10-28 11:52 ` Pramod Kumar
[not found] ` <0C803592FC378B4E83922050AB46442A2AD742F0-HXj2mutaA2qau4nib9vn7Zr/X4hKkxxPpWgKQ6/u3Fg@public.gmane.org>
2015-10-28 15:39 ` Ray Jui
2015-10-28 15:39 ` Ray Jui
2015-10-28 15:39 ` Ray Jui
2015-10-29 14:36 ` Linus Walleij
2015-10-29 14:36 ` Linus Walleij
2015-10-29 14:36 ` Linus Walleij
2015-10-29 14:47 ` Jonas Gorski
2015-10-29 14:47 ` Jonas Gorski
2015-10-29 14:47 ` Jonas Gorski
2015-10-30 11:06 ` Linus Walleij
2015-10-30 11:06 ` Linus Walleij
2015-10-30 11:06 ` Linus Walleij
2015-10-19 5:43 ` [PATCH 09/11] gpio: Rename func/macro/var to IP-block,iproc Pramod Kumar
2015-10-19 5:43 ` Pramod Kumar
2015-10-19 5:43 ` Pramod Kumar
2015-10-19 5:43 ` [PATCH 10/11] Documentation: Rename gpio controller name from cygnus to iproc Pramod Kumar
2015-10-19 5:43 ` Pramod Kumar
2015-10-19 5:43 ` Pramod Kumar
2015-10-22 18:41 ` Rob Herring
2015-10-22 18:41 ` Rob Herring
2015-10-22 18:41 ` Rob Herring
2015-10-19 5:43 ` [PATCH 11/11] pinctrl: Rename gpio driver " Pramod Kumar
2015-10-19 5:43 ` Pramod Kumar
2015-10-19 5:43 ` Pramod Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0C803592FC378B4E83922050AB46442A2AD73E7A@SJEXCHMB10.corp.ad.broadcom.com \
--to=pramodku@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jasonuy@broadcom.com \
--cc=jogo@openwrt.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
--cc=tglx@linutronix.de \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.