All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org
Cc: "Halil Pasic" <pasic@linux.ibm.com>,
	"Christian Borntraeger" <borntraeger@de.ibm.com>,
	"Cornelia Huck" <cohuck@redhat.com>,
	"Claudio Fontana" <cfontana@suse.de>,
	"Willian Rampazzo" <wrampazz@redhat.com>,
	qemu-s390x@nongnu.org,
	"Anthony Perard" <anthony.perard@citrix.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	xen-devel@lists.xenproject.org, "Paul Durrant" <paul@xen.org>,
	"Marcelo Tosatti" <mtosatti@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	kvm@vger.kernel.org,
	"Stefano Stabellini" <sstabellini@kernel.org>
Subject: Re: [PATCH v2 4/5] gitlab-ci: Add KVM s390x cross-build jobs
Date: Mon, 7 Dec 2020 12:40:52 +0100	[thread overview]
Message-ID: <0a0c2002-64e1-0a6d-d520-144b70f2590a@redhat.com> (raw)
In-Reply-To: <20201207112353.3814480-5-philmd@redhat.com>

On 07/12/2020 12.23, Philippe Mathieu-Daudé wrote:
> Cross-build s390x target with only KVM accelerator enabled.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  .gitlab-ci.d/crossbuilds.yml | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/.gitlab-ci.d/crossbuilds.yml b/.gitlab-ci.d/crossbuilds.yml
> index d8685ade376..7a94a66b4b3 100644
> --- a/.gitlab-ci.d/crossbuilds.yml
> +++ b/.gitlab-ci.d/crossbuilds.yml
> @@ -1,4 +1,3 @@
> -
>  .cross_system_build_job:
>    stage: build
>    image: $CI_REGISTRY_IMAGE/qemu/$IMAGE:latest
> @@ -120,6 +119,13 @@ cross-s390x-user:
>    variables:
>      IMAGE: debian-s390x-cross
>  
> +cross-s390x-kvm:

I'd still prefer "-no-tcg" or maybe "-kvm-only" ... but that's just a matter
of taste, so:

Reviewed-by: Thomas Huth <thuth@redhat.com>


WARNING: multiple messages have this Message-ID (diff)
From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org
Cc: "Marcelo Tosatti" <mtosatti@redhat.com>,
	kvm@vger.kernel.org, "Paul Durrant" <paul@xen.org>,
	"Cornelia Huck" <cohuck@redhat.com>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Halil Pasic" <pasic@linux.ibm.com>,
	"Christian Borntraeger" <borntraeger@de.ibm.com>,
	qemu-s390x@nongnu.org,
	"Stefano Stabellini" <sstabellini@kernel.org>,
	"Claudio Fontana" <cfontana@suse.de>,
	"Willian Rampazzo" <wrampazz@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Anthony Perard" <anthony.perard@citrix.com>,
	xen-devel@lists.xenproject.org,
	"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH v2 4/5] gitlab-ci: Add KVM s390x cross-build jobs
Date: Mon, 7 Dec 2020 12:40:52 +0100	[thread overview]
Message-ID: <0a0c2002-64e1-0a6d-d520-144b70f2590a@redhat.com> (raw)
In-Reply-To: <20201207112353.3814480-5-philmd@redhat.com>

On 07/12/2020 12.23, Philippe Mathieu-Daudé wrote:
> Cross-build s390x target with only KVM accelerator enabled.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  .gitlab-ci.d/crossbuilds.yml | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/.gitlab-ci.d/crossbuilds.yml b/.gitlab-ci.d/crossbuilds.yml
> index d8685ade376..7a94a66b4b3 100644
> --- a/.gitlab-ci.d/crossbuilds.yml
> +++ b/.gitlab-ci.d/crossbuilds.yml
> @@ -1,4 +1,3 @@
> -
>  .cross_system_build_job:
>    stage: build
>    image: $CI_REGISTRY_IMAGE/qemu/$IMAGE:latest
> @@ -120,6 +119,13 @@ cross-s390x-user:
>    variables:
>      IMAGE: debian-s390x-cross
>  
> +cross-s390x-kvm:

I'd still prefer "-no-tcg" or maybe "-kvm-only" ... but that's just a matter
of taste, so:

Reviewed-by: Thomas Huth <thuth@redhat.com>



  reply	other threads:[~2020-12-07 11:42 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-07 11:23 [PATCH v2 0/5] gitlab-ci: Add accelerator-specific Linux jobs Philippe Mathieu-Daudé
2020-12-07 11:23 ` Philippe Mathieu-Daudé
2020-12-07 11:23 ` [PATCH v2 1/5] gitlab-ci: Document 'build-tcg-disabled' is a KVM X86 job Philippe Mathieu-Daudé
2020-12-07 11:23   ` Philippe Mathieu-Daudé
2020-12-07 11:32   ` Thomas Huth
2020-12-07 11:32     ` Thomas Huth
2020-12-07 11:23 ` [PATCH v2 2/5] gitlab-ci: Replace YAML anchors by extends (cross_system_build_job) Philippe Mathieu-Daudé
2020-12-07 11:23   ` Philippe Mathieu-Daudé
2020-12-07 11:23 ` [PATCH v2 3/5] gitlab-ci: Introduce 'cross_accel_build_job' template Philippe Mathieu-Daudé
2020-12-07 11:23   ` Philippe Mathieu-Daudé
2020-12-07 11:37   ` Thomas Huth
2020-12-07 11:37     ` Thomas Huth
2020-12-07 12:53     ` Philippe Mathieu-Daudé
2020-12-07 12:53       ` Philippe Mathieu-Daudé
2020-12-07 11:23 ` [PATCH v2 4/5] gitlab-ci: Add KVM s390x cross-build jobs Philippe Mathieu-Daudé
2020-12-07 11:23   ` Philippe Mathieu-Daudé
2020-12-07 11:40   ` Thomas Huth [this message]
2020-12-07 11:40     ` Thomas Huth
2020-12-07 11:23 ` [PATCH v2 5/5] gitlab-ci: Add Xen " Philippe Mathieu-Daudé
2020-12-07 11:23   ` Philippe Mathieu-Daudé
2020-12-07 11:51   ` Thomas Huth
2020-12-07 11:51     ` Thomas Huth
2020-12-07 12:46     ` Philippe Mathieu-Daudé
2020-12-07 12:46       ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0a0c2002-64e1-0a6d-d520-144b70f2590a@redhat.com \
    --to=thuth@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=anthony.perard@citrix.com \
    --cc=borntraeger@de.ibm.com \
    --cc=cfontana@suse.de \
    --cc=cohuck@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=pasic@linux.ibm.com \
    --cc=paul@xen.org \
    --cc=pbonzini@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=sstabellini@kernel.org \
    --cc=wainersm@redhat.com \
    --cc=wrampazz@redhat.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.