All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Christian König" <christian.koenig@amd.com>
To: Nirmoy Das <nirmoy.aiemd@gmail.com>, dri-devel@lists.freedesktop.org
Cc: thellstrom@vmware.com, airlied@linux.ie, kenny.ho@amd.com,
	brian.welty@intel.com, amd-gfx@lists.freedesktop.org,
	nirmoy.das@amd.com, linux-graphics-maintainer@vmware.com,
	kraxel@redhat.com, alexander.deucher@amd.com, sean@poorly.run,
	bskeggs@redhat.com
Subject: Re: [PATCH 7/8] drm/bochs: use drm_gem_vram_offset to get bo offset
Date: Mon, 17 Feb 2020 16:06:49 +0100	[thread overview]
Message-ID: <0a2c3e64-ae63-29ac-ac31-903ece7f075a@amd.com> (raw)
In-Reply-To: <20200217150427.49994-8-nirmoy.das@amd.com>

Am 17.02.20 um 16:04 schrieb Nirmoy Das:
> Switch over to GEM VRAM's implementation to retrieve bo->offset
>
> Signed-off-by: Nirmoy Das <nirmoy.das@amd.com>

Acked-by: Christian König <christian.koenig@amd.com>

> ---
>   drivers/gpu/drm/bochs/bochs_kms.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bochs/bochs_kms.c b/drivers/gpu/drm/bochs/bochs_kms.c
> index 8066d7d370d5..b8e1079f077e 100644
> --- a/drivers/gpu/drm/bochs/bochs_kms.c
> +++ b/drivers/gpu/drm/bochs/bochs_kms.c
> @@ -38,7 +38,7 @@ static void bochs_plane_update(struct bochs_device *bochs,
>   			 state->crtc_x,
>   			 state->crtc_y,
>   			 state->fb->pitches[0],
> -			 state->fb->offsets[0] + gbo->bo.offset);
> +			 state->fb->offsets[0] + drm_gem_vram_offset(gbo));
>   	bochs_hw_setformat(bochs, state->fb->format);
>   }
>   

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: "Christian König" <christian.koenig@amd.com>
To: Nirmoy Das <nirmoy.aiemd@gmail.com>, dri-devel@lists.freedesktop.org
Cc: David1.Zhou@amd.com, thellstrom@vmware.com, airlied@linux.ie,
	kenny.ho@amd.com, brian.welty@intel.com,
	maarten.lankhorst@linux.intel.com, amd-gfx@lists.freedesktop.org,
	nirmoy.das@amd.com, linux-graphics-maintainer@vmware.com,
	kraxel@redhat.com, daniel@ffwll.ch, alexander.deucher@amd.com,
	sean@poorly.run, bskeggs@redhat.com
Subject: Re: [PATCH 7/8] drm/bochs: use drm_gem_vram_offset to get bo offset
Date: Mon, 17 Feb 2020 16:06:49 +0100	[thread overview]
Message-ID: <0a2c3e64-ae63-29ac-ac31-903ece7f075a@amd.com> (raw)
In-Reply-To: <20200217150427.49994-8-nirmoy.das@amd.com>

Am 17.02.20 um 16:04 schrieb Nirmoy Das:
> Switch over to GEM VRAM's implementation to retrieve bo->offset
>
> Signed-off-by: Nirmoy Das <nirmoy.das@amd.com>

Acked-by: Christian König <christian.koenig@amd.com>

> ---
>   drivers/gpu/drm/bochs/bochs_kms.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bochs/bochs_kms.c b/drivers/gpu/drm/bochs/bochs_kms.c
> index 8066d7d370d5..b8e1079f077e 100644
> --- a/drivers/gpu/drm/bochs/bochs_kms.c
> +++ b/drivers/gpu/drm/bochs/bochs_kms.c
> @@ -38,7 +38,7 @@ static void bochs_plane_update(struct bochs_device *bochs,
>   			 state->crtc_x,
>   			 state->crtc_y,
>   			 state->fb->pitches[0],
> -			 state->fb->offsets[0] + gbo->bo.offset);
> +			 state->fb->offsets[0] + drm_gem_vram_offset(gbo));
>   	bochs_hw_setformat(bochs, state->fb->format);
>   }
>   

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  reply	other threads:[~2020-02-17 15:07 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-17 15:04 [PATCH 0/8] do not store GPU address in TTM Nirmoy Das
2020-02-17 15:04 ` Nirmoy Das
2020-02-17 15:04 ` [PATCH 1/8] drm/amdgpu: move ttm bo->offset to amdgpu_bo Nirmoy Das
2020-02-17 15:04   ` Nirmoy Das
2020-02-17 15:04 ` [PATCH 2/8] drm/radeon: don't use ttm bo->offset Nirmoy Das
2020-02-17 15:04   ` Nirmoy Das
2020-02-17 15:04 ` [PATCH 3/8] drm/vmwgfx: " Nirmoy Das
2020-02-17 15:04   ` Nirmoy Das
2020-02-17 15:04 ` [PATCH 4/8] drm/nouveau: " Nirmoy Das
2020-02-17 15:04   ` Nirmoy Das
2020-02-17 15:57   ` Alex Deucher
2020-02-17 15:57     ` Alex Deucher
2020-02-17 16:04     ` Nirmoy
2020-02-17 16:04       ` Nirmoy
2020-02-17 15:04 ` [PATCH 5/8] drm/qxl: " Nirmoy Das
2020-02-17 15:04   ` Nirmoy Das
2020-02-17 15:04 ` [PATCH 6/8] drm/vram-helper: " Nirmoy Das
2020-02-17 15:04   ` Nirmoy Das
2020-02-24  8:01   ` Gerd Hoffmann
2020-02-24  8:01     ` Gerd Hoffmann
2020-02-24  9:52     ` Nirmoy
2020-02-17 15:04 ` [PATCH 7/8] drm/bochs: use drm_gem_vram_offset to get bo offset Nirmoy Das
2020-02-17 15:04   ` Nirmoy Das
2020-02-17 15:06   ` Christian König [this message]
2020-02-17 15:06     ` Christian König
2020-02-24  8:01   ` Gerd Hoffmann
2020-02-24  8:01     ` Gerd Hoffmann
2020-02-17 15:04 ` [PATCH 8/8] drm/ttm: do not keep GPU dependent addresses Nirmoy Das
2020-02-17 15:04   ` Nirmoy Das
2020-02-18 12:40   ` Thomas Zimmermann
2020-02-18 12:40     ` Thomas Zimmermann
2020-02-18 12:44     ` Christian König
2020-02-18 12:44       ` Christian König
     [not found]       ` <9db59846-90b4-2b9a-8200-69297112693a-5C7GfCeVMHo@public.gmane.org>
2020-02-18 17:13         ` Nirmoy
2020-02-18 17:13           ` Nirmoy
2020-02-18 17:13           ` Nirmoy
     [not found]           ` <edc985f1-8856-4d1a-8960-efe4d21b960d-5C7GfCeVMHo@public.gmane.org>
2020-02-18 17:23             ` Christian König
2020-02-18 17:23               ` Christian König
2020-02-18 17:23               ` Christian König
2020-02-18 18:16             ` Thomas Zimmermann
2020-02-18 18:16               ` Thomas Zimmermann
2020-02-18 18:16               ` Thomas Zimmermann
     [not found]               ` <5b8db944-5a55-8161-6ab6-98490cfb0562-l3A5Bk7waGM@public.gmane.org>
2020-02-18 18:23                 ` Christian König
2020-02-18 18:23                   ` Christian König
2020-02-18 18:23                   ` Christian König
     [not found]                   ` <f8534965-ea14-bbac-bd34-06b951766a7c-5C7GfCeVMHo@public.gmane.org>
2020-02-18 18:28                     ` Thomas Zimmermann
2020-02-18 18:28                       ` Thomas Zimmermann
2020-02-18 18:28                       ` Thomas Zimmermann
     [not found]                       ` <48a5e3e2-cb9d-8328-1529-3558601ba860-l3A5Bk7waGM@public.gmane.org>
2020-02-18 18:37                         ` Christian König
2020-02-18 18:37                           ` Christian König
2020-02-18 18:37                           ` Christian König
     [not found]                           ` <31b0cac7-82c7-60ad-830b-66f7838a1047-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-02-18 19:06                             ` Daniel Vetter
2020-02-18 19:06                               ` [Nouveau] " Daniel Vetter
2020-02-18 19:06                               ` Daniel Vetter
     [not found]                               ` <20200218190639.GM2363188-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2020-02-19 12:47                                 ` Nirmoy
2020-02-19 12:47                                   ` Nirmoy
2020-02-19 12:47                                   ` Nirmoy
2020-02-18 18:30                 ` Nirmoy
2020-02-18 18:30                   ` Nirmoy
2020-02-18 18:30                   ` Nirmoy
2020-02-24  8:04             ` Gerd Hoffmann
2020-02-24  8:04               ` Gerd Hoffmann
2020-02-24  8:04               ` Gerd Hoffmann
2020-02-24  9:59               ` Nirmoy
2020-02-18 12:42 ` [PATCH 0/8] do not store GPU address in TTM Thomas Zimmermann
2020-02-18 12:42   ` Thomas Zimmermann
2020-02-18 15:57   ` Nirmoy
2020-02-18 15:57     ` Nirmoy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0a2c3e64-ae63-29ac-ac31-903ece7f075a@amd.com \
    --to=christian.koenig@amd.com \
    --cc=airlied@linux.ie \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=brian.welty@intel.com \
    --cc=bskeggs@redhat.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kenny.ho@amd.com \
    --cc=kraxel@redhat.com \
    --cc=linux-graphics-maintainer@vmware.com \
    --cc=nirmoy.aiemd@gmail.com \
    --cc=nirmoy.das@amd.com \
    --cc=sean@poorly.run \
    --cc=thellstrom@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.