From: Jens Axboe <axboe@fb.com>
To: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>
Cc: Keith Busch <keith.busch@intel.com>,
Max Gurtovoy <maxg@mellanox.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH 06/13] nvme-pci: refactor nvme_disable_io_queues
Date: Tue, 4 Dec 2018 18:19:53 +0000 [thread overview]
Message-ID: <0a96d78e-91c6-8367-e50d-35c239111a79@fb.com> (raw)
In-Reply-To: <20181204150517.GC3630@lst.de>
On 12/4/18 8:05 AM, Christoph Hellwig wrote:
> On Mon, Dec 03, 2018 at 05:00:59PM -0800, Sagi Grimberg wrote:
>>
>>> @@ -2428,7 +2426,8 @@ static void nvme_dev_disable(struct nvme_dev *dev, bool shutdown)
>>> nvme_stop_queues(&dev->ctrl);
>>> if (!dead && dev->ctrl.queue_count > 0) {
>>> - nvme_disable_io_queues(dev);
>>> + if (nvme_disable_io_queues(dev, nvme_admin_delete_sq))
>>> +
>>
>> Would be nice if the opcode change would be kept inside but still
>> split like:
>
> I actually like not having another wrapper to stop through..
>
> Keith, Jens, any preference?
Fine either way, prefer not having a wrapper.
--
Jens Axboe
WARNING: multiple messages have this Message-ID (diff)
From: axboe@fb.com (Jens Axboe)
Subject: [PATCH 06/13] nvme-pci: refactor nvme_disable_io_queues
Date: Tue, 4 Dec 2018 18:19:53 +0000 [thread overview]
Message-ID: <0a96d78e-91c6-8367-e50d-35c239111a79@fb.com> (raw)
In-Reply-To: <20181204150517.GC3630@lst.de>
On 12/4/18 8:05 AM, Christoph Hellwig wrote:
> On Mon, Dec 03, 2018@05:00:59PM -0800, Sagi Grimberg wrote:
>>
>>> @@ -2428,7 +2426,8 @@ static void nvme_dev_disable(struct nvme_dev *dev, bool shutdown)
>>> nvme_stop_queues(&dev->ctrl);
>>> if (!dead && dev->ctrl.queue_count > 0) {
>>> - nvme_disable_io_queues(dev);
>>> + if (nvme_disable_io_queues(dev, nvme_admin_delete_sq))
>>> +
>>
>> Would be nice if the opcode change would be kept inside but still
>> split like:
>
> I actually like not having another wrapper to stop through..
>
> Keith, Jens, any preference?
Fine either way, prefer not having a wrapper.
--
Jens Axboe
next prev parent reply other threads:[~2018-12-04 18:20 UTC|newest]
Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-02 16:46 block and nvme polling improvements V3 Christoph Hellwig
2018-12-02 16:46 ` Christoph Hellwig
2018-12-02 16:46 ` [PATCH 01/13] block: move queues types to the block layer Christoph Hellwig
2018-12-02 16:46 ` Christoph Hellwig
2018-12-04 0:49 ` Sagi Grimberg
2018-12-04 0:49 ` Sagi Grimberg
2018-12-04 15:00 ` Christoph Hellwig
2018-12-04 15:00 ` Christoph Hellwig
2018-12-04 17:08 ` Sagi Grimberg
2018-12-04 17:08 ` Sagi Grimberg
2018-12-02 16:46 ` [PATCH 02/13] nvme-pci: use atomic bitops to mark a queue enabled Christoph Hellwig
2018-12-02 16:46 ` Christoph Hellwig
2018-12-04 0:54 ` Sagi Grimberg
2018-12-04 0:54 ` Sagi Grimberg
2018-12-04 15:04 ` Christoph Hellwig
2018-12-04 15:04 ` Christoph Hellwig
2018-12-04 17:11 ` Sagi Grimberg
2018-12-04 17:11 ` Sagi Grimberg
2018-12-02 16:46 ` [PATCH 03/13] nvme-pci: cleanup SQ allocation a bit Christoph Hellwig
2018-12-02 16:46 ` Christoph Hellwig
2018-12-04 0:55 ` Sagi Grimberg
2018-12-04 0:55 ` Sagi Grimberg
2018-12-02 16:46 ` [PATCH 04/13] nvme-pci: only allow polling with separate poll queues Christoph Hellwig
2018-12-02 16:46 ` Christoph Hellwig
2018-12-03 18:23 ` Keith Busch
2018-12-03 18:23 ` Keith Busch
2018-12-04 0:56 ` Sagi Grimberg
2018-12-04 0:56 ` Sagi Grimberg
2018-12-02 16:46 ` [PATCH 05/13] nvme-pci: consolidate code for polling non-dedicated queues Christoph Hellwig
2018-12-02 16:46 ` Christoph Hellwig
2018-12-04 0:58 ` Sagi Grimberg
2018-12-04 0:58 ` Sagi Grimberg
2018-12-04 15:04 ` Christoph Hellwig
2018-12-04 15:04 ` Christoph Hellwig
2018-12-04 17:13 ` Sagi Grimberg
2018-12-04 17:13 ` Sagi Grimberg
2018-12-04 18:19 ` Jens Axboe
2018-12-04 18:19 ` Jens Axboe
2018-12-02 16:46 ` [PATCH 06/13] nvme-pci: refactor nvme_disable_io_queues Christoph Hellwig
2018-12-02 16:46 ` Christoph Hellwig
2018-12-04 1:00 ` Sagi Grimberg
2018-12-04 1:00 ` Sagi Grimberg
2018-12-04 15:05 ` Christoph Hellwig
2018-12-04 15:05 ` Christoph Hellwig
2018-12-04 18:19 ` Jens Axboe [this message]
2018-12-04 18:19 ` Jens Axboe
2018-12-02 16:46 ` [PATCH 07/13] nvme-pci: don't poll from irq context when deleting queues Christoph Hellwig
2018-12-02 16:46 ` Christoph Hellwig
2018-12-03 18:15 ` Keith Busch
2018-12-03 18:15 ` Keith Busch
2018-12-04 1:05 ` Sagi Grimberg
2018-12-04 1:05 ` Sagi Grimberg
2018-12-02 16:46 ` [PATCH 08/13] nvme-pci: remove the CQ lock for interrupt driven queues Christoph Hellwig
2018-12-02 16:46 ` Christoph Hellwig
2018-12-04 1:08 ` Sagi Grimberg
2018-12-04 1:08 ` Sagi Grimberg
2018-12-02 16:46 ` [PATCH 09/13] nvme-rdma: remove I/O polling support Christoph Hellwig
2018-12-02 16:46 ` Christoph Hellwig
2018-12-02 16:46 ` [PATCH 10/13] nvme-mpath: " Christoph Hellwig
2018-12-02 16:46 ` Christoph Hellwig
2018-12-03 18:22 ` Keith Busch
2018-12-03 18:22 ` Keith Busch
2018-12-04 1:11 ` Sagi Grimberg
2018-12-04 1:11 ` Sagi Grimberg
2018-12-04 15:07 ` Christoph Hellwig
2018-12-04 15:07 ` Christoph Hellwig
2018-12-04 17:18 ` Sagi Grimberg
2018-12-04 17:18 ` Sagi Grimberg
2018-12-02 16:46 ` [PATCH 11/13] block: remove ->poll_fn Christoph Hellwig
2018-12-02 16:46 ` Christoph Hellwig
2018-12-04 1:11 ` Sagi Grimberg
2018-12-04 1:11 ` Sagi Grimberg
2018-12-02 16:46 ` [PATCH 12/13] block: only allow polling if a poll queue_map exists Christoph Hellwig
2018-12-02 16:46 ` Christoph Hellwig
2018-12-04 1:14 ` Sagi Grimberg
2018-12-04 1:14 ` Sagi Grimberg
2018-12-02 16:46 ` [PATCH 13/13] block: enable polling by default if a poll map is initalized Christoph Hellwig
2018-12-02 16:46 ` Christoph Hellwig
2018-12-04 1:14 ` Sagi Grimberg
2018-12-04 1:14 ` Sagi Grimberg
2018-12-04 18:40 ` block and nvme polling improvements V3 Jens Axboe
2018-12-04 18:40 ` Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2018-11-29 19:12 block and nvme polling improvements V2 Christoph Hellwig
2018-11-29 19:13 ` [PATCH 06/13] nvme-pci: refactor nvme_disable_io_queues Christoph Hellwig
2018-11-29 19:13 ` Christoph Hellwig
2018-11-29 20:37 ` Keith Busch
2018-11-29 20:37 ` Keith Busch
2018-11-21 16:23 block and nvme polling improvements Christoph Hellwig
2018-11-21 16:23 ` [PATCH 06/13] nvme-pci: refactor nvme_disable_io_queues Christoph Hellwig
2018-11-21 16:23 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a96d78e-91c6-8367-e50d-35c239111a79@fb.com \
--to=axboe@fb.com \
--cc=hch@lst.de \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=maxg@mellanox.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.