From: Tomi Valkeinen <tomba@kernel.org>
To: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
dri-devel@lists.freedesktop.org
Cc: linux-renesas-soc@vger.kernel.org,
"Neil Armstrong" <narmstrong@baylibre.com>,
"Robert Foss" <robert.foss@linaro.org>,
"Jonas Karlman" <jonas@kwiboo.se>,
"Jernej Skrabec" <jernej.skrabec@siol.net>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Xinliang Liu" <xinliang.liu@linaro.org>,
"Tian Tao" <tiantao6@hisilicon.com>,
"Laurentiu Palcu" <laurentiu.palcu@oss.nxp.com>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Anitha Chrisanthus" <anitha.chrisanthus@intel.com>,
"Edmund Dea" <edmund.j.dea@intel.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Sandy Huang" <hjc@rock-chips.com>,
"Heiko Stübner" <heiko@sntech.de>,
"Benjamin Gaignard" <benjamin.gaignard@linaro.org>,
"Chen-Yu Tsai" <wens@csie.org>, "Jyri Sarha" <jyri.sarha@iki.fi>,
"Stephen Boyd" <swboyd@chromium.org>
Subject: Re: [PATCH] drm/bridge: Centralize error message when bridge attach fails
Date: Thu, 15 Apr 2021 08:56:26 +0300 [thread overview]
Message-ID: <0aafd2a9-d4e9-0684-f26d-a478f9e59105@kernel.org> (raw)
In-Reply-To: <20210415014710.4033-1-laurent.pinchart+renesas@ideasonboard.com>
On 15/04/2021 04:47, Laurent Pinchart wrote:
> Being informed of a failure to attach a bridge is useful, and many
> drivers prints an error message in that case. Move the message to
> drm_bridge_attach() to avoid code duplication.
>
> Suggested-by: Stephen Boyd <swboyd@chromium.org>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 9 +--------
> drivers/gpu/drm/bridge/analogix/anx7625.c | 5 +----
> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 1 -
> drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 10 +---------
> drivers/gpu/drm/drm_bridge.c | 10 ++++++++++
> drivers/gpu/drm/exynos/exynos_dp.c | 5 +----
> drivers/gpu/drm/exynos/exynos_hdmi.c | 5 +----
> drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c | 9 +--------
> drivers/gpu/drm/imx/dcss/dcss-kms.c | 5 +----
> drivers/gpu/drm/imx/imx-ldb.c | 4 +---
> drivers/gpu/drm/imx/parallel-display.c | 5 +----
> drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 4 +---
> drivers/gpu/drm/kmb/kmb_dsi.c | 1 -
> drivers/gpu/drm/mcde/mcde_dsi.c | 9 +--------
> drivers/gpu/drm/mediatek/mtk_dpi.c | 4 +---
> drivers/gpu/drm/mediatek/mtk_hdmi.c | 5 +----
> drivers/gpu/drm/omapdrm/omap_drv.c | 6 +-----
> drivers/gpu/drm/rockchip/rockchip_lvds.c | 5 +----
> drivers/gpu/drm/rockchip/rockchip_rgb.c | 5 +----
> drivers/gpu/drm/sti/sti_dvo.c | 4 +---
> drivers/gpu/drm/sun4i/sun4i_lvds.c | 4 +---
> drivers/gpu/drm/sun4i/sun4i_rgb.c | 4 +---
> drivers/gpu/drm/tegra/rgb.c | 5 +----
> drivers/gpu/drm/tidss/tidss_kms.c | 4 +---
> drivers/gpu/drm/tilcdc/tilcdc_external.c | 4 +---
> drivers/gpu/drm/vc4/vc4_dsi.c | 4 +---
> 26 files changed, 33 insertions(+), 103 deletions(-)
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Tomi
WARNING: multiple messages have this Message-ID (diff)
From: Tomi Valkeinen <tomba@kernel.org>
To: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
dri-devel@lists.freedesktop.org
Cc: Jernej Skrabec <jernej.skrabec@siol.net>,
Benjamin Gaignard <benjamin.gaignard@linaro.org>,
Jonas Karlman <jonas@kwiboo.se>,
Xinliang Liu <xinliang.liu@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Edmund Dea <edmund.j.dea@intel.com>,
Sandy Huang <hjc@rock-chips.com>,
Robert Foss <robert.foss@linaro.org>,
Stephen Boyd <swboyd@chromium.org>,
linux-renesas-soc@vger.kernel.org, Chen-Yu Tsai <wens@csie.org>,
Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>,
Anitha Chrisanthus <anitha.chrisanthus@intel.com>,
Tian Tao <tiantao6@hisilicon.com>, Jyri Sarha <jyri.sarha@iki.fi>
Subject: Re: [PATCH] drm/bridge: Centralize error message when bridge attach fails
Date: Thu, 15 Apr 2021 08:56:26 +0300 [thread overview]
Message-ID: <0aafd2a9-d4e9-0684-f26d-a478f9e59105@kernel.org> (raw)
In-Reply-To: <20210415014710.4033-1-laurent.pinchart+renesas@ideasonboard.com>
On 15/04/2021 04:47, Laurent Pinchart wrote:
> Being informed of a failure to attach a bridge is useful, and many
> drivers prints an error message in that case. Move the message to
> drm_bridge_attach() to avoid code duplication.
>
> Suggested-by: Stephen Boyd <swboyd@chromium.org>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 9 +--------
> drivers/gpu/drm/bridge/analogix/anx7625.c | 5 +----
> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 1 -
> drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 10 +---------
> drivers/gpu/drm/drm_bridge.c | 10 ++++++++++
> drivers/gpu/drm/exynos/exynos_dp.c | 5 +----
> drivers/gpu/drm/exynos/exynos_hdmi.c | 5 +----
> drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c | 9 +--------
> drivers/gpu/drm/imx/dcss/dcss-kms.c | 5 +----
> drivers/gpu/drm/imx/imx-ldb.c | 4 +---
> drivers/gpu/drm/imx/parallel-display.c | 5 +----
> drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 4 +---
> drivers/gpu/drm/kmb/kmb_dsi.c | 1 -
> drivers/gpu/drm/mcde/mcde_dsi.c | 9 +--------
> drivers/gpu/drm/mediatek/mtk_dpi.c | 4 +---
> drivers/gpu/drm/mediatek/mtk_hdmi.c | 5 +----
> drivers/gpu/drm/omapdrm/omap_drv.c | 6 +-----
> drivers/gpu/drm/rockchip/rockchip_lvds.c | 5 +----
> drivers/gpu/drm/rockchip/rockchip_rgb.c | 5 +----
> drivers/gpu/drm/sti/sti_dvo.c | 4 +---
> drivers/gpu/drm/sun4i/sun4i_lvds.c | 4 +---
> drivers/gpu/drm/sun4i/sun4i_rgb.c | 4 +---
> drivers/gpu/drm/tegra/rgb.c | 5 +----
> drivers/gpu/drm/tidss/tidss_kms.c | 4 +---
> drivers/gpu/drm/tilcdc/tilcdc_external.c | 4 +---
> drivers/gpu/drm/vc4/vc4_dsi.c | 4 +---
> 26 files changed, 33 insertions(+), 103 deletions(-)
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Tomi
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-04-15 5:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 1:47 [PATCH] drm/bridge: Centralize error message when bridge attach fails Laurent Pinchart
2021-04-15 1:47 ` Laurent Pinchart
2021-04-15 5:56 ` Tomi Valkeinen [this message]
2021-04-15 5:56 ` Tomi Valkeinen
2021-04-15 10:12 ` Jyri Sarha
2021-04-15 10:12 ` Jyri Sarha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0aafd2a9-d4e9-0684-f26d-a478f9e59105@kernel.org \
--to=tomba@kernel.org \
--cc=anitha.chrisanthus@intel.com \
--cc=benjamin.gaignard@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=edmund.j.dea@intel.com \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=jernej.skrabec@siol.net \
--cc=jingoohan1@gmail.com \
--cc=jonas@kwiboo.se \
--cc=jyri.sarha@iki.fi \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=laurentiu.palcu@oss.nxp.com \
--cc=linus.walleij@linaro.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=robert.foss@linaro.org \
--cc=swboyd@chromium.org \
--cc=tiantao6@hisilicon.com \
--cc=wens@csie.org \
--cc=xinliang.liu@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.