From: Steven Price <steven.price@arm.com> To: Martin Schwidefsky <schwidefsky@de.ibm.com> Cc: "Mark Rutland" <Mark.Rutland@arm.com>, linux-s390@vger.kernel.org, x86@kernel.org, "Arnd Bergmann" <arnd@arndb.de>, "Ard Biesheuvel" <ard.biesheuvel@linaro.org>, "Peter Zijlstra" <peterz@infradead.org>, "Catalin Marinas" <catalin.marinas@arm.com>, "Dave Hansen" <dave.hansen@linux.intel.com>, "Will Deacon" <will.deacon@arm.com>, linux-kernel@vger.kernel.org, "Heiko Carstens" <heiko.carstens@de.ibm.com>, linux-mm@kvack.org, "Jérôme Glisse" <jglisse@redhat.com>, "Ingo Molnar" <mingo@redhat.com>, "Borislav Petkov" <bp@alien8.de>, "Andy Lutomirski" <luto@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>, "James Morse" <james.morse@arm.com>, "Thomas Gleixner" <tglx@linutronix.de>, linux-arm-kernel@lists.infradead.org, "Liang, Kan" <kan.liang@linux.intel.com> Subject: Re: [PATCH v3 18/34] s390: mm: Add p?d_large() definitions Date: Thu, 28 Feb 2019 11:43:29 +0000 [thread overview] Message-ID: <0ad6ff76-bbe8-122c-f0e1-54f567dc9753@arm.com> (raw) In-Reply-To: <20190227184012.2e251154@mschwideX1> On 27/02/2019 17:40, Martin Schwidefsky wrote: > On Wed, 27 Feb 2019 17:05:52 +0000 > Steven Price <steven.price@arm.com> wrote: > >> walk_page_range() is going to be allowed to walk page tables other than >> those of user space. For this it needs to know when it has reached a >> 'leaf' entry in the page tables. This information is provided by the >> p?d_large() functions/macros. >> >> For s390, we don't support large pages, so add a stub returning 0. > > Well s390 does support 1MB and 2GB large pages, pmd_large() and pud_large() > are non-empty. We do not support 4TB or 8PB large pages though, which > makes the patch itself correct. Just the wording is slightly off. Sorry, you're absolutely right - I'll update the commit message for the next posting. Thanks, Steve >> CC: Martin Schwidefsky <schwidefsky@de.ibm.com> >> CC: Heiko Carstens <heiko.carstens@de.ibm.com> >> CC: linux-s390@vger.kernel.org >> Signed-off-by: Steven Price <steven.price@arm.com> >> --- >> arch/s390/include/asm/pgtable.h | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/arch/s390/include/asm/pgtable.h b/arch/s390/include/asm/pgtable.h >> index 063732414dfb..9617f1fb69b4 100644 >> --- a/arch/s390/include/asm/pgtable.h >> +++ b/arch/s390/include/asm/pgtable.h >> @@ -605,6 +605,11 @@ static inline int pgd_present(pgd_t pgd) >> return (pgd_val(pgd) & _REGION_ENTRY_ORIGIN) != 0UL; >> } >> >> +static inline int pgd_large(pgd_t pgd) >> +{ >> + return 0; >> +} >> + >> static inline int pgd_none(pgd_t pgd) >> { >> if (pgd_folded(pgd)) >> @@ -645,6 +650,11 @@ static inline int p4d_present(p4d_t p4d) >> return (p4d_val(p4d) & _REGION_ENTRY_ORIGIN) != 0UL; >> } >> >> +static inline int p4d_large(p4d_t p4d) >> +{ >> + return 0; >> +} >> + >> static inline int p4d_none(p4d_t p4d) >> { >> if (p4d_folded(p4d)) > >
WARNING: multiple messages have this Message-ID (diff)
From: Steven Price <steven.price@arm.com> To: Martin Schwidefsky <schwidefsky@de.ibm.com> Cc: "Mark Rutland" <Mark.Rutland@arm.com>, linux-s390@vger.kernel.org, "Dave Hansen" <dave.hansen@linux.intel.com>, "Arnd Bergmann" <arnd@arndb.de>, "Ard Biesheuvel" <ard.biesheuvel@linaro.org>, "Peter Zijlstra" <peterz@infradead.org>, "Catalin Marinas" <catalin.marinas@arm.com>, x86@kernel.org, "Will Deacon" <will.deacon@arm.com>, linux-kernel@vger.kernel.org, "Heiko Carstens" <heiko.carstens@de.ibm.com>, linux-mm@kvack.org, "Jérôme Glisse" <jglisse@redhat.com>, "Ingo Molnar" <mingo@redhat.com>, "Borislav Petkov" <bp@alien8.de>, "Andy Lutomirski" <luto@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>, "James Morse" <james.morse@arm.com>, "Thomas Gleixner" <tglx@linutronix.de>, linux-arm-kernel@lists.infradead.org, "Liang, Kan" <kan.liang@linux.intel.com> Subject: Re: [PATCH v3 18/34] s390: mm: Add p?d_large() definitions Date: Thu, 28 Feb 2019 11:43:29 +0000 [thread overview] Message-ID: <0ad6ff76-bbe8-122c-f0e1-54f567dc9753@arm.com> (raw) In-Reply-To: <20190227184012.2e251154@mschwideX1> On 27/02/2019 17:40, Martin Schwidefsky wrote: > On Wed, 27 Feb 2019 17:05:52 +0000 > Steven Price <steven.price@arm.com> wrote: > >> walk_page_range() is going to be allowed to walk page tables other than >> those of user space. For this it needs to know when it has reached a >> 'leaf' entry in the page tables. This information is provided by the >> p?d_large() functions/macros. >> >> For s390, we don't support large pages, so add a stub returning 0. > > Well s390 does support 1MB and 2GB large pages, pmd_large() and pud_large() > are non-empty. We do not support 4TB or 8PB large pages though, which > makes the patch itself correct. Just the wording is slightly off. Sorry, you're absolutely right - I'll update the commit message for the next posting. Thanks, Steve >> CC: Martin Schwidefsky <schwidefsky@de.ibm.com> >> CC: Heiko Carstens <heiko.carstens@de.ibm.com> >> CC: linux-s390@vger.kernel.org >> Signed-off-by: Steven Price <steven.price@arm.com> >> --- >> arch/s390/include/asm/pgtable.h | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/arch/s390/include/asm/pgtable.h b/arch/s390/include/asm/pgtable.h >> index 063732414dfb..9617f1fb69b4 100644 >> --- a/arch/s390/include/asm/pgtable.h >> +++ b/arch/s390/include/asm/pgtable.h >> @@ -605,6 +605,11 @@ static inline int pgd_present(pgd_t pgd) >> return (pgd_val(pgd) & _REGION_ENTRY_ORIGIN) != 0UL; >> } >> >> +static inline int pgd_large(pgd_t pgd) >> +{ >> + return 0; >> +} >> + >> static inline int pgd_none(pgd_t pgd) >> { >> if (pgd_folded(pgd)) >> @@ -645,6 +650,11 @@ static inline int p4d_present(p4d_t p4d) >> return (p4d_val(p4d) & _REGION_ENTRY_ORIGIN) != 0UL; >> } >> >> +static inline int p4d_large(p4d_t p4d) >> +{ >> + return 0; >> +} >> + >> static inline int p4d_none(p4d_t p4d) >> { >> if (p4d_folded(p4d)) > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-02-28 11:43 UTC|newest] Thread overview: 153+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-02-27 17:05 [PATCH v3 00/34] Convert x86 & arm64 to use generic page walk Steven Price 2019-02-27 17:05 ` Steven Price 2019-02-27 17:05 ` [PATCH v3 01/34] alpha: mm: Add p?d_large() definitions Steven Price 2019-02-27 17:05 ` Steven Price 2019-02-27 17:05 ` Steven Price 2019-02-27 17:05 ` [PATCH v3 02/34] arc: " Steven Price 2019-02-27 17:05 ` Steven Price 2019-02-27 17:05 ` Steven Price 2019-02-27 18:18 ` Vineet Gupta 2019-02-27 18:18 ` Vineet Gupta 2019-02-27 18:18 ` Vineet Gupta 2019-02-27 18:18 ` Vineet Gupta 2019-02-27 17:05 ` [PATCH v3 03/34] arm: " Steven Price 2019-02-27 17:05 ` Steven Price 2019-03-01 21:47 ` Kirill A. Shutemov 2019-03-01 21:47 ` Kirill A. Shutemov 2019-03-04 11:56 ` Steven Price 2019-03-04 11:56 ` Steven Price 2019-03-04 13:10 ` Kirill A. Shutemov 2019-03-04 13:10 ` Kirill A. Shutemov 2019-02-27 17:05 ` [PATCH v3 04/34] arm64: " Steven Price 2019-02-27 17:05 ` Steven Price 2019-02-27 17:05 ` [PATCH v3 05/34] c6x: " Steven Price 2019-02-27 17:05 ` Steven Price 2019-03-01 21:48 ` Kirill A. Shutemov 2019-03-01 21:48 ` Kirill A. Shutemov 2019-03-04 12:01 ` Steven Price 2019-03-04 12:01 ` Steven Price 2019-03-04 13:11 ` Kirill A. Shutemov 2019-03-04 13:11 ` Kirill A. Shutemov 2019-02-27 17:05 ` [PATCH v3 06/34] csky: " Steven Price 2019-02-27 17:05 ` Steven Price 2019-03-01 21:51 ` Kirill A. Shutemov 2019-03-01 21:51 ` Kirill A. Shutemov 2019-02-27 17:05 ` [PATCH v3 07/34] hexagon: " Steven Price 2019-02-27 17:05 ` Steven Price 2019-02-27 17:05 ` Steven Price 2019-02-27 17:05 ` [PATCH v3 08/34] ia64: " Steven Price 2019-02-27 17:05 ` Steven Price 2019-03-01 21:57 ` Kirill A. Shutemov 2019-03-01 21:57 ` Kirill A. Shutemov 2019-03-01 21:57 ` Kirill A. Shutemov 2019-03-04 13:16 ` Steven Price 2019-03-04 13:16 ` Steven Price 2019-03-04 13:16 ` Steven Price 2019-03-04 19:06 ` Luck, Tony 2019-03-04 19:06 ` Luck, Tony 2019-03-04 19:06 ` Luck, Tony 2019-03-06 13:45 ` Steven Price 2019-03-06 13:45 ` Steven Price 2019-03-06 13:45 ` Steven Price 2019-02-27 17:05 ` [PATCH v3 09/34] m68k: " Steven Price 2019-02-27 17:05 ` Steven Price 2019-02-27 19:27 ` Geert Uytterhoeven 2019-02-27 19:27 ` Geert Uytterhoeven 2019-02-28 11:36 ` Mike Rapoport 2019-02-28 11:36 ` Mike Rapoport 2019-02-28 11:53 ` Geert Uytterhoeven 2019-02-28 11:53 ` Geert Uytterhoeven 2019-02-28 12:04 ` Steven Price 2019-02-28 12:04 ` Steven Price 2019-03-01 11:45 ` Mike Rapoport 2019-03-01 11:45 ` Mike Rapoport 2019-02-27 17:05 ` [PATCH v3 10/34] microblaze: " Steven Price 2019-02-27 17:05 ` Steven Price 2019-02-27 17:05 ` [PATCH v3 11/34] mips: " Steven Price 2019-02-27 17:05 ` Steven Price 2019-02-28 2:15 ` Paul Burton 2019-02-28 2:15 ` Paul Burton 2019-02-28 12:11 ` Steven Price 2019-02-28 12:11 ` Steven Price 2019-02-28 18:55 ` Paul Burton 2019-02-28 18:55 ` Paul Burton 2019-03-01 11:02 ` Steven Price 2019-03-01 11:02 ` Steven Price 2019-02-27 17:05 ` [PATCH v3 12/34] nds32: " Steven Price 2019-02-27 17:05 ` Steven Price 2019-02-27 17:05 ` [PATCH v3 13/34] nios2: " Steven Price 2019-02-27 17:05 ` Steven Price 2019-02-27 17:05 ` [PATCH v3 14/34] openrisc: " Steven Price 2019-02-27 17:05 ` [OpenRISC] " Steven Price 2019-02-27 17:05 ` Steven Price 2019-02-27 17:05 ` [PATCH v3 15/34] parisc: " Steven Price 2019-02-27 17:05 ` Steven Price 2019-02-27 18:54 ` Helge Deller 2019-02-27 18:54 ` Helge Deller 2019-03-01 22:12 ` Kirill A. Shutemov 2019-03-01 22:12 ` Kirill A. Shutemov 2019-03-05 21:45 ` Helge Deller 2019-03-05 21:45 ` Helge Deller 2019-02-27 17:05 ` [PATCH v3 16/34] powerpc: " Steven Price 2019-02-27 17:05 ` Steven Price 2019-02-27 17:05 ` Steven Price 2019-02-27 17:05 ` Steven Price 2019-02-27 17:05 ` [PATCH v3 17/34] riscv: " Steven Price 2019-02-27 17:05 ` Steven Price 2019-02-27 17:05 ` Steven Price 2019-02-27 17:05 ` [PATCH v3 18/34] s390: " Steven Price 2019-02-27 17:05 ` Steven Price 2019-02-27 17:40 ` Martin Schwidefsky 2019-02-27 17:40 ` Martin Schwidefsky 2019-02-28 11:43 ` Steven Price [this message] 2019-02-28 11:43 ` Steven Price 2019-02-27 17:05 ` [PATCH v3 19/34] sh: " Steven Price 2019-02-27 17:05 ` Steven Price 2019-02-27 17:05 ` Steven Price 2019-02-27 17:05 ` [PATCH v3 20/34] sparc: " Steven Price 2019-02-27 17:05 ` Steven Price 2019-02-27 17:05 ` Steven Price 2019-02-27 18:38 ` David Miller 2019-02-27 18:38 ` David Miller 2019-02-27 18:38 ` David Miller 2019-02-28 11:49 ` Steven Price 2019-02-28 11:49 ` Steven Price 2019-02-28 11:49 ` Steven Price 2019-02-27 17:05 ` [PATCH v3 21/34] um: " Steven Price 2019-02-27 17:05 ` Steven Price 2019-02-27 17:05 ` [PATCH v3 22/34] unicore32: " Steven Price 2019-02-27 17:05 ` Steven Price 2019-02-27 17:05 ` [PATCH v3 23/34] xtensa: " Steven Price 2019-02-27 17:05 ` Steven Price 2019-02-27 17:29 ` Max Filippov 2019-02-27 17:29 ` Max Filippov 2019-02-27 17:05 ` [PATCH v3 24/34] mm: Add generic p?d_large() macros Steven Price 2019-02-27 17:05 ` Steven Price 2019-02-27 17:05 ` [PATCH v3 25/34] mm: pagewalk: Add p4d_entry() and pgd_entry() Steven Price 2019-02-27 17:05 ` Steven Price 2019-02-27 17:06 ` [PATCH v3 26/34] mm: pagewalk: Allow walking without vma Steven Price 2019-02-27 17:06 ` Steven Price 2019-02-27 17:06 ` [PATCH v3 27/34] mm: pagewalk: Add 'depth' parameter to pte_hole Steven Price 2019-02-27 17:06 ` Steven Price 2019-02-27 17:38 ` Dave Hansen 2019-02-27 17:38 ` Dave Hansen 2019-02-28 11:28 ` Steven Price 2019-02-28 11:28 ` Steven Price 2019-02-28 19:00 ` Dave Hansen 2019-02-28 19:00 ` Dave Hansen 2019-03-01 11:24 ` Steven Price 2019-03-01 11:24 ` Steven Price 2019-02-27 17:06 ` [PATCH v3 28/34] mm: pagewalk: Add test_p?d callbacks Steven Price 2019-02-27 17:06 ` Steven Price 2019-02-27 17:06 ` [PATCH v3 29/34] arm64: mm: Convert mm/dump.c to use walk_page_range() Steven Price 2019-02-27 17:06 ` Steven Price 2019-02-27 17:06 ` [PATCH v3 30/34] x86/mm: Point to struct seq_file from struct pg_state Steven Price 2019-02-27 17:06 ` Steven Price 2019-02-27 17:06 ` [PATCH v3 31/34] x86/mm+efi: Convert ptdump_walk_pgd_level() to take a mm_struct Steven Price 2019-02-27 17:06 ` Steven Price 2019-02-27 17:06 ` [PATCH v3 32/34] x86/mm: Convert ptdump_walk_pgd_level_debugfs() to take an mm_struct Steven Price 2019-02-27 17:06 ` Steven Price 2019-02-27 17:06 ` [PATCH v3 33/34] x86/mm: Convert ptdump_walk_pgd_level_core() " Steven Price 2019-02-27 17:06 ` Steven Price 2019-02-27 17:06 ` [PATCH v3 34/34] x86: mm: Convert dump_pagetables to use walk_page_range Steven Price 2019-02-27 17:06 ` Steven Price
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=0ad6ff76-bbe8-122c-f0e1-54f567dc9753@arm.com \ --to=steven.price@arm.com \ --cc=Mark.Rutland@arm.com \ --cc=ard.biesheuvel@linaro.org \ --cc=arnd@arndb.de \ --cc=bp@alien8.de \ --cc=catalin.marinas@arm.com \ --cc=dave.hansen@linux.intel.com \ --cc=heiko.carstens@de.ibm.com \ --cc=hpa@zytor.com \ --cc=james.morse@arm.com \ --cc=jglisse@redhat.com \ --cc=kan.liang@linux.intel.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=linux-s390@vger.kernel.org \ --cc=luto@kernel.org \ --cc=mingo@redhat.com \ --cc=peterz@infradead.org \ --cc=schwidefsky@de.ibm.com \ --cc=tglx@linutronix.de \ --cc=will.deacon@arm.com \ --cc=x86@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.