From: Alexey Kardashevskiy <aik@ozlabs.ru>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: llvm@lists.linux.dev, linuxppc-dev@lists.ozlabs.org,
Nicholas Piggin <npiggin@gmail.com>,
Nathan Chancellor <nathan@kernel.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Sathvika Vasireddy <sv@linux.ibm.com>,
Russell Currey <ruscur@russell.cc>,
"Naveen N . Rao" <naveen.n.rao@linux.vnet.ibm.com>,
Sami Tolvanen <samitolvanen@google.com>
Subject: Re: [PATCH kernel] powerpc/llvm/lto: Allow LLVM LTO builds
Date: Wed, 4 May 2022 12:18:13 +1000 [thread overview]
Message-ID: <0b2a1361-e0a4-35b2-c58d-ef4b913c025e@ozlabs.ru> (raw)
In-Reply-To: <CAKwvOdmFhua9b4=DS4QYJmKg=0kT3CtEjXgfo8fnifU2t-ttPQ@mail.gmail.com>
On 5/4/22 07:24, Nick Desaulniers wrote:
> On Thu, Apr 28, 2022 at 11:46 PM Alexey Kardashevskiy <aik@ozlabs.ru> wrote:
>>
>> diff --git a/arch/powerpc/kernel/exceptions-64s.S b/arch/powerpc/kernel/exceptions-64s.S
>> index b66dd6f775a4..5b783bd51260 100644
>> --- a/arch/powerpc/kernel/exceptions-64s.S
>> +++ b/arch/powerpc/kernel/exceptions-64s.S
>> @@ -476,9 +476,11 @@ DEFINE_FIXED_SYMBOL(\name\()_common_real, text)
>> .if IHSRR_IF_HVMODE
>> BEGIN_FTR_SECTION
>> bne masked_Hinterrupt
>> + b 4f
>> FTR_SECTION_ELSE
>
> Do you need to have the ELSE even if there's nothing in it; should it
> have a nop? The rest of the assembler changes LGTM, but withholding
> RB tag until we have Kconfig dependencies in better shape.
The FTR patcher will add the necessary amount of "nop"s there and
dropping "FTR_SECTION_ELSE" breaks the build as it does some
"pushsection" magic.
>
>> - bne masked_interrupt
>> ALT_FTR_SECTION_END_IFSET(CPU_FTR_HVMODE | CPU_FTR_ARCH_206)
>> + bne masked_interrupt
>> +4:
>> .elseif IHSRR
>> bne masked_Hinterrupt
>> .else
>
WARNING: multiple messages have this Message-ID (diff)
From: Alexey Kardashevskiy <aik@ozlabs.ru>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: llvm@lists.linux.dev, Nicholas Piggin <npiggin@gmail.com>,
Nathan Chancellor <nathan@kernel.org>,
Sathvika Vasireddy <sv@linux.ibm.com>,
Sami Tolvanen <samitolvanen@google.com>,
"Naveen N . Rao" <naveen.n.rao@linux.vnet.ibm.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH kernel] powerpc/llvm/lto: Allow LLVM LTO builds
Date: Wed, 4 May 2022 12:18:13 +1000 [thread overview]
Message-ID: <0b2a1361-e0a4-35b2-c58d-ef4b913c025e@ozlabs.ru> (raw)
In-Reply-To: <CAKwvOdmFhua9b4=DS4QYJmKg=0kT3CtEjXgfo8fnifU2t-ttPQ@mail.gmail.com>
On 5/4/22 07:24, Nick Desaulniers wrote:
> On Thu, Apr 28, 2022 at 11:46 PM Alexey Kardashevskiy <aik@ozlabs.ru> wrote:
>>
>> diff --git a/arch/powerpc/kernel/exceptions-64s.S b/arch/powerpc/kernel/exceptions-64s.S
>> index b66dd6f775a4..5b783bd51260 100644
>> --- a/arch/powerpc/kernel/exceptions-64s.S
>> +++ b/arch/powerpc/kernel/exceptions-64s.S
>> @@ -476,9 +476,11 @@ DEFINE_FIXED_SYMBOL(\name\()_common_real, text)
>> .if IHSRR_IF_HVMODE
>> BEGIN_FTR_SECTION
>> bne masked_Hinterrupt
>> + b 4f
>> FTR_SECTION_ELSE
>
> Do you need to have the ELSE even if there's nothing in it; should it
> have a nop? The rest of the assembler changes LGTM, but withholding
> RB tag until we have Kconfig dependencies in better shape.
The FTR patcher will add the necessary amount of "nop"s there and
dropping "FTR_SECTION_ELSE" breaks the build as it does some
"pushsection" magic.
>
>> - bne masked_interrupt
>> ALT_FTR_SECTION_END_IFSET(CPU_FTR_HVMODE | CPU_FTR_ARCH_206)
>> + bne masked_interrupt
>> +4:
>> .elseif IHSRR
>> bne masked_Hinterrupt
>> .else
>
next prev parent reply other threads:[~2022-05-04 2:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-29 6:45 [PATCH kernel] powerpc/llvm/lto: Allow LLVM LTO builds Alexey Kardashevskiy
2022-04-29 6:45 ` Alexey Kardashevskiy
2022-05-03 21:21 ` Nick Desaulniers
2022-05-03 21:21 ` Nick Desaulniers
2022-05-04 7:11 ` Alexey Kardashevskiy
2022-05-04 7:11 ` Alexey Kardashevskiy
2022-05-04 12:17 ` Alexey Kardashevskiy
2022-05-04 12:17 ` Alexey Kardashevskiy
2022-05-09 5:18 ` Alexey Kardashevskiy
2022-05-09 5:18 ` Alexey Kardashevskiy
2022-05-09 7:42 ` Alexey Kardashevskiy
2022-05-09 7:42 ` Alexey Kardashevskiy
2022-05-09 18:07 ` Nathan Chancellor
2022-05-09 18:07 ` Nathan Chancellor
2022-05-09 18:19 ` Nick Desaulniers
2022-05-09 18:19 ` Nick Desaulniers
2022-05-10 6:18 ` Fangrui Song
2022-05-10 6:18 ` Fangrui Song
2022-05-03 21:24 ` Nick Desaulniers
2022-05-03 21:24 ` Nick Desaulniers
2022-05-04 2:18 ` Alexey Kardashevskiy [this message]
2022-05-04 2:18 ` Alexey Kardashevskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b2a1361-e0a4-35b2-c58d-ef4b913c025e@ozlabs.ru \
--to=aik@ozlabs.ru \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=llvm@lists.linux.dev \
--cc=mpe@ellerman.id.au \
--cc=nathan@kernel.org \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=ndesaulniers@google.com \
--cc=npiggin@gmail.com \
--cc=ruscur@russell.cc \
--cc=samitolvanen@google.com \
--cc=sv@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.