From: "Ceraolo Spurio, Daniele" <daniele.ceraolospurio@intel.com>
To: "Teres Alexis, Alan Previn" <alan.previn.teres.alexis@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Cc: "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 3/6] drm/i915/uc/gsc: extract release and security versions from the gsc binary
Date: Fri, 26 May 2023 18:27:56 -0700 [thread overview]
Message-ID: <0b37018d-2805-bea8-085c-1deede3f102a@intel.com> (raw)
In-Reply-To: <674e85c47cd29b39ad902e5445234b93b2f99883.camel@intel.com>
<snip>
>> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_gsc_meu_headers.h b/drivers/gpu/drm/i915/gt/uc/intel_gsc_meu_headers.h
>> index d55a66202576..8bce2b8aed84 100644
>> --- a/drivers/gpu/drm/i915/gt/uc/intel_gsc_meu_headers.h
>> +++ b/drivers/gpu/drm/i915/gt/uc/intel_gsc_meu_headers.h
> alan:snip
>
>
>
>> +struct intel_gsc_layout_pointers {
>> + u8 rom_bypass_vector[16];
> alan:snip...
>> + u32 temp_pages_offset;
>> + u32 temp_pages_size;
>> +} __packed;
> alan: structure layout seems unnecessarily repetitive... why not ->
> struct partition_info {
> u32 offset;
> u32 size;
> };
> struct intel_gsc_layout_pointers {
> u8 rom_bypass_vector[16];
> ...
> struct partition_info datap;
> struct partition_info bootregion[5];
> struct partition_info trace;
> }__packed;
>
I've just realized that I didn't reply to this comment. The specs have
the structure defined that way, so I tried to keep a 1:1 match like we
usually do. I think switching to a partition_info structure is ok, but
I'll avoid the array because the GSC partition are 1-based, which could
cause confusion (i.e. partition boot1 would be bootregion[0]).
Daniele
WARNING: multiple messages have this Message-ID (diff)
From: "Ceraolo Spurio, Daniele" <daniele.ceraolospurio@intel.com>
To: "Teres Alexis, Alan Previn" <alan.previn.teres.alexis@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Cc: "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH 3/6] drm/i915/uc/gsc: extract release and security versions from the gsc binary
Date: Fri, 26 May 2023 18:27:56 -0700 [thread overview]
Message-ID: <0b37018d-2805-bea8-085c-1deede3f102a@intel.com> (raw)
In-Reply-To: <674e85c47cd29b39ad902e5445234b93b2f99883.camel@intel.com>
<snip>
>> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_gsc_meu_headers.h b/drivers/gpu/drm/i915/gt/uc/intel_gsc_meu_headers.h
>> index d55a66202576..8bce2b8aed84 100644
>> --- a/drivers/gpu/drm/i915/gt/uc/intel_gsc_meu_headers.h
>> +++ b/drivers/gpu/drm/i915/gt/uc/intel_gsc_meu_headers.h
> alan:snip
>
>
>
>> +struct intel_gsc_layout_pointers {
>> + u8 rom_bypass_vector[16];
> alan:snip...
>> + u32 temp_pages_offset;
>> + u32 temp_pages_size;
>> +} __packed;
> alan: structure layout seems unnecessarily repetitive... why not ->
> struct partition_info {
> u32 offset;
> u32 size;
> };
> struct intel_gsc_layout_pointers {
> u8 rom_bypass_vector[16];
> ...
> struct partition_info datap;
> struct partition_info bootregion[5];
> struct partition_info trace;
> }__packed;
>
I've just realized that I didn't reply to this comment. The specs have
the structure defined that way, so I tried to keep a 1:1 match like we
usually do. I think switching to a partition_info structure is ok, but
I'll avoid the array because the GSC partition are 1-based, which could
cause confusion (i.e. partition boot1 would be bootregion[0]).
Daniele
next prev parent reply other threads:[~2023-05-27 1:28 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-05 16:04 [PATCH 0/6] drm/i915: GSC FW support for MTL Daniele Ceraolo Spurio
2023-05-05 16:04 ` [Intel-gfx] " Daniele Ceraolo Spurio
2023-05-05 16:04 ` [PATCH 1/6] DO NOT REVIEW: drm/i915: HuC loading and authentication " Daniele Ceraolo Spurio
2023-05-05 16:04 ` [Intel-gfx] " Daniele Ceraolo Spurio
2023-05-05 16:04 ` [PATCH 2/6] drm/i915/uc/gsc: fixes and updates for GSC memory allocation Daniele Ceraolo Spurio
2023-05-05 16:04 ` [Intel-gfx] " Daniele Ceraolo Spurio
2023-05-23 0:13 ` Teres Alexis, Alan Previn
2023-05-23 0:13 ` [Intel-gfx] " Teres Alexis, Alan Previn
2023-05-23 15:21 ` Ceraolo Spurio, Daniele
2023-05-23 15:21 ` [Intel-gfx] " Ceraolo Spurio, Daniele
2023-06-06 0:00 ` Teres Alexis, Alan Previn
2023-06-06 0:00 ` [Intel-gfx] " Teres Alexis, Alan Previn
2023-05-05 16:04 ` [PATCH 3/6] drm/i915/uc/gsc: extract release and security versions from the gsc binary Daniele Ceraolo Spurio
2023-05-05 16:04 ` [Intel-gfx] " Daniele Ceraolo Spurio
2023-05-25 5:14 ` Teres Alexis, Alan Previn
2023-05-25 5:14 ` [Intel-gfx] " Teres Alexis, Alan Previn
2023-05-25 16:56 ` Ceraolo Spurio, Daniele
2023-05-25 16:56 ` [Intel-gfx] " Ceraolo Spurio, Daniele
2023-05-25 22:03 ` Teres Alexis, Alan Previn
2023-05-25 22:03 ` [Intel-gfx] " Teres Alexis, Alan Previn
2023-05-27 1:27 ` Ceraolo Spurio, Daniele [this message]
2023-05-27 1:27 ` Ceraolo Spurio, Daniele
2023-06-05 23:51 ` Teres Alexis, Alan Previn
2023-06-05 23:51 ` [Intel-gfx] " Teres Alexis, Alan Previn
2023-05-05 16:04 ` [PATCH 4/6] drm/i915/uc/gsc: query the GSC FW for its compatibility version Daniele Ceraolo Spurio
2023-05-05 16:04 ` [Intel-gfx] " Daniele Ceraolo Spurio
2023-05-25 23:29 ` Teres Alexis, Alan Previn
2023-05-25 23:29 ` [Intel-gfx] " Teres Alexis, Alan Previn
2023-05-05 16:04 ` [PATCH 5/6] drm/i915/uc/gsc: define gsc fw Daniele Ceraolo Spurio
2023-05-05 16:04 ` [Intel-gfx] " Daniele Ceraolo Spurio
2023-05-25 23:48 ` Teres Alexis, Alan Previn
2023-05-25 23:48 ` [Intel-gfx] " Teres Alexis, Alan Previn
2023-06-01 0:32 ` Ceraolo Spurio, Daniele
2023-06-01 0:32 ` [Intel-gfx] " Ceraolo Spurio, Daniele
2023-05-05 16:04 ` [PATCH 6/6] drm/i915/uc/gsc: Add a gsc_info debugfs Daniele Ceraolo Spurio
2023-05-05 16:04 ` [Intel-gfx] " Daniele Ceraolo Spurio
2023-05-26 22:57 ` Teres Alexis, Alan Previn
2023-05-26 22:57 ` [Intel-gfx] " Teres Alexis, Alan Previn
2023-06-01 0:25 ` Ceraolo Spurio, Daniele
2023-06-01 0:25 ` [Intel-gfx] " Ceraolo Spurio, Daniele
2023-06-05 23:46 ` Teres Alexis, Alan Previn
2023-06-05 23:46 ` [Intel-gfx] " Teres Alexis, Alan Previn
2023-06-05 23:53 ` Ceraolo Spurio, Daniele
2023-06-05 23:53 ` [Intel-gfx] " Ceraolo Spurio, Daniele
2023-05-05 21:02 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915: GSC FW support for MTL Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b37018d-2805-bea8-085c-1deede3f102a@intel.com \
--to=daniele.ceraolospurio@intel.com \
--cc=alan.previn.teres.alexis@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.