From: Baolin Wang <baolin.wang@linaro.org>
To: dan.j.williams@intel.com, vkoul@kernel.org
Cc: thierry.reding@gmail.com, jonathanh@nvidia.com,
linux-tegra@vger.kernel.org, shawnguo@kernel.org,
s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com, linux-imx@nxp.com,
wsa+renesas@sang-engineering.com, jroedel@suse.de,
vincent.guittot@linaro.org, baolin.wang@linaro.org,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 8/8] dmaengine: sh: usb-dmac: Let the core do the device node validation
Date: Mon, 20 May 2019 19:32:21 +0800 [thread overview]
Message-ID: <0b4418a1891261a6a4f8e8356b68e38f4ed6a1d5.1558351667.git.baolin.wang@linaro.org> (raw)
In-Reply-To: <cover.1558351667.git.baolin.wang@linaro.org>
In-Reply-To: <cover.1558351667.git.baolin.wang@linaro.org>
Let the DMA engine core do the device node validation instead of drivers.
Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
---
drivers/dma/sh/usb-dmac.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/dma/sh/usb-dmac.c b/drivers/dma/sh/usb-dmac.c
index 59403f6..0afabf3 100644
--- a/drivers/dma/sh/usb-dmac.c
+++ b/drivers/dma/sh/usb-dmac.c
@@ -636,9 +636,6 @@ static bool usb_dmac_chan_filter(struct dma_chan *chan, void *arg)
struct usb_dmac_chan *uchan = to_usb_dmac_chan(chan);
struct of_phandle_args *dma_spec = arg;
- if (dma_spec->np != chan->device->dev->of_node)
- return false;
-
/* USB-DMAC should be used with fixed usb controller's FIFO */
if (uchan->index != dma_spec->args[0])
return false;
@@ -659,7 +656,8 @@ static struct dma_chan *usb_dmac_of_xlate(struct of_phandle_args *dma_spec,
dma_cap_zero(mask);
dma_cap_set(DMA_SLAVE, mask);
- chan = dma_request_channel(mask, usb_dmac_chan_filter, dma_spec);
+ chan = __dma_request_channel(&mask, usb_dmac_chan_filter, dma_spec,
+ ofdma->of_node);
if (!chan)
return NULL;
--
1.7.9.5
WARNING: multiple messages have this Message-ID (diff)
From: Baolin Wang <baolin.wang@linaro.org>
To: dan.j.williams@intel.com, vkoul@kernel.org
Cc: jroedel@suse.de, vincent.guittot@linaro.org,
dmaengine@vger.kernel.org, baolin.wang@linaro.org,
festevam@gmail.com, s.hauer@pengutronix.de,
linux-kernel@vger.kernel.org, jonathanh@nvidia.com,
wsa+renesas@sang-engineering.com, thierry.reding@gmail.com,
linux-imx@nxp.com, kernel@pengutronix.de,
linux-tegra@vger.kernel.org, shawnguo@kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 8/8] dmaengine: sh: usb-dmac: Let the core do the device node validation
Date: Mon, 20 May 2019 19:32:21 +0800 [thread overview]
Message-ID: <0b4418a1891261a6a4f8e8356b68e38f4ed6a1d5.1558351667.git.baolin.wang@linaro.org> (raw)
In-Reply-To: <cover.1558351667.git.baolin.wang@linaro.org>
In-Reply-To: <cover.1558351667.git.baolin.wang@linaro.org>
Let the DMA engine core do the device node validation instead of drivers.
Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
---
drivers/dma/sh/usb-dmac.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/dma/sh/usb-dmac.c b/drivers/dma/sh/usb-dmac.c
index 59403f6..0afabf3 100644
--- a/drivers/dma/sh/usb-dmac.c
+++ b/drivers/dma/sh/usb-dmac.c
@@ -636,9 +636,6 @@ static bool usb_dmac_chan_filter(struct dma_chan *chan, void *arg)
struct usb_dmac_chan *uchan = to_usb_dmac_chan(chan);
struct of_phandle_args *dma_spec = arg;
- if (dma_spec->np != chan->device->dev->of_node)
- return false;
-
/* USB-DMAC should be used with fixed usb controller's FIFO */
if (uchan->index != dma_spec->args[0])
return false;
@@ -659,7 +656,8 @@ static struct dma_chan *usb_dmac_of_xlate(struct of_phandle_args *dma_spec,
dma_cap_zero(mask);
dma_cap_set(DMA_SLAVE, mask);
- chan = dma_request_channel(mask, usb_dmac_chan_filter, dma_spec);
+ chan = __dma_request_channel(&mask, usb_dmac_chan_filter, dma_spec,
+ ofdma->of_node);
if (!chan)
return NULL;
--
1.7.9.5
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-05-20 11:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 11:32 [PATCH v2 0/8] Add matching device node validation in DMA engine core Baolin Wang
2019-05-20 11:32 ` Baolin Wang
2019-05-20 11:32 ` [PATCH v2 1/8] dmaengine: Add matching device node validation in __dma_request_channel() Baolin Wang
2019-05-20 11:32 ` Baolin Wang
2019-05-20 11:32 ` [PATCH v2 2/8] soc: tegra: fuse: Use dma_request_channel instead of __dma_request_channel() Baolin Wang
2019-05-20 11:32 ` Baolin Wang
2019-05-20 11:32 ` [PATCH v2 3/8] dmaengine: imx-sdma: Let the core do the device node validation Baolin Wang
2019-05-20 11:32 ` Baolin Wang
2019-05-20 11:32 ` [PATCH v2 4/8] dmaengine: dma-jz4780: " Baolin Wang
2019-05-20 11:32 ` Baolin Wang
2019-05-20 11:32 ` [PATCH v2 5/8] dmaengine: mmp_tdma: " Baolin Wang
2019-05-20 11:32 ` Baolin Wang
2019-05-20 11:32 ` [PATCH v2 6/8] dmaengine: mxs-dma: " Baolin Wang
2019-05-20 11:32 ` Baolin Wang
2019-05-20 11:32 ` [PATCH v2 7/8] dmaengine: sh: rcar-dmac: " Baolin Wang
2019-05-20 11:32 ` Baolin Wang
2019-05-20 11:32 ` Baolin Wang [this message]
2019-05-20 11:32 ` [PATCH v2 8/8] dmaengine: sh: usb-dmac: " Baolin Wang
2019-05-27 5:54 ` [PATCH v2 0/8] Add matching device node validation in DMA engine core Vinod Koul
2019-05-27 5:54 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b4418a1891261a6a4f8e8356b68e38f4ed6a1d5.1558351667.git.baolin.wang@linaro.org \
--to=baolin.wang@linaro.org \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=jroedel@suse.de \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=vincent.guittot@linaro.org \
--cc=vkoul@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.