From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-kernel@vger.kernel.org
Cc: linux-renesas-soc@vger.kernel.org,
Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <edubezval@gmail.com>,
linux-pm@vger.kernel.org
Subject: Re: [PATCH 4/5] thermal: st: st_thermal: simplify getting .driver_data
Date: Mon, 5 Nov 2018 16:06:30 +0100 [thread overview]
Message-ID: <0c7d3c84-c073-087e-eafb-c93bb5d43ea7@linaro.org> (raw)
In-Reply-To: <20181021200053.2194-5-wsa+renesas@sang-engineering.com>
On 21/10/2018 22:00, Wolfram Sang wrote:
> We should get 'driver_data' from 'struct device' directly. Going via
> platform_device is an unneeded step back and forth.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
>
> Build tested only. buildbot is happy.
>
> drivers/thermal/st/st_thermal.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/thermal/st/st_thermal.c b/drivers/thermal/st/st_thermal.c
> index be637e6b01d2..b2bbdf6eb02b 100644
> --- a/drivers/thermal/st/st_thermal.c
> +++ b/drivers/thermal/st/st_thermal.c
> @@ -277,8 +277,7 @@ EXPORT_SYMBOL_GPL(st_thermal_unregister);
> #ifdef CONFIG_PM_SLEEP
> static int st_thermal_suspend(struct device *dev)
> {
> - struct platform_device *pdev = to_platform_device(dev);
> - struct st_thermal_sensor *sensor = platform_get_drvdata(pdev);
> + struct st_thermal_sensor *sensor = dev_get_drvdata(dev);
>
> return st_thermal_sensor_off(sensor);
> }
> @@ -286,8 +285,7 @@ static int st_thermal_suspend(struct device *dev)
> static int st_thermal_resume(struct device *dev)
> {
> int ret;
> - struct platform_device *pdev = to_platform_device(dev);
> - struct st_thermal_sensor *sensor = platform_get_drvdata(pdev);
> + struct st_thermal_sensor *sensor = dev_get_drvdata(dev);
>
> ret = st_thermal_sensor_on(sensor);
> if (ret)
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2018-11-05 15:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-21 20:00 [PATCH 0/5] thermal: simplify getting .driver_data Wolfram Sang
2018-10-21 20:00 ` Wolfram Sang
2018-10-21 20:00 ` [PATCH 1/5] thermal: int340x_thermal: int3400_thermal: " Wolfram Sang
2018-11-05 15:04 ` Daniel Lezcano
2018-10-21 20:00 ` [PATCH 2/5] thermal: rockchip_thermal: " Wolfram Sang
2018-10-21 20:00 ` Wolfram Sang
2018-11-02 12:25 ` Heiko Stuebner
2018-11-02 12:25 ` Heiko Stuebner
2018-11-05 15:05 ` Daniel Lezcano
2018-11-05 15:05 ` Daniel Lezcano
2018-10-21 20:00 ` [PATCH 3/5] thermal: spear_thermal: " Wolfram Sang
2018-11-05 15:06 ` Daniel Lezcano
2018-10-21 20:00 ` [PATCH 4/5] thermal: st: st_thermal: " Wolfram Sang
2018-11-05 15:06 ` Daniel Lezcano [this message]
2018-10-21 20:00 ` [PATCH 5/5] thermal: zx2967_thermal: " Wolfram Sang
2018-10-21 20:00 ` Wolfram Sang
2018-10-22 1:12 ` Shawn Guo
2018-10-22 1:12 ` Shawn Guo
2018-11-05 15:07 ` Daniel Lezcano
2018-11-05 15:07 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c7d3c84-c073-087e-eafb-c93bb5d43ea7@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=edubezval@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.