From: Wolfram Sang <wsa+renesas@sang-engineering.com> To: linux-kernel@vger.kernel.org Cc: linux-renesas-soc@vger.kernel.org, Wolfram Sang <wsa+renesas@sang-engineering.com>, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: [PATCH 0/5] thermal: simplify getting .driver_data Date: Sun, 21 Oct 2018 22:00:47 +0200 [thread overview] Message-ID: <20181021200053.2194-1-wsa+renesas@sang-engineering.com> (raw) I got tired of fixing this in Renesas drivers manually, so I took the big hammer. Remove this cumbersome code pattern which got copy-pasted too much already: - struct platform_device *pdev = to_platform_device(dev); - struct ep93xx_keypad *keypad = platform_get_drvdata(pdev); + struct ep93xx_keypad *keypad = dev_get_drvdata(dev); A branch, tested by buildbot, can be found here: git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git coccinelle/get_drvdata I have been asked if it couldn't be done for dev_set_drvdata as well. I checked it and did not find one occasion where it could be simplified like this. Not much of a surprise because driver_data is usually set in probe() functions which access struct platform_device in many other ways. I am open for other comments, suggestions, too, of course. Here is the cocci-script I created: @@ struct device* d; identifier pdev; expression *ptr; @@ ( - struct platform_device *pdev = to_platform_device(d); | - struct platform_device *pdev; ... - pdev = to_platform_device(d); ) <... when != pdev - &pdev->dev + d ...> ptr = - platform_get_drvdata(pdev) + dev_get_drvdata(d) <... when != pdev - &pdev->dev + d ...> Kind regards, Wolfram Wolfram Sang (5): thermal: int340x_thermal: int3400_thermal: simplify getting .driver_data thermal: rockchip_thermal: simplify getting .driver_data thermal: spear_thermal: simplify getting .driver_data thermal: st: st_thermal: simplify getting .driver_data thermal: zx2967_thermal: simplify getting .driver_data drivers/thermal/int340x_thermal/int3400_thermal.c | 9 +++------ drivers/thermal/rockchip_thermal.c | 8 +++----- drivers/thermal/spear_thermal.c | 8 +++----- drivers/thermal/st/st_thermal.c | 6 ++---- drivers/thermal/zx2967_thermal.c | 6 ++---- 5 files changed, 13 insertions(+), 24 deletions(-) -- 2.19.0
WARNING: multiple messages have this Message-ID (diff)
From: wsa+renesas@sang-engineering.com (Wolfram Sang) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 0/5] thermal: simplify getting .driver_data Date: Sun, 21 Oct 2018 22:00:47 +0200 [thread overview] Message-ID: <20181021200053.2194-1-wsa+renesas@sang-engineering.com> (raw) I got tired of fixing this in Renesas drivers manually, so I took the big hammer. Remove this cumbersome code pattern which got copy-pasted too much already: - struct platform_device *pdev = to_platform_device(dev); - struct ep93xx_keypad *keypad = platform_get_drvdata(pdev); + struct ep93xx_keypad *keypad = dev_get_drvdata(dev); A branch, tested by buildbot, can be found here: git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git coccinelle/get_drvdata I have been asked if it couldn't be done for dev_set_drvdata as well. I checked it and did not find one occasion where it could be simplified like this. Not much of a surprise because driver_data is usually set in probe() functions which access struct platform_device in many other ways. I am open for other comments, suggestions, too, of course. Here is the cocci-script I created: @@ struct device* d; identifier pdev; expression *ptr; @@ ( - struct platform_device *pdev = to_platform_device(d); | - struct platform_device *pdev; ... - pdev = to_platform_device(d); ) <... when != pdev - &pdev->dev + d ...> ptr = - platform_get_drvdata(pdev) + dev_get_drvdata(d) <... when != pdev - &pdev->dev + d ...> Kind regards, Wolfram Wolfram Sang (5): thermal: int340x_thermal: int3400_thermal: simplify getting .driver_data thermal: rockchip_thermal: simplify getting .driver_data thermal: spear_thermal: simplify getting .driver_data thermal: st: st_thermal: simplify getting .driver_data thermal: zx2967_thermal: simplify getting .driver_data drivers/thermal/int340x_thermal/int3400_thermal.c | 9 +++------ drivers/thermal/rockchip_thermal.c | 8 +++----- drivers/thermal/spear_thermal.c | 8 +++----- drivers/thermal/st/st_thermal.c | 6 ++---- drivers/thermal/zx2967_thermal.c | 6 ++---- 5 files changed, 13 insertions(+), 24 deletions(-) -- 2.19.0
next reply other threads:[~2018-10-21 20:00 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-10-21 20:00 Wolfram Sang [this message] 2018-10-21 20:00 ` [PATCH 0/5] thermal: simplify getting .driver_data Wolfram Sang 2018-10-21 20:00 ` [PATCH 1/5] thermal: int340x_thermal: int3400_thermal: " Wolfram Sang 2018-11-05 15:04 ` Daniel Lezcano 2018-10-21 20:00 ` [PATCH 2/5] thermal: rockchip_thermal: " Wolfram Sang 2018-10-21 20:00 ` Wolfram Sang 2018-11-02 12:25 ` Heiko Stuebner 2018-11-02 12:25 ` Heiko Stuebner 2018-11-05 15:05 ` Daniel Lezcano 2018-11-05 15:05 ` Daniel Lezcano 2018-10-21 20:00 ` [PATCH 3/5] thermal: spear_thermal: " Wolfram Sang 2018-11-05 15:06 ` Daniel Lezcano 2018-10-21 20:00 ` [PATCH 4/5] thermal: st: st_thermal: " Wolfram Sang 2018-11-05 15:06 ` Daniel Lezcano 2018-10-21 20:00 ` [PATCH 5/5] thermal: zx2967_thermal: " Wolfram Sang 2018-10-21 20:00 ` Wolfram Sang 2018-10-22 1:12 ` Shawn Guo 2018-10-22 1:12 ` Shawn Guo 2018-11-05 15:07 ` Daniel Lezcano 2018-11-05 15:07 ` Daniel Lezcano
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20181021200053.2194-1-wsa+renesas@sang-engineering.com \ --to=wsa+renesas@sang-engineering.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=linux-rockchip@lists.infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.