All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chun-Jie Chen <chun-jie.chen@mediatek.com>
To: Matthias Brugger <matthias.bgg@gmail.com>,
	Enric Balletbo i Serra <enric.balletbo@collabora.com>,
	Nicolas Boichat <drinkcat@chromium.org>,
	"Rob Herring" <robh+dt@kernel.org>
Cc: <linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-mediatek@lists.infradead.org>,
	<srv_heupstream@mediatek.com>,
	<Project_Global_Chrome_Upstream_Group@mediatek.com>,
	chun-jie.chen <chun-jie.chen@mediatek.corp-partner.google.com>
Subject: Re: [PATCH 3/3] soc: mediatek: pm-domains: Add support for mt8195
Date: Tue, 15 Jun 2021 09:42:36 +0800	[thread overview]
Message-ID: <0ce161d31c4b0a8dc862d5e6c89a3e2f62d32a10.camel@mediatek.com> (raw)
In-Reply-To: <f050f072-1732-b6f0-f505-2d0a44563ce5@gmail.com>

On Thu, 2021-06-10 at 10:50 +0200, Matthias Brugger wrote:
> Hi Chun-Jie,
> 
> Thanks for the patch, comments below.
> 
> On 10/06/2021 04:36, Chun-Jie Chen wrote:
> > From: "chun-jie.chen" <
> > chun-jie.chen@mediatek.corp-partner.google.com>
> > 
> > Add the needed board data to support mt8195 SoC.
> > 
> 
> Please try to come up with a better commit message. Especially
> mention that we
> have to increase the SPM_MAX_BUS_PROT_DATA.
> 
> > Signed-off-by: chun-jie.chen <chun-jie.chen@mediatek.com>
> 
> I suppose your name would be "Chun-Jie Chen"
> 
> Please also fix your git settings to that From and Signed-off-by
> matches.
> 
> [...]
> 
> >  
> > diff --git a/drivers/soc/mediatek/mtk-pm-domains.h
> > b/drivers/soc/mediatek/mtk-pm-domains.h
> > index 8b86ed22ca56..1b8967b9829e 100644
> > --- a/drivers/soc/mediatek/mtk-pm-domains.h
> > +++ b/drivers/soc/mediatek/mtk-pm-domains.h
> > @@ -37,7 +37,7 @@
> >  #define PWR_STATUS_AUDIO		BIT(24)
> >  #define PWR_STATUS_USB			BIT(25)
> >  
> > -#define SPM_MAX_BUS_PROT_DATA		5
> > +#define SPM_MAX_BUS_PROT_DATA		6
> >  
> >  #define _BUS_PROT(_mask, _set, _clr, _sta, _update, _ignore) {	
> > \
> >  		.bus_prot_mask = (_mask),			\
> > @@ -72,8 +72,6 @@ struct scpsys_bus_prot_data {
> >  	bool ignore_clr_ack;
> >  };
> >  
> > -#define MAX_SUBSYS_CLKS 10
> > -
> 
> Good catch, not needed define. Can you put that in a new patch
> please?
> 
> Regards,
> Matthias

Thanks for your comments, I will send v2 to fix it.

Best Regards,
Chun-Jie
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Chun-Jie Chen <chun-jie.chen@mediatek.com>
To: Matthias Brugger <matthias.bgg@gmail.com>,
	Enric Balletbo i Serra <enric.balletbo@collabora.com>,
	Nicolas Boichat <drinkcat@chromium.org>,
	"Rob Herring" <robh+dt@kernel.org>
Cc: <linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-mediatek@lists.infradead.org>,
	<srv_heupstream@mediatek.com>,
	<Project_Global_Chrome_Upstream_Group@mediatek.com>,
	chun-jie.chen <chun-jie.chen@mediatek.corp-partner.google.com>
Subject: Re: [PATCH 3/3] soc: mediatek: pm-domains: Add support for mt8195
Date: Tue, 15 Jun 2021 09:42:36 +0800	[thread overview]
Message-ID: <0ce161d31c4b0a8dc862d5e6c89a3e2f62d32a10.camel@mediatek.com> (raw)
In-Reply-To: <f050f072-1732-b6f0-f505-2d0a44563ce5@gmail.com>

On Thu, 2021-06-10 at 10:50 +0200, Matthias Brugger wrote:
> Hi Chun-Jie,
> 
> Thanks for the patch, comments below.
> 
> On 10/06/2021 04:36, Chun-Jie Chen wrote:
> > From: "chun-jie.chen" <
> > chun-jie.chen@mediatek.corp-partner.google.com>
> > 
> > Add the needed board data to support mt8195 SoC.
> > 
> 
> Please try to come up with a better commit message. Especially
> mention that we
> have to increase the SPM_MAX_BUS_PROT_DATA.
> 
> > Signed-off-by: chun-jie.chen <chun-jie.chen@mediatek.com>
> 
> I suppose your name would be "Chun-Jie Chen"
> 
> Please also fix your git settings to that From and Signed-off-by
> matches.
> 
> [...]
> 
> >  
> > diff --git a/drivers/soc/mediatek/mtk-pm-domains.h
> > b/drivers/soc/mediatek/mtk-pm-domains.h
> > index 8b86ed22ca56..1b8967b9829e 100644
> > --- a/drivers/soc/mediatek/mtk-pm-domains.h
> > +++ b/drivers/soc/mediatek/mtk-pm-domains.h
> > @@ -37,7 +37,7 @@
> >  #define PWR_STATUS_AUDIO		BIT(24)
> >  #define PWR_STATUS_USB			BIT(25)
> >  
> > -#define SPM_MAX_BUS_PROT_DATA		5
> > +#define SPM_MAX_BUS_PROT_DATA		6
> >  
> >  #define _BUS_PROT(_mask, _set, _clr, _sta, _update, _ignore) {	
> > \
> >  		.bus_prot_mask = (_mask),			\
> > @@ -72,8 +72,6 @@ struct scpsys_bus_prot_data {
> >  	bool ignore_clr_ack;
> >  };
> >  
> > -#define MAX_SUBSYS_CLKS 10
> > -
> 
> Good catch, not needed define. Can you put that in a new patch
> please?
> 
> Regards,
> Matthias

Thanks for your comments, I will send v2 to fix it.

Best Regards,
Chun-Jie
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-06-15 16:09 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-10  2:36 [PATCH 0/3] Mediatek MT8195 power domain support Chun-Jie Chen
2021-06-10  2:36 ` Chun-Jie Chen
2021-06-10  2:36 ` Chun-Jie Chen
2021-06-10  2:36 ` [PATCH 1/3] soc: mediatek: pm-domains: Move power status offset to power domain data Chun-Jie Chen
2021-06-10  2:36   ` Chun-Jie Chen
2021-06-10  2:36 ` [PATCH 2/3] dt-bindings: power: Add MT8195 power domains Chun-Jie Chen
2021-06-10  2:36   ` Chun-Jie Chen
2021-06-10  2:36 ` [PATCH 3/3] soc: mediatek: pm-domains: Add support for mt8195 Chun-Jie Chen
2021-06-10  2:36   ` Chun-Jie Chen
2021-06-10  8:50   ` Matthias Brugger
2021-06-10  8:50     ` Matthias Brugger
2021-06-10  8:50     ` Matthias Brugger
2021-06-15  1:42     ` Chun-Jie Chen [this message]
2021-06-15  1:42       ` Chun-Jie Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0ce161d31c4b0a8dc862d5e6c89a3e2f62d32a10.camel@mediatek.com \
    --to=chun-jie.chen@mediatek.com \
    --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
    --cc=chun-jie.chen@mediatek.corp-partner.google.com \
    --cc=devicetree@vger.kernel.org \
    --cc=drinkcat@chromium.org \
    --cc=enric.balletbo@collabora.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=srv_heupstream@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.