From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Jagadeesh Kona <quic_jkona@quicinc.com>,
Andy Gross <agross@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Taniya Das <quic_tdas@quicinc.com>,
Satya Priya Kakitapalli <quic_skakitap@quicinc.com>
Subject: Re: [PATCH 3/4] clk: qcom: camcc-sm8550: Add camera clock controller driver for SM8550
Date: Fri, 19 May 2023 21:26:52 +0100 [thread overview]
Message-ID: <0d0a1985-a08b-29ed-4bc4-2eea560d7ac0@linaro.org> (raw)
In-Reply-To: <20230519155602.6642-4-quic_jkona@quicinc.com>
On 19/05/2023 16:56, Jagadeesh Kona wrote:
> +MODULE_DESCRIPTION("QTI CAM_CC SM8550 Driver");
This pattern looks odd and inconsistent in our clock drivers. We mostly
have CAMCC or VIDEOCC but occasionally have CAM_CC and VIDEO_CC.
I'd drop that underscore to, in addition to Konrad's comment on Ucase hex.
Other than that, LGTM.
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
next prev parent reply other threads:[~2023-05-19 20:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-19 15:55 [PATCH 0/4] Add camera clock controller support for SM8550 Jagadeesh Kona
2023-05-19 15:55 ` [PATCH 1/4] clk: qcom: clk-alpha-pll: Add support for rivian ole pll ops Jagadeesh Kona
2023-05-19 16:49 ` Konrad Dybcio
2023-05-25 16:42 ` Jagadeesh Kona
2023-05-19 15:56 ` [PATCH 2/4] dt-bindings: clock: qcom: Add SM8550 camera clock controller Jagadeesh Kona
2023-05-19 16:48 ` Conor Dooley
2023-05-25 16:58 ` Jagadeesh Kona
2023-05-19 15:56 ` [PATCH 3/4] clk: qcom: camcc-sm8550: Add camera clock controller driver for SM8550 Jagadeesh Kona
2023-05-19 16:52 ` Konrad Dybcio
2023-05-25 16:47 ` Jagadeesh Kona
2023-05-19 20:26 ` Bryan O'Donoghue [this message]
2023-05-25 16:49 ` Jagadeesh Kona
2023-05-19 15:56 ` [PATCH 4/4] arm64: dts: qcom: sm8550: Add camera clock controller Jagadeesh Kona
2023-05-19 16:52 ` Konrad Dybcio
2023-05-25 16:52 ` Jagadeesh Kona
2023-05-19 19:29 ` [PATCH 0/4] Add camera clock controller support for SM8550 Dmitry Baryshkov
2023-05-25 16:54 ` Jagadeesh Kona
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d0a1985-a08b-29ed-4bc4-2eea560d7ac0@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_jkona@quicinc.com \
--cc=quic_skakitap@quicinc.com \
--cc=quic_tdas@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.