Re: [PATCH 2/4] dt-bindings: clock: qcom: Add SM8550 camera clock controller

From: Jagadeesh Kona <quic_jkona@quicinc.com>
To: Conor Dooley <conor@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	<linux-arm-msm@vger.kernel.org>, <linux-clk@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	Taniya Das <quic_tdas@quicinc.com>,
	"Satya Priya Kakitapalli" <quic_skakitap@quicinc.com>,
	<quic_ajipan@quicinc.com>, <quic_imrashai@quicinc.com>
Subject: Re: [PATCH 2/4] dt-bindings: clock: qcom: Add SM8550 camera clock controller
Date: Thu, 25 May 2023 22:28:38 +0530	[thread overview]
Message-ID: <86396e49-96e8-20d1-7753-0e2e5a9c0347@quicinc.com> (raw)
In-Reply-To: <20230519-crumb-vividly-0d278146defe@spud>

Hi Conor,

Thanks for your review!

On 5/19/2023 10:18 PM, Conor Dooley wrote:
> On Fri, May 19, 2023 at 09:26:00PM +0530, Jagadeesh Kona wrote:
>> Add device tree bindings for the camera clock controller on
>> Qualcomm SM8550 platform.
>>
>> Signed-off-by: Jagadeesh Kona <quic_jkona@quicinc.com>
>> Signed-off-by: Taniya Das <quic_tdas@quicinc.com>
> 
> Should this SoB go with a Co-developed-by?
> I'll leave it up to Krzysztof or someone else familiar with qcom
> products as to whether there's an existing binding that this should be
> added to, but qcom,videocc.yaml seems "suspect" to an outsider.
> 
> Otherwise, what you have here looks fine to me.
> 
> Thanks,
> Conor.
Will reuse SM8450 CAMCC YAML file for SM8550

Thanks & Regards,
Jagadeesh