All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Relinquish any fence when changing cache levels
Date: Wed, 13 Apr 2011 22:42:54 +0100	[thread overview]
Message-ID: <0d30dc$lr13nf@orsmga001.jf.intel.com> (raw)
In-Reply-To: <20110413204646.GL3660@viiv.ffwll.ch>

On Wed, 13 Apr 2011 22:46:47 +0200, Daniel Vetter <daniel@ffwll.ch> wrote:
> set_cache_level is rather unused on pre-snb. Can't we just hold off with
> such complexity before we actually use it in e.g. the vmap code? Maybe add
> a WARN_ON(gen < 6) instead?

You might argue that set_cache_level is not used even on SNB at the point at
which we are writing the interface for it...

Once you've finished reviewing this code, I have another batch... ;-)
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

      reply	other threads:[~2011-04-13 21:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-13 12:25 [PATCH] drm/i915: Relinquish any fence when changing cache levels Chris Wilson
2011-04-13 16:36 ` Eric Anholt
2011-04-13 16:59   ` Chris Wilson
2011-04-13 18:01   ` Chris Wilson
2011-04-13 20:46     ` Daniel Vetter
2011-04-13 21:42       ` Chris Wilson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='0d30dc$lr13nf@orsmga001.jf.intel.com' \
    --to=chris@chris-wilson.co.uk \
    --cc=daniel@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.