From: Rex-BC Chen <rex-bc.chen@mediatek.com>
To: CK Hu <ck.hu@mediatek.com>, <chunkuang.hu@kernel.org>,
<p.zabel@pengutronix.de>, <daniel@ffwll.ch>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <matthias.bgg@gmail.com>,
<airlied@linux.ie>
Cc: <msp@baylibre.com>, <granquet@baylibre.com>,
<jitao.shi@mediatek.com>, <wenst@chromium.org>,
<angelogioacchino.delregno@collabora.com>,
<dri-devel@lists.freedesktop.org>,
<linux-mediatek@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<Project_Global_Chrome_Upstream_Group@mediatek.com>
Subject: Re: [PATCH v12 13/14] drm/mediatek: dpi: Only enable dpi after the bridge is enabled
Date: Tue, 21 Jun 2022 14:02:30 +0800 [thread overview]
Message-ID: <0d35d7b6e0677b6eb1118c5a180229bfbdc77e7b.camel@mediatek.com> (raw)
In-Reply-To: <f8915cb4af91375dc9d7fc9c51f04863dd3e97dd.camel@mediatek.com>
On Tue, 2022-06-21 at 11:18 +0800, CK Hu wrote:
> Hi, Bo-Chen:
>
> On Mon, 2022-06-20 at 20:10 +0800, Bo-Chen Chen wrote:
> > From: Guillaume Ranquet <granquet@baylibre.com>
> >
> > Enabling the dpi too early causes glitches on screen.
> >
> > Move the call to mtk_dpi_enable() at the end of the bridge_enable
> > callback to ensure everything is setup properly before enabling
> > dpi.
> >
> > Fixes: f89c696e7f63 ("drm/mediatek: mtk_dpi: Convert to bridge
> > driver")
>
> I think this problem happen in the first patch [1].
>
> [1]
>
https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/commit/drivers/gpu/drm/mediatek/mtk_dpi.c?h=mediatek-drm-next&id=9e629c17aa8d7a75b8c1d99ed42892cd8ba7cdc4
>
> Regards,
> CK
>
ok, I will fix this.
BRs,
Bo-Chen
> > Signed-off-by: Guillaume Ranquet <granquet@baylibre.com>
> > Signed-off-by: Bo-Chen Chen <rex-bc.chen@mediatek.com>
> > ---
> > drivers/gpu/drm/mediatek/mtk_dpi.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c
> > b/drivers/gpu/drm/mediatek/mtk_dpi.c
> > index fc76ccad0a82..220e9b18e2cd 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
> > @@ -486,7 +486,6 @@ static int mtk_dpi_power_on(struct mtk_dpi
> > *dpi)
> > if (dpi->pinctrl && dpi->pins_dpi)
> > pinctrl_select_state(dpi->pinctrl, dpi->pins_dpi);
> >
> > - mtk_dpi_enable(dpi);
> > return 0;
> >
> > err_pixel:
> > @@ -731,6 +730,7 @@ static void mtk_dpi_bridge_enable(struct
> > drm_bridge *bridge)
> >
> > mtk_dpi_power_on(dpi);
> > mtk_dpi_set_display_mode(dpi, &dpi->mode);
> > + mtk_dpi_enable(dpi);
> > }
> >
> > static enum drm_mode_status
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Rex-BC Chen <rex-bc.chen@mediatek.com>
To: CK Hu <ck.hu@mediatek.com>, <chunkuang.hu@kernel.org>,
<p.zabel@pengutronix.de>, <daniel@ffwll.ch>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <matthias.bgg@gmail.com>,
<airlied@linux.ie>
Cc: devicetree@vger.kernel.org, granquet@baylibre.com,
jitao.shi@mediatek.com, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, msp@baylibre.com,
Project_Global_Chrome_Upstream_Group@mediatek.com,
linux-mediatek@lists.infradead.org, wenst@chromium.org,
linux-arm-kernel@lists.infradead.org,
angelogioacchino.delregno@collabora.com
Subject: Re: [PATCH v12 13/14] drm/mediatek: dpi: Only enable dpi after the bridge is enabled
Date: Tue, 21 Jun 2022 14:02:30 +0800 [thread overview]
Message-ID: <0d35d7b6e0677b6eb1118c5a180229bfbdc77e7b.camel@mediatek.com> (raw)
In-Reply-To: <f8915cb4af91375dc9d7fc9c51f04863dd3e97dd.camel@mediatek.com>
On Tue, 2022-06-21 at 11:18 +0800, CK Hu wrote:
> Hi, Bo-Chen:
>
> On Mon, 2022-06-20 at 20:10 +0800, Bo-Chen Chen wrote:
> > From: Guillaume Ranquet <granquet@baylibre.com>
> >
> > Enabling the dpi too early causes glitches on screen.
> >
> > Move the call to mtk_dpi_enable() at the end of the bridge_enable
> > callback to ensure everything is setup properly before enabling
> > dpi.
> >
> > Fixes: f89c696e7f63 ("drm/mediatek: mtk_dpi: Convert to bridge
> > driver")
>
> I think this problem happen in the first patch [1].
>
> [1]
>
https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/commit/drivers/gpu/drm/mediatek/mtk_dpi.c?h=mediatek-drm-next&id=9e629c17aa8d7a75b8c1d99ed42892cd8ba7cdc4
>
> Regards,
> CK
>
ok, I will fix this.
BRs,
Bo-Chen
> > Signed-off-by: Guillaume Ranquet <granquet@baylibre.com>
> > Signed-off-by: Bo-Chen Chen <rex-bc.chen@mediatek.com>
> > ---
> > drivers/gpu/drm/mediatek/mtk_dpi.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c
> > b/drivers/gpu/drm/mediatek/mtk_dpi.c
> > index fc76ccad0a82..220e9b18e2cd 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
> > @@ -486,7 +486,6 @@ static int mtk_dpi_power_on(struct mtk_dpi
> > *dpi)
> > if (dpi->pinctrl && dpi->pins_dpi)
> > pinctrl_select_state(dpi->pinctrl, dpi->pins_dpi);
> >
> > - mtk_dpi_enable(dpi);
> > return 0;
> >
> > err_pixel:
> > @@ -731,6 +730,7 @@ static void mtk_dpi_bridge_enable(struct
> > drm_bridge *bridge)
> >
> > mtk_dpi_power_on(dpi);
> > mtk_dpi_set_display_mode(dpi, &dpi->mode);
> > + mtk_dpi_enable(dpi);
> > }
> >
> > static enum drm_mode_status
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Rex-BC Chen <rex-bc.chen@mediatek.com>
To: CK Hu <ck.hu@mediatek.com>, <chunkuang.hu@kernel.org>,
<p.zabel@pengutronix.de>, <daniel@ffwll.ch>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <matthias.bgg@gmail.com>,
<airlied@linux.ie>
Cc: <msp@baylibre.com>, <granquet@baylibre.com>,
<jitao.shi@mediatek.com>, <wenst@chromium.org>,
<angelogioacchino.delregno@collabora.com>,
<dri-devel@lists.freedesktop.org>,
<linux-mediatek@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<Project_Global_Chrome_Upstream_Group@mediatek.com>
Subject: Re: [PATCH v12 13/14] drm/mediatek: dpi: Only enable dpi after the bridge is enabled
Date: Tue, 21 Jun 2022 14:02:30 +0800 [thread overview]
Message-ID: <0d35d7b6e0677b6eb1118c5a180229bfbdc77e7b.camel@mediatek.com> (raw)
In-Reply-To: <f8915cb4af91375dc9d7fc9c51f04863dd3e97dd.camel@mediatek.com>
On Tue, 2022-06-21 at 11:18 +0800, CK Hu wrote:
> Hi, Bo-Chen:
>
> On Mon, 2022-06-20 at 20:10 +0800, Bo-Chen Chen wrote:
> > From: Guillaume Ranquet <granquet@baylibre.com>
> >
> > Enabling the dpi too early causes glitches on screen.
> >
> > Move the call to mtk_dpi_enable() at the end of the bridge_enable
> > callback to ensure everything is setup properly before enabling
> > dpi.
> >
> > Fixes: f89c696e7f63 ("drm/mediatek: mtk_dpi: Convert to bridge
> > driver")
>
> I think this problem happen in the first patch [1].
>
> [1]
>
https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/commit/drivers/gpu/drm/mediatek/mtk_dpi.c?h=mediatek-drm-next&id=9e629c17aa8d7a75b8c1d99ed42892cd8ba7cdc4
>
> Regards,
> CK
>
ok, I will fix this.
BRs,
Bo-Chen
> > Signed-off-by: Guillaume Ranquet <granquet@baylibre.com>
> > Signed-off-by: Bo-Chen Chen <rex-bc.chen@mediatek.com>
> > ---
> > drivers/gpu/drm/mediatek/mtk_dpi.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c
> > b/drivers/gpu/drm/mediatek/mtk_dpi.c
> > index fc76ccad0a82..220e9b18e2cd 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
> > @@ -486,7 +486,6 @@ static int mtk_dpi_power_on(struct mtk_dpi
> > *dpi)
> > if (dpi->pinctrl && dpi->pins_dpi)
> > pinctrl_select_state(dpi->pinctrl, dpi->pins_dpi);
> >
> > - mtk_dpi_enable(dpi);
> > return 0;
> >
> > err_pixel:
> > @@ -731,6 +730,7 @@ static void mtk_dpi_bridge_enable(struct
> > drm_bridge *bridge)
> >
> > mtk_dpi_power_on(dpi);
> > mtk_dpi_set_display_mode(dpi, &dpi->mode);
> > + mtk_dpi_enable(dpi);
> > }
> >
> > static enum drm_mode_status
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-21 6:02 UTC|newest]
Thread overview: 108+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-20 12:10 [PATCH v12 00/14] drm/mediatek: Add MT8195 dp_intf driver Bo-Chen Chen
2022-06-20 12:10 ` Bo-Chen Chen
2022-06-20 12:10 ` Bo-Chen Chen
2022-06-20 12:10 ` [PATCH v12 01/14] dt-bindings: mediatek,dpi: Add DP_INTF compatible Bo-Chen Chen
2022-06-20 12:10 ` Bo-Chen Chen
2022-06-20 12:10 ` Bo-Chen Chen
2022-06-20 12:25 ` Maxime Ripard
2022-06-20 12:25 ` Maxime Ripard
2022-06-20 12:25 ` Maxime Ripard
2022-06-20 12:33 ` Rex-BC Chen
2022-06-20 12:33 ` Rex-BC Chen
2022-06-20 12:33 ` Rex-BC Chen
2022-06-20 12:10 ` [PATCH v12 02/14] drm/mediatek: dpi: Add support for quantization range Bo-Chen Chen
2022-06-20 12:10 ` Bo-Chen Chen
2022-06-20 12:10 ` Bo-Chen Chen
2022-06-21 1:40 ` CK Hu
2022-06-21 1:40 ` CK Hu
2022-06-21 1:40 ` CK Hu
2022-06-20 12:10 ` [PATCH v12 03/14] drm/mediatek: dpi: implement a CK/DE pol toggle in SoC config Bo-Chen Chen
2022-06-20 12:10 ` Bo-Chen Chen
2022-06-20 12:10 ` Bo-Chen Chen
2022-06-20 12:10 ` [PATCH v12 04/14] drm/mediatek: dpi: implement a swap_input " Bo-Chen Chen
2022-06-20 12:10 ` Bo-Chen Chen
2022-06-20 12:10 ` Bo-Chen Chen
2022-06-21 1:44 ` CK Hu
2022-06-21 1:44 ` CK Hu
2022-06-21 1:44 ` CK Hu
2022-06-20 12:10 ` [PATCH v12 05/14] drm/mediatek: dpi: move dimension mask to " Bo-Chen Chen
2022-06-20 12:10 ` Bo-Chen Chen
2022-06-20 12:10 ` Bo-Chen Chen
2022-06-20 12:10 ` [PATCH v12 06/14] drm/mediatek: dpi: move hvsize_mask " Bo-Chen Chen
2022-06-20 12:10 ` Bo-Chen Chen
2022-06-20 12:10 ` Bo-Chen Chen
2022-06-20 12:10 ` [PATCH v12 07/14] drm/mediatek: dpi: move swap_shift " Bo-Chen Chen
2022-06-20 12:10 ` Bo-Chen Chen
2022-06-20 12:10 ` Bo-Chen Chen
2022-06-20 12:10 ` [PATCH v12 08/14] drm/mediatek: dpi: move the yuv422_en_bit " Bo-Chen Chen
2022-06-20 12:10 ` Bo-Chen Chen
2022-06-20 12:10 ` Bo-Chen Chen
2022-06-20 12:10 ` [PATCH v12 09/14] drm/mediatek: dpi: move the csc_enable bit " Bo-Chen Chen
2022-06-20 12:10 ` Bo-Chen Chen
2022-06-20 12:10 ` Bo-Chen Chen
2022-06-20 12:10 ` [PATCH v12 10/14] drm/mediatek: dpi: Add dpintf support Bo-Chen Chen
2022-06-20 12:10 ` Bo-Chen Chen
2022-06-20 12:10 ` Bo-Chen Chen
2022-06-21 2:32 ` CK Hu
2022-06-21 2:32 ` CK Hu
2022-06-21 2:32 ` CK Hu
2022-06-21 8:46 ` Rex-BC Chen
2022-06-21 8:46 ` Rex-BC Chen
2022-06-21 8:46 ` Rex-BC Chen
2022-06-20 12:10 ` [PATCH v12 11/14] drm/mediatek: dpi: Add tvd_clk enable/disable flow Bo-Chen Chen
2022-06-20 12:10 ` Bo-Chen Chen
2022-06-20 12:10 ` Bo-Chen Chen
2022-06-21 2:55 ` CK Hu
2022-06-21 2:55 ` CK Hu
2022-06-21 2:55 ` CK Hu
2022-06-21 3:11 ` Rex-BC Chen
2022-06-21 3:11 ` Rex-BC Chen
2022-06-21 3:11 ` Rex-BC Chen
2022-06-21 3:45 ` CK Hu
2022-06-21 3:45 ` CK Hu
2022-06-21 3:45 ` CK Hu
2022-06-21 3:50 ` Rex-BC Chen
2022-06-21 3:50 ` Rex-BC Chen
2022-06-21 3:50 ` Rex-BC Chen
2022-06-21 4:08 ` CK Hu
2022-06-21 4:08 ` CK Hu
2022-06-21 4:08 ` CK Hu
2022-06-21 5:47 ` Rex-BC Chen
2022-06-21 5:47 ` Rex-BC Chen
2022-06-21 5:47 ` Rex-BC Chen
2022-06-21 5:54 ` CK Hu
2022-06-21 5:54 ` CK Hu
2022-06-21 5:54 ` CK Hu
2022-06-21 5:59 ` Rex-BC Chen
2022-06-21 5:59 ` Rex-BC Chen
2022-06-21 5:59 ` Rex-BC Chen
2022-06-20 12:10 ` [PATCH v12 12/14] drm/mediatek: dpi: Add YUV422 output support Bo-Chen Chen
2022-06-20 12:10 ` Bo-Chen Chen
2022-06-20 12:10 ` Bo-Chen Chen
2022-06-21 3:04 ` CK Hu
2022-06-21 3:04 ` CK Hu
2022-06-21 3:04 ` CK Hu
2022-06-21 8:39 ` Rex-BC Chen
2022-06-21 8:39 ` Rex-BC Chen
2022-06-21 8:39 ` Rex-BC Chen
2022-06-20 12:10 ` [PATCH v12 13/14] drm/mediatek: dpi: Only enable dpi after the bridge is enabled Bo-Chen Chen
2022-06-20 12:10 ` Bo-Chen Chen
2022-06-20 12:10 ` Bo-Chen Chen
2022-06-21 3:18 ` CK Hu
2022-06-21 3:18 ` CK Hu
2022-06-21 3:18 ` CK Hu
2022-06-21 6:02 ` Rex-BC Chen [this message]
2022-06-21 6:02 ` Rex-BC Chen
2022-06-21 6:02 ` Rex-BC Chen
2022-06-20 12:10 ` [PATCH v12 14/14] drm/mediatek: dpi: Add matrix_sel helper Bo-Chen Chen
2022-06-20 12:10 ` Bo-Chen Chen
2022-06-20 12:10 ` Bo-Chen Chen
2022-06-21 3:33 ` CK Hu
2022-06-21 3:33 ` CK Hu
2022-06-21 3:33 ` CK Hu
2022-06-21 8:41 ` Rex-BC Chen
2022-06-21 8:41 ` Rex-BC Chen
2022-06-21 8:41 ` Rex-BC Chen
2022-06-21 9:12 ` CK Hu
2022-06-21 9:12 ` CK Hu
2022-06-21 9:12 ` CK Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d35d7b6e0677b6eb1118c5a180229bfbdc77e7b.camel@mediatek.com \
--to=rex-bc.chen@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=airlied@linux.ie \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunkuang.hu@kernel.org \
--cc=ck.hu@mediatek.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=granquet@baylibre.com \
--cc=jitao.shi@mediatek.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=msp@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.