All of lore.kernel.org
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert+renesas@glider.be>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
	David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Magnus Damm <magnus.damm@gmail.com>
Cc: dri-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Subject: [PATCH v3 21/41] drm: renesas: shmobile: Convert container helpers to static inline functions
Date: Wed, 16 Aug 2023 11:50:28 +0200	[thread overview]
Message-ID: <0d74fdda78f548f68c57739844a8fb0412368e15.1692178020.git.geert+renesas@glider.be> (raw)
In-Reply-To: <cover.1692178020.git.geert+renesas@glider.be>

Replace to conversion helper macros using container_of() by static
inline functions, to improve type-safety.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
v3:
  - No changes,

v2:
  - Add Reviewed-by.
---
 drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c  | 11 ++++++++---
 drivers/gpu/drm/renesas/shmobile/shmob_drm_plane.c |  5 ++++-
 2 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c b/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c
index 9c66e00ed70ea582..207fa98fe76d6f88 100644
--- a/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c
+++ b/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c
@@ -258,7 +258,10 @@ static void shmob_drm_crtc_update_base(struct shmob_drm_crtc *scrtc)
 	lcdc_write(sdev, LDRCNTR, lcdc_read(sdev, LDRCNTR) ^ LDRCNTR_MRS);
 }
 
-#define to_shmob_crtc(c)	container_of(c, struct shmob_drm_crtc, crtc)
+static inline struct shmob_drm_crtc *to_shmob_crtc(struct drm_crtc *crtc)
+{
+	return container_of(crtc, struct shmob_drm_crtc, crtc);
+}
 
 static void shmob_drm_crtc_dpms(struct drm_crtc *crtc, int mode)
 {
@@ -538,8 +541,10 @@ int shmob_drm_encoder_create(struct shmob_drm_device *sdev)
  * Connector
  */
 
-#define to_shmob_connector(c) \
-	container_of(c, struct shmob_drm_connector, connector)
+static inline struct shmob_drm_connector *to_shmob_connector(struct drm_connector *connector)
+{
+	return container_of(connector, struct shmob_drm_connector, connector);
+}
 
 static int shmob_drm_connector_get_modes(struct drm_connector *connector)
 {
diff --git a/drivers/gpu/drm/renesas/shmobile/shmob_drm_plane.c b/drivers/gpu/drm/renesas/shmobile/shmob_drm_plane.c
index 17e66a018689f648..258288c80756bf16 100644
--- a/drivers/gpu/drm/renesas/shmobile/shmob_drm_plane.c
+++ b/drivers/gpu/drm/renesas/shmobile/shmob_drm_plane.c
@@ -34,7 +34,10 @@ struct shmob_drm_plane {
 	unsigned int crtc_h;
 };
 
-#define to_shmob_plane(p)	container_of(p, struct shmob_drm_plane, plane)
+static inline struct shmob_drm_plane *to_shmob_plane(struct drm_plane *plane)
+{
+	return container_of(plane, struct shmob_drm_plane, plane);
+}
 
 static void shmob_drm_plane_compute_base(struct shmob_drm_plane *splane,
 					 struct drm_framebuffer *fb,
-- 
2.34.1


WARNING: multiple messages have this Message-ID (diff)
From: Geert Uytterhoeven <geert+renesas@glider.be>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
	David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Magnus Damm <magnus.damm@gmail.com>
Cc: linux-renesas-soc@vger.kernel.org,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: [PATCH v3 21/41] drm: renesas: shmobile: Convert container helpers to static inline functions
Date: Wed, 16 Aug 2023 11:50:28 +0200	[thread overview]
Message-ID: <0d74fdda78f548f68c57739844a8fb0412368e15.1692178020.git.geert+renesas@glider.be> (raw)
In-Reply-To: <cover.1692178020.git.geert+renesas@glider.be>

Replace to conversion helper macros using container_of() by static
inline functions, to improve type-safety.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
v3:
  - No changes,

v2:
  - Add Reviewed-by.
---
 drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c  | 11 ++++++++---
 drivers/gpu/drm/renesas/shmobile/shmob_drm_plane.c |  5 ++++-
 2 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c b/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c
index 9c66e00ed70ea582..207fa98fe76d6f88 100644
--- a/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c
+++ b/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c
@@ -258,7 +258,10 @@ static void shmob_drm_crtc_update_base(struct shmob_drm_crtc *scrtc)
 	lcdc_write(sdev, LDRCNTR, lcdc_read(sdev, LDRCNTR) ^ LDRCNTR_MRS);
 }
 
-#define to_shmob_crtc(c)	container_of(c, struct shmob_drm_crtc, crtc)
+static inline struct shmob_drm_crtc *to_shmob_crtc(struct drm_crtc *crtc)
+{
+	return container_of(crtc, struct shmob_drm_crtc, crtc);
+}
 
 static void shmob_drm_crtc_dpms(struct drm_crtc *crtc, int mode)
 {
@@ -538,8 +541,10 @@ int shmob_drm_encoder_create(struct shmob_drm_device *sdev)
  * Connector
  */
 
-#define to_shmob_connector(c) \
-	container_of(c, struct shmob_drm_connector, connector)
+static inline struct shmob_drm_connector *to_shmob_connector(struct drm_connector *connector)
+{
+	return container_of(connector, struct shmob_drm_connector, connector);
+}
 
 static int shmob_drm_connector_get_modes(struct drm_connector *connector)
 {
diff --git a/drivers/gpu/drm/renesas/shmobile/shmob_drm_plane.c b/drivers/gpu/drm/renesas/shmobile/shmob_drm_plane.c
index 17e66a018689f648..258288c80756bf16 100644
--- a/drivers/gpu/drm/renesas/shmobile/shmob_drm_plane.c
+++ b/drivers/gpu/drm/renesas/shmobile/shmob_drm_plane.c
@@ -34,7 +34,10 @@ struct shmob_drm_plane {
 	unsigned int crtc_h;
 };
 
-#define to_shmob_plane(p)	container_of(p, struct shmob_drm_plane, plane)
+static inline struct shmob_drm_plane *to_shmob_plane(struct drm_plane *plane)
+{
+	return container_of(plane, struct shmob_drm_plane, plane);
+}
 
 static void shmob_drm_plane_compute_base(struct shmob_drm_plane *splane,
 					 struct drm_framebuffer *fb,
-- 
2.34.1


  parent reply	other threads:[~2023-08-16 10:46 UTC|newest]

Thread overview: 84+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-16  9:50 [PATCH v3 00/41] drm: renesas: shmobile: Atomic conversion + DT support Geert Uytterhoeven
2023-08-16  9:50 ` Geert Uytterhoeven
2023-08-16  9:50 ` [PATCH v3 01/41] MAINTAINER: Create entry for Renesas SH-Mobile DRM drivers Geert Uytterhoeven
2023-08-16  9:50   ` Geert Uytterhoeven
2023-08-16  9:50 ` [PATCH v3 02/41] dt-bindings: display: Add Renesas SH-Mobile LCDC bindings Geert Uytterhoeven
2023-08-16  9:50   ` Geert Uytterhoeven
2023-08-16  9:50 ` [PATCH v3 03/41] media: uapi: Add MEDIA_BUS_FMT_RGB666_2X9_BE format Geert Uytterhoeven
2023-08-16  9:50   ` Geert Uytterhoeven
2023-08-16  9:50 ` [PATCH v3 04/41] drm: renesas: shmobile: Fix overlay plane disable Geert Uytterhoeven
2023-08-16  9:50   ` Geert Uytterhoeven
2023-08-16  9:50 ` [PATCH v3 05/41] drm: renesas: shmobile: Fix ARGB32 overlay format typo Geert Uytterhoeven
2023-08-16  9:50   ` Geert Uytterhoeven
2023-08-16  9:50 ` [PATCH v3 06/41] drm: renesas: shmobile: Correct encoder/connector types Geert Uytterhoeven
2023-08-16  9:50   ` Geert Uytterhoeven
2023-08-16  9:50 ` [PATCH v3 07/41] drm: renesas: shmobile: Add support for Runtime PM Geert Uytterhoeven
2023-08-16  9:50   ` Geert Uytterhoeven
2023-08-16  9:50 ` [PATCH v3 08/41] drm: renesas: shmobile: Restore indentation of shmob_drm_setup_clocks() Geert Uytterhoeven
2023-08-16  9:50   ` Geert Uytterhoeven
2023-08-16  9:50 ` [PATCH v3 09/41] drm: renesas: shmobile: Use %p4cc to print fourcc code Geert Uytterhoeven
2023-08-16  9:50   ` Geert Uytterhoeven
2023-08-16  9:50 ` [PATCH v3 10/41] drm: renesas: shmobile: Add missing YCbCr formats Geert Uytterhoeven
2023-08-16  9:50   ` Geert Uytterhoeven
2023-08-16  9:50 ` [PATCH v3 11/41] drm: renesas: shmobile: Improve shmob_drm_format_info table Geert Uytterhoeven
2023-08-16  9:50   ` Geert Uytterhoeven
2023-08-16  9:50 ` [PATCH v3 12/41] drm: renesas: shmobile: Remove backlight support Geert Uytterhoeven
2023-08-16  9:50   ` Geert Uytterhoeven
2023-08-16  9:50 ` [PATCH v3 13/41] drm: renesas: shmobile: Don't set display info width and height twice Geert Uytterhoeven
2023-08-16  9:50   ` Geert Uytterhoeven
2023-08-16  9:50 ` [PATCH v3 14/41] drm: renesas: shmobile: Rename input clocks Geert Uytterhoeven
2023-08-16  9:50   ` Geert Uytterhoeven
2023-08-16  9:50 ` [PATCH v3 15/41] drm: renesas: shmobile: Remove support for SYS panels Geert Uytterhoeven
2023-08-16  9:50   ` Geert Uytterhoeven
2023-08-16  9:50 ` [PATCH v3 16/41] drm: renesas: shmobile: Improve error handling Geert Uytterhoeven
2023-08-16  9:50   ` Geert Uytterhoeven
2023-08-16  9:50 ` [PATCH v3 17/41] drm: renesas: shmobile: Convert to use devm_request_irq() Geert Uytterhoeven
2023-08-16  9:50   ` Geert Uytterhoeven
2023-08-16  9:50 ` [PATCH v3 18/41] drm: renesas: shmobile: Remove custom plane destroy callback Geert Uytterhoeven
2023-08-16  9:50   ` Geert Uytterhoeven
2023-08-16  9:50 ` [PATCH v3 19/41] drm: renesas: shmobile: Use drmm_universal_plane_alloc() Geert Uytterhoeven
2023-08-16  9:50   ` Geert Uytterhoeven
2023-08-16  9:50 ` [PATCH v3 20/41] drm: renesas: shmobile: Embed drm_device in shmob_drm_device Geert Uytterhoeven
2023-08-16  9:50   ` Geert Uytterhoeven
2023-08-16  9:50 ` Geert Uytterhoeven [this message]
2023-08-16  9:50   ` [PATCH v3 21/41] drm: renesas: shmobile: Convert container helpers to static inline functions Geert Uytterhoeven
2023-08-16  9:50 ` [PATCH v3 22/41] drm: renesas: shmobile: Replace .dev_private with container_of() Geert Uytterhoeven
2023-08-16  9:50   ` Geert Uytterhoeven
2023-08-16  9:50 ` [PATCH v3 23/41] drm: renesas: shmobile: Use struct videomode in platform data Geert Uytterhoeven
2023-08-16  9:50   ` Geert Uytterhoeven
2023-08-16  9:50 ` [PATCH v3 24/41] drm: renesas: shmobile: Use media bus formats " Geert Uytterhoeven
2023-08-16  9:50   ` Geert Uytterhoeven
2023-08-16  9:50 ` [PATCH v3 25/41] drm: renesas: shmobile: Move interface handling to connector setup Geert Uytterhoeven
2023-08-16  9:50   ` Geert Uytterhoeven
2023-08-16  9:50 ` [PATCH v3 26/41] drm: renesas: shmobile: Unify plane allocation Geert Uytterhoeven
2023-08-16  9:50   ` Geert Uytterhoeven
2023-08-16  9:50 ` [PATCH v3 27/41] drm: renesas: shmobile: Rename shmob_drm_crtc.crtc Geert Uytterhoeven
2023-08-16  9:50   ` Geert Uytterhoeven
2023-08-16  9:50 ` [PATCH v3 28/41] drm: renesas: shmobile: Rename shmob_drm_connector.connector Geert Uytterhoeven
2023-08-16  9:50   ` Geert Uytterhoeven
2023-08-16  9:50 ` [PATCH v3 29/41] drm: renesas: shmobile: Rename shmob_drm_plane.plane Geert Uytterhoeven
2023-08-16  9:50   ` Geert Uytterhoeven
2023-08-16  9:50 ` [PATCH v3 30/41] drm: renesas: shmobile: Use drm_crtc_handle_vblank() Geert Uytterhoeven
2023-08-16  9:50   ` Geert Uytterhoeven
2023-08-16  9:50 ` [PATCH v3 31/41] drm: renesas: shmobile: Move shmob_drm_crtc_finish_page_flip() Geert Uytterhoeven
2023-08-16  9:50   ` Geert Uytterhoeven
2023-08-16  9:50 ` [PATCH v3 32/41] drm: renesas: shmobile: Wait for page flip when turning CRTC off Geert Uytterhoeven
2023-08-16  9:50   ` Geert Uytterhoeven
2023-08-16  9:50 ` [PATCH v3 33/41] drm: renesas: shmobile: Turn vblank on/off when enabling/disabling CRTC Geert Uytterhoeven
2023-08-16  9:50   ` Geert Uytterhoeven
2023-08-16  9:50 ` [PATCH v3 34/41] drm: renesas: shmobile: Shutdown the display on remove Geert Uytterhoeven
2023-08-16  9:50   ` Geert Uytterhoeven
2023-08-16  9:50 ` [PATCH v3 35/41] drm: renesas: shmobile: Cleanup encoder Geert Uytterhoeven
2023-08-16  9:50   ` Geert Uytterhoeven
2023-08-16  9:50 ` [PATCH v3 36/41] drm: renesas: shmobile: Atomic conversion part 1 Geert Uytterhoeven
2023-08-16  9:50   ` Geert Uytterhoeven
2023-08-16  9:50 ` [PATCH v3 37/41] drm: renesas: shmobile: Atomic conversion part 2 Geert Uytterhoeven
2023-08-16  9:50   ` Geert Uytterhoeven
2023-08-16  9:50 ` [PATCH v3 38/41] drm: renesas: shmobile: Use suspend/resume helpers Geert Uytterhoeven
2023-08-16  9:50   ` Geert Uytterhoeven
2023-08-16  9:50 ` [PATCH v3 39/41] drm: renesas: shmobile: Remove internal CRTC state tracking Geert Uytterhoeven
2023-08-16  9:50   ` Geert Uytterhoeven
2023-08-16  9:50 ` [PATCH v3 40/41] drm: renesas: shmobile: Atomic conversion part 3 Geert Uytterhoeven
2023-08-16  9:50   ` Geert Uytterhoeven
2023-08-16  9:50 ` [PATCH v3 41/41] drm: renesas: shmobile: Add DT support Geert Uytterhoeven
2023-08-16  9:50   ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0d74fdda78f548f68c57739844a8fb0412368e15.1692178020.git.geert+renesas@glider.be \
    --to=geert+renesas@glider.be \
    --cc=airlied@gmail.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kieran.bingham+renesas@ideasonboard.com \
    --cc=laurent.pinchart+renesas@ideasonboard.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.