From: Lars-Peter Clausen <lars@metafoo.de>
To: Shawn Lin <shawn.lin@rock-chips.com>, Vinod Koul <vinod.koul@intel.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Huibin Hong <huibin.hong@rock-chips.com>,
Xing Zheng <zhengxing@rock-chips.com>,
devicetree@vger.kernel.org, dianders@chromium.org,
briannorris@chromium.org, Caesar Wang <wxt@rock-chips.com>,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH 1/3] dt/bindings: arm-pl330: add description of arm,pl330-periph-burst
Date: Tue, 9 Aug 2016 10:39:43 +0200 [thread overview]
Message-ID: <0df0ab4f-0032-6487-2c30-b1ccd7d9ae62@metafoo.de> (raw)
In-Reply-To: <ea3572fa-4bff-87db-d5ad-f406809f8296@rock-chips.com>
On 08/05/2016 09:25 AM, Shawn Lin wrote:
> Hi Vinod,
>
> 在 2016/8/5 11:34, Vinod Koul 写道:
>> On Fri, Aug 05, 2016 at 10:53:20AM +0800, Shawn Lin wrote:
>>> This patch adds the "arm,pl330-periph-burst" for arm-pl330 to
>>> support busrt mode.
>>
>> why should this be DT property. Only reason I can think of if some hw
>> versions support this and some won't.
>
> yes, if we want to support burst mode, both of the master(pl330) and
> client(several peripherals) should implement it, otherwise it will
> be broken when enabling.
As you said, it is up to the consumer peripheral whether it supports BURST,
SINGLE or both. So this is a per client property, but you specify this as a
a global property on the producer side.
WARNING: multiple messages have this Message-ID (diff)
From: Lars-Peter Clausen <lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
To: Shawn Lin <shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
Vinod Koul <vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Huibin Hong <huibin.hong-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
Xing Zheng <zhengxing-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
Caesar Wang <wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 1/3] dt/bindings: arm-pl330: add description of arm,pl330-periph-burst
Date: Tue, 9 Aug 2016 10:39:43 +0200 [thread overview]
Message-ID: <0df0ab4f-0032-6487-2c30-b1ccd7d9ae62@metafoo.de> (raw)
In-Reply-To: <ea3572fa-4bff-87db-d5ad-f406809f8296-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
On 08/05/2016 09:25 AM, Shawn Lin wrote:
> Hi Vinod,
>
> 在 2016/8/5 11:34, Vinod Koul 写道:
>> On Fri, Aug 05, 2016 at 10:53:20AM +0800, Shawn Lin wrote:
>>> This patch adds the "arm,pl330-periph-burst" for arm-pl330 to
>>> support busrt mode.
>>
>> why should this be DT property. Only reason I can think of if some hw
>> versions support this and some won't.
>
> yes, if we want to support burst mode, both of the master(pl330) and
> client(several peripherals) should implement it, otherwise it will
> be broken when enabling.
As you said, it is up to the consumer peripheral whether it supports BURST,
SINGLE or both. So this is a per client property, but you specify this as a
a global property on the producer side.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: lars@metafoo.de (Lars-Peter Clausen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] dt/bindings: arm-pl330: add description of arm,pl330-periph-burst
Date: Tue, 9 Aug 2016 10:39:43 +0200 [thread overview]
Message-ID: <0df0ab4f-0032-6487-2c30-b1ccd7d9ae62@metafoo.de> (raw)
In-Reply-To: <ea3572fa-4bff-87db-d5ad-f406809f8296@rock-chips.com>
On 08/05/2016 09:25 AM, Shawn Lin wrote:
> Hi Vinod,
>
> ? 2016/8/5 11:34, Vinod Koul ??:
>> On Fri, Aug 05, 2016 at 10:53:20AM +0800, Shawn Lin wrote:
>>> This patch adds the "arm,pl330-periph-burst" for arm-pl330 to
>>> support busrt mode.
>>
>> why should this be DT property. Only reason I can think of if some hw
>> versions support this and some won't.
>
> yes, if we want to support burst mode, both of the master(pl330) and
> client(several peripherals) should implement it, otherwise it will
> be broken when enabling.
As you said, it is up to the consumer peripheral whether it supports BURST,
SINGLE or both. So this is a per client property, but you specify this as a
a global property on the producer side.
next prev parent reply other threads:[~2016-08-09 8:40 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-05 2:53 [PATCH 0/3] Support burst request by peripherals Shawn Lin
2016-08-05 2:53 ` Shawn Lin
2016-08-05 2:53 ` Shawn Lin
2016-08-05 2:53 ` [PATCH 1/3] dt/bindings: arm-pl330: add description of arm,pl330-periph-burst Shawn Lin
2016-08-05 2:53 ` [PATCH 1/3] dt/bindings: arm-pl330: add description of arm, pl330-periph-burst Shawn Lin
2016-08-05 2:53 ` [PATCH 1/3] dt/bindings: arm-pl330: add description of arm,pl330-periph-burst Shawn Lin
2016-08-05 3:34 ` Vinod Koul
2016-08-05 3:34 ` Vinod Koul
2016-08-05 7:25 ` Shawn Lin
2016-08-05 7:25 ` Shawn Lin
2016-08-09 8:39 ` Lars-Peter Clausen [this message]
2016-08-09 8:39 ` Lars-Peter Clausen
2016-08-09 8:39 ` Lars-Peter Clausen
2016-08-09 9:12 ` Shawn Lin
2016-08-09 9:12 ` Shawn Lin
2016-08-17 8:11 ` Shawn Lin
2016-08-17 8:11 ` Shawn Lin
2016-08-17 8:11 ` Shawn Lin
2016-08-19 2:45 ` Vinod Koul
2016-08-19 2:45 ` Vinod Koul
2016-08-21 1:00 ` Shawn Lin
2016-08-21 1:00 ` Shawn Lin
2016-08-21 1:00 ` Shawn Lin
2016-08-22 6:04 ` Vinod Koul
2016-08-22 6:04 ` Vinod Koul
2016-08-22 6:04 ` Vinod Koul
2016-08-05 2:53 ` [PATCH 2/3] dmaengine: pl330: enable burst mode by parsing dt Shawn Lin
2016-08-05 2:53 ` Shawn Lin
2016-08-05 2:53 ` Shawn Lin
2016-08-07 9:20 ` Xing Zheng
2016-08-07 9:20 ` Xing Zheng
2016-08-05 2:53 ` [PATCH 3/3] dmaengine: pl330: support transfer unaligned with (burst len * burst size) Shawn Lin
2016-08-05 2:53 ` Shawn Lin
2016-08-05 2:53 ` Shawn Lin
2016-08-07 9:21 ` Xing Zheng
2016-08-07 9:21 ` Xing Zheng
2016-08-07 9:21 ` Xing Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0df0ab4f-0032-6487-2c30-b1ccd7d9ae62@metafoo.de \
--to=lars@metafoo.de \
--cc=briannorris@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dmaengine@vger.kernel.org \
--cc=huibin.hong@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=shawn.lin@rock-chips.com \
--cc=vinod.koul@intel.com \
--cc=wxt@rock-chips.com \
--cc=zhengxing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.