From: Sagi Grimberg <sagi@grimberg.me>
To: Max Gurtovoy <mgurtovoy@nvidia.com>, Kamal Heib <kheib@redhat.com>
Cc: israelr@nvidia.com, alaa@nvidia.com, linux-rdma@vger.kernel.org,
jgg@nvidia.com
Subject: Re: [PATCH 1/1] IB/isert: align target max I/O size to initiator size
Date: Tue, 8 Jun 2021 16:04:51 -0700 [thread overview]
Message-ID: <0e4f17d0-5237-e9ae-44a0-4891a53bb26a@grimberg.me> (raw)
In-Reply-To: <e6623d9e-0122-ea0c-e148-f739bd15b0bb@nvidia.com>
>> On 5/25/21 7:22 PM, Max Gurtovoy wrote:
>>> On 5/25/2021 6:54 PM, Sagi Grimberg wrote:
>>>>> Since the Linux iser initiator default max I/O size set to 512KB and
>>>>> since there is no handshake procedure for this size in iser protocol,
>>>>> set the default max IO size of the target to 512KB as well.
>>>>>
>>>>> For changing the default values, there is a module parameter for both
>>>>> drivers.
>>>> Is this solving a bug?
>>> No. Only OOB for some old connect-IB devices.
>>>
>>> I think it's reasonable to align initiator and target defaults anyway.
>>>
>>>
>> Actually, this patch is solving a bug when trying iser over
>> Connect-IB, We see
>> the following failure when trying to do discovery:
>
> You can work around this using the ib_isert sg_tablesize module param
> and set it to 128.
>
> So it's more OOB behavior than a bug.
>
> Anyway, This is good practice to be able to establish connections also
> for old devices without WAs and we also aligning to the sg_table size in
> the initiator side.
>
> Jason/Sagi,
>
> can you comment on this patch for 5.14 ?
Actually, if this is the case, why not have a fallback when creating the
QP? Seems more reasonable to have the exception for the old devices
rather than having those mandate the common denominator no?
next prev parent reply other threads:[~2021-06-08 23:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-24 8:52 [PATCH 1/1] IB/isert: align target max I/O size to initiator size Max Gurtovoy
2021-05-25 15:54 ` Sagi Grimberg
2021-05-25 16:22 ` Max Gurtovoy
2021-06-08 10:24 ` Kamal Heib
2021-06-08 11:00 ` Max Gurtovoy
2021-06-08 23:04 ` Sagi Grimberg [this message]
2021-06-09 8:45 ` Max Gurtovoy
2021-06-20 8:11 ` Kamal Heib
2021-06-20 11:29 ` Max Gurtovoy
2021-06-22 8:56 ` Sagi Grimberg
2021-06-22 12:31 ` Max Gurtovoy
2021-06-23 21:39 ` Sagi Grimberg
2021-06-24 12:29 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e4f17d0-5237-e9ae-44a0-4891a53bb26a@grimberg.me \
--to=sagi@grimberg.me \
--cc=alaa@nvidia.com \
--cc=israelr@nvidia.com \
--cc=jgg@nvidia.com \
--cc=kheib@redhat.com \
--cc=linux-rdma@vger.kernel.org \
--cc=mgurtovoy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.