From: Sagi Grimberg <sagi@grimberg.me>
To: Max Gurtovoy <mgurtovoy@nvidia.com>, Kamal Heib <kheib@redhat.com>
Cc: israelr@nvidia.com, alaa@nvidia.com, linux-rdma@vger.kernel.org,
jgg@nvidia.com
Subject: Re: [PATCH 1/1] IB/isert: align target max I/O size to initiator size
Date: Tue, 22 Jun 2021 01:56:10 -0700 [thread overview]
Message-ID: <d6e2f70a-1885-9cc3-f82c-0c0abeca2c7d@grimberg.me> (raw)
In-Reply-To: <90153fcc-8ed5-6ad5-0539-bcf97d8e0ce3@nvidia.com>
>> Well, from the distro's point of view this code is not going to be
>> dead any time
>> soon..., And the current user experience is very bad, Could you guys
>> please
>> decide on a way to fix this issue?
>
> As mention above, I prefer the simple solution for this issue.
>
> I guess the most of iSER users are using pretty old HW so defaults
> should be accordingly.
>
> For NVMe/RDMA this is a different story and we can use higher defaults
>
> Adding fallbacks will complicate the code without a real justification
> for doing it.
Usually when you end up changing the defaults multiple times it should
be an indication that it should do something about it.
But hey, if you are killing Connect-IB anyways, and you don't see any
sort of regressions from this I don't really have a problem with it.
next prev parent reply other threads:[~2021-06-22 8:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-24 8:52 [PATCH 1/1] IB/isert: align target max I/O size to initiator size Max Gurtovoy
2021-05-25 15:54 ` Sagi Grimberg
2021-05-25 16:22 ` Max Gurtovoy
2021-06-08 10:24 ` Kamal Heib
2021-06-08 11:00 ` Max Gurtovoy
2021-06-08 23:04 ` Sagi Grimberg
2021-06-09 8:45 ` Max Gurtovoy
2021-06-20 8:11 ` Kamal Heib
2021-06-20 11:29 ` Max Gurtovoy
2021-06-22 8:56 ` Sagi Grimberg [this message]
2021-06-22 12:31 ` Max Gurtovoy
2021-06-23 21:39 ` Sagi Grimberg
2021-06-24 12:29 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6e2f70a-1885-9cc3-f82c-0c0abeca2c7d@grimberg.me \
--to=sagi@grimberg.me \
--cc=alaa@nvidia.com \
--cc=israelr@nvidia.com \
--cc=jgg@nvidia.com \
--cc=kheib@redhat.com \
--cc=linux-rdma@vger.kernel.org \
--cc=mgurtovoy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.