From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Chanho Park <chanho61.park@samsung.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Tomasz Figa <tomasz.figa@gmail.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Alim Akhtar <alim.akhtar@samsung.com>,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] dt-bindings: clock: exynosautov9: correct clock numbering of peric0/c1
Date: Mon, 27 Jun 2022 13:33:16 +0200 [thread overview]
Message-ID: <0e9aab63-7ddf-dead-11b2-4ba81235dcb4@linaro.org> (raw)
In-Reply-To: <20220627005210.6473-2-chanho61.park@samsung.com>
On 27/06/2022 02:52, Chanho Park wrote:
> There are duplicated definitions of peric0 and peric1 cmu blocks. Thus,
> they should be defined correctly as numerical order.
>
> Fixes: 680e1c8370a2 ("dt-bindings: clock: add clock binding definitions for Exynos Auto v9")
> Signed-off-by: Chanho Park <chanho61.park@samsung.com>
> ---
> .../dt-bindings/clock/samsung,exynosautov9.h | 56 +++++++++----------
> 1 file changed, 28 insertions(+), 28 deletions(-)
>
> diff --git a/include/dt-bindings/clock/samsung,exynosautov9.h b/include/dt-bindings/clock/samsung,exynosautov9.h
> index ea9f91b4eb1a..a7db6516593f 100644
> --- a/include/dt-bindings/clock/samsung,exynosautov9.h
> +++ b/include/dt-bindings/clock/samsung,exynosautov9.h
> @@ -226,21 +226,21 @@
> #define CLK_GOUT_PERIC0_IPCLK_8 28
> #define CLK_GOUT_PERIC0_IPCLK_9 29
> #define CLK_GOUT_PERIC0_IPCLK_10 30
> -#define CLK_GOUT_PERIC0_IPCLK_11 30
> -#define CLK_GOUT_PERIC0_PCLK_0 31
> -#define CLK_GOUT_PERIC0_PCLK_1 32
> -#define CLK_GOUT_PERIC0_PCLK_2 33
> -#define CLK_GOUT_PERIC0_PCLK_3 34
> -#define CLK_GOUT_PERIC0_PCLK_4 35
> -#define CLK_GOUT_PERIC0_PCLK_5 36
> -#define CLK_GOUT_PERIC0_PCLK_6 37
> -#define CLK_GOUT_PERIC0_PCLK_7 38
> -#define CLK_GOUT_PERIC0_PCLK_8 39
> -#define CLK_GOUT_PERIC0_PCLK_9 40
> -#define CLK_GOUT_PERIC0_PCLK_10 41
> -#define CLK_GOUT_PERIC0_PCLK_11 42
> +#define CLK_GOUT_PERIC0_IPCLK_11 31
> +#define CLK_GOUT_PERIC0_PCLK_0 32
> +#define CLK_GOUT_PERIC0_PCLK_1 33
Is this a fix for current cycle? If yes, it's ok, otherwise all other
IDs should not be changed, because it's part of ABI.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Chanho Park <chanho61.park@samsung.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Tomasz Figa <tomasz.figa@gmail.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Alim Akhtar <alim.akhtar@samsung.com>,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] dt-bindings: clock: exynosautov9: correct clock numbering of peric0/c1
Date: Mon, 27 Jun 2022 13:33:16 +0200 [thread overview]
Message-ID: <0e9aab63-7ddf-dead-11b2-4ba81235dcb4@linaro.org> (raw)
In-Reply-To: <20220627005210.6473-2-chanho61.park@samsung.com>
On 27/06/2022 02:52, Chanho Park wrote:
> There are duplicated definitions of peric0 and peric1 cmu blocks. Thus,
> they should be defined correctly as numerical order.
>
> Fixes: 680e1c8370a2 ("dt-bindings: clock: add clock binding definitions for Exynos Auto v9")
> Signed-off-by: Chanho Park <chanho61.park@samsung.com>
> ---
> .../dt-bindings/clock/samsung,exynosautov9.h | 56 +++++++++----------
> 1 file changed, 28 insertions(+), 28 deletions(-)
>
> diff --git a/include/dt-bindings/clock/samsung,exynosautov9.h b/include/dt-bindings/clock/samsung,exynosautov9.h
> index ea9f91b4eb1a..a7db6516593f 100644
> --- a/include/dt-bindings/clock/samsung,exynosautov9.h
> +++ b/include/dt-bindings/clock/samsung,exynosautov9.h
> @@ -226,21 +226,21 @@
> #define CLK_GOUT_PERIC0_IPCLK_8 28
> #define CLK_GOUT_PERIC0_IPCLK_9 29
> #define CLK_GOUT_PERIC0_IPCLK_10 30
> -#define CLK_GOUT_PERIC0_IPCLK_11 30
> -#define CLK_GOUT_PERIC0_PCLK_0 31
> -#define CLK_GOUT_PERIC0_PCLK_1 32
> -#define CLK_GOUT_PERIC0_PCLK_2 33
> -#define CLK_GOUT_PERIC0_PCLK_3 34
> -#define CLK_GOUT_PERIC0_PCLK_4 35
> -#define CLK_GOUT_PERIC0_PCLK_5 36
> -#define CLK_GOUT_PERIC0_PCLK_6 37
> -#define CLK_GOUT_PERIC0_PCLK_7 38
> -#define CLK_GOUT_PERIC0_PCLK_8 39
> -#define CLK_GOUT_PERIC0_PCLK_9 40
> -#define CLK_GOUT_PERIC0_PCLK_10 41
> -#define CLK_GOUT_PERIC0_PCLK_11 42
> +#define CLK_GOUT_PERIC0_IPCLK_11 31
> +#define CLK_GOUT_PERIC0_PCLK_0 32
> +#define CLK_GOUT_PERIC0_PCLK_1 33
Is this a fix for current cycle? If yes, it's ok, otherwise all other
IDs should not be changed, because it's part of ABI.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-06-27 11:34 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220627005413epcas2p3b3a22da2bf40b77b942cb2c6427135d5@epcas2p3.samsung.com>
2022-06-27 0:52 ` [PATCH 0/3] fixes for exynosautov9 clock Chanho Park
2022-06-27 0:52 ` Chanho Park
[not found] ` <CGME20220627005413epcas2p39750fb5876366881b8535ee516c1bebe@epcas2p3.samsung.com>
2022-06-27 0:52 ` [PATCH 1/3] dt-bindings: clock: exynosautov9: correct clock numbering of peric0/c1 Chanho Park
2022-06-27 0:52 ` Chanho Park
2022-06-27 11:33 ` Krzysztof Kozlowski [this message]
2022-06-27 11:33 ` Krzysztof Kozlowski
2022-06-28 2:15 ` Chanho Park
2022-06-28 2:15 ` Chanho Park
2022-06-28 10:02 ` Krzysztof Kozlowski
2022-06-28 10:02 ` Krzysztof Kozlowski
2022-07-04 7:32 ` Chanho Park
2022-07-04 7:32 ` Chanho Park
[not found] ` <CGME20220627005413epcas2p37d6b3cbea055cecade47ad304b40b7e3@epcas2p3.samsung.com>
2022-06-27 0:52 ` [PATCH 2/3] clk: samsung: exynosautov9: add missing gate clks for peric0/c1 Chanho Park
2022-06-27 0:52 ` Chanho Park
2022-06-27 11:30 ` Krzysztof Kozlowski
2022-06-27 11:30 ` Krzysztof Kozlowski
2022-06-28 2:10 ` Chanho Park
2022-06-28 2:10 ` Chanho Park
2022-06-28 6:58 ` Krzysztof Kozlowski
2022-06-28 6:58 ` Krzysztof Kozlowski
[not found] ` <CGME20220627005413epcas2p452229025b91f81ac86a4ddd403c64765@epcas2p4.samsung.com>
2022-06-27 0:52 ` [PATCH 3/3] clk: samsung: exynosautov9: correct register offsets of peric0/c1 Chanho Park
2022-06-27 0:52 ` Chanho Park
2022-06-27 11:31 ` Krzysztof Kozlowski
2022-06-27 11:31 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e9aab63-7ddf-dead-11b2-4ba81235dcb4@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=chanho61.park@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@kernel.org \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.