Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 8/8] gputop: Basic vendor agnostic GPU top tool

From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: "Kamil Konieczny" <kamil.konieczny@linux.intel.com>,
	igt-dev@lists.freedesktop.org, Intel-gfx@lists.freedesktop.org,
	"Rob Clark" <robdclark@chromium.org>,
	"Christian König" <ckoenig.leichtzumerken@gmail.com>,
	"Christian König" <christian.koenig@amd.com>,
	"Tvrtko Ursulin" <tvrtko.ursulin@intel.com>
Subject: Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 8/8] gputop: Basic vendor agnostic GPU top tool
Date: Mon, 6 Feb 2023 09:19:02 +0000	[thread overview]
Message-ID: <0edf920f-0ba8-2aa7-6b52-07facb400b3f@linux.intel.com> (raw)
In-Reply-To: <20230203164224.6y3qx4yztt7hd5cu@kamilkon-desk1>

On 03/02/2023 16:42, Kamil Konieczny wrote:
> Hi Tvrtko,
> 
> On 2023-01-31 at 11:32:37 +0000, Tvrtko Ursulin wrote:
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> Rudimentary vendor agnostic example of how lib_igt_drm_clients can be used
>> to display a sorted by card and usage list of processes using GPUs.
>>
>> Borrows a bit of code from intel_gpu_top but for now omits the fancy
>> features like interactive functionality, card selection, client
>> aggregation, sort modes, JSON output  and pretty engine names. Also no
>> support for global GPU or system metrics.
>>
>> On the other hand it shows clients from all DRM cards which
>> intel_gpu_top does not do.
>>
>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>> Cc: Rob Clark <robdclark@chromium.org>
>> Cc: Christian König <ckoenig.leichtzumerken@gmail.com>
>> Acked-by: Christian König <christian.koenig@amd.com>
> 
> I run it with:
> # ./gputop
> 
> but it do not work on my Skylake card, I see no output,
> kernel 5.19.0-29-generic, ubuntu 22.10

Odd, 5.19 should have the support. Intel_gpu_top works - it is showing 
the individual clients?

> 
> # ./lsgpu
> card0                    Intel Skylake (Gen9)              drm:/dev/dri/card0
> └─renderD128                                               drm:/dev/dri/renderD128
> 
> Please add some options like debug, version, debug with high
> verbose level, help. It seems like q or Q do not exit.

As the cover letter hints I was only set out to demonstrate an extremely 
rudimentary vendor agnostic tool. To quote the cover letter more - "..It 
also makes no effort to provide sorting modes, well any interactivity, 
or any pretty names for GPUs or engines..". I have no scope presently to 
make it better or nicer.

The tool however can serve as a starting point and people had reported 
it working as-is with a few other drivers, AMD, msm and most recently I 
believe etnaviv. So perhaps a pool of people to further improve it will 
be found there in the future.

In summary I think it's worth reviewing so that the common code gets 
extracted from intel_gpu_top into respective libraries. After that I was 
hoping other people start contributing further improvements.

Regards,

Tvrtko