From: James Morse <james.morse@arm.com>
To: Gavin Shan <gshan@redhat.com>
Cc: mark.rutland@arm.com, catalin.marinas@arm.com, will@kernel.org,
shan.gavin@gmail.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 01/14] drivers/firmware/sdei: Remove sdei_is_err()
Date: Tue, 21 Jul 2020 21:39:21 +0100 [thread overview]
Message-ID: <0fb13e3b-a3f6-f76b-be74-ebf1873c023c@arm.com> (raw)
In-Reply-To: <20200706054732.99387-2-gshan@redhat.com>
Hi Gavin,
On 06/07/2020 06:47, Gavin Shan wrote:
> sdei_is_err() is only called by sdei_to_linux_errno().
... so it is! There were a lot more of these out of tree when it was being used to test
the firmware.
> The logic of
> checking on the error number is common to them. They can be combined
> finely.
> This removes sdei_is_err() and its logic is combined to the function
> sdei_to_linux_errno().
> diff --git a/drivers/firmware/arm_sdei.c b/drivers/firmware/arm_sdei.c
> index e7e36aab2386..415c243a8e65 100644
> --- a/drivers/firmware/arm_sdei.c
> +++ b/drivers/firmware/arm_sdei.c
> @@ -114,26 +114,7 @@ static int sdei_to_linux_errno(unsigned long sdei_err)
> return -ENOMEM;
> }
>
> - /* Not an error value ... */
> - return sdei_err;
> -}
> -
> -/*
> - * If x0 is any of these values, then the call failed, use sdei_to_linux_errno()
> - * to translate.
> - */
> -static int sdei_is_err(struct arm_smccc_res *res)
> -{
> - switch (res->a0) {
> - case SDEI_NOT_SUPPORTED:
> - case SDEI_INVALID_PARAMETERS:
> - case SDEI_DENIED:
> - case SDEI_PENDING:
> - case SDEI_OUT_OF_RESOURCE:
> - return true;
> - }
> -
> - return false;
> + return 0;
> }
>
> static int invoke_sdei_fn(unsigned long function_id, unsigned long arg0,
> @@ -147,8 +128,7 @@ static int invoke_sdei_fn(unsigned long function_id, unsigned long arg0,
Please also remove the now-pointless initialiser at the top of the function.
> if (sdei_firmware_call) {
> sdei_firmware_call(function_id, arg0, arg1, arg2, arg3, arg4,
> &res);
> - if (sdei_is_err(&res))
> - err = sdei_to_linux_errno(res.a0);
> + err = sdei_to_linux_errno(res.a0);> } else {
> /*
> * !sdei_firmware_call means we failed to probe or called
>
With that:
Reviewed-by: James Morse <james.morse@arm.com>
Thanks,
James
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-21 20:41 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-06 5:47 [PATCH 00/14] Refactor SDEI client driver Gavin Shan
2020-07-06 5:47 ` [PATCH 01/14] drivers/firmware/sdei: Remove sdei_is_err() Gavin Shan
2020-07-21 20:39 ` James Morse [this message]
2020-07-22 2:04 ` Gavin Shan
2020-07-06 5:47 ` [PATCH 02/14] drivers/firmware/sdei: Common block for failing path in sdei_event_create() Gavin Shan
2020-07-21 20:40 ` James Morse
2020-07-22 2:12 ` Gavin Shan
2020-07-06 5:47 ` [PATCH 03/14] drivers/firmware/sdei: Dereference SDEI event parameter directly Gavin Shan
2020-07-21 20:41 ` James Morse
2020-07-22 2:38 ` Gavin Shan
2020-07-06 5:47 ` [PATCH 04/14] drivers/firmware/sdei: Rework sdei_init() Gavin Shan
2020-07-21 20:42 ` James Morse
2020-07-22 3:34 ` Gavin Shan
2020-07-06 5:47 ` [PATCH 05/14] drivers/firmware/sdei: Remove sdei_get_conduit() Gavin Shan
2020-07-21 20:42 ` James Morse
2020-07-22 3:50 ` Gavin Shan
2020-07-06 5:47 ` [PATCH 06/14] drivers/firmware/sdei: Drop redundant error message in sdei_probe() Gavin Shan
2020-07-06 5:47 ` [PATCH 07/14] drivers/firmware/sdei: Drop unnecessary while loop Gavin Shan
2020-07-06 5:47 ` [PATCH 08/14] drivers/firmware/sdei: Cleanup on cross call functions Gavin Shan
2020-07-06 5:47 ` [PATCH 09/14] drivers/firmware/sdei: Introduce sdei_do_local_call() Gavin Shan
2020-07-06 5:47 ` [PATCH 10/14] drivers/firmware/sdei: Remove _sdei_event_register() Gavin Shan
2020-07-06 5:47 ` [PATCH 11/14] drivers/firmware/sdei: Remove _sdei_event_unregister() Gavin Shan
2020-07-06 5:47 ` [PATCH 12/14] drivers/firmware/sdei: Identify event by struct sdei_event Gavin Shan
2020-07-06 5:47 ` [PATCH 13/14] drivers/firmware/sdei: Retrieve event signaled property on creation Gavin Shan
2020-07-06 5:47 ` [PATCH 14/14] drivers/firmware/sdei: Add sdei_event_get_info() Gavin Shan
2020-07-21 9:44 ` [PATCH 00/14] Refactor SDEI client driver Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0fb13e3b-a3f6-f76b-be74-ebf1873c023c@arm.com \
--to=james.morse@arm.com \
--cc=catalin.marinas@arm.com \
--cc=gshan@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=shan.gavin@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.