From: Gavin Shan <gshan@redhat.com>
To: linux-arm-kernel@lists.infradead.org
Cc: mark.rutland@arm.com, will@kernel.org, james.morse@arm.com,
shan.gavin@gmail.com, catalin.marinas@arm.com
Subject: [PATCH 03/14] drivers/firmware/sdei: Dereference SDEI event parameter directly
Date: Mon, 6 Jul 2020 15:47:21 +1000 [thread overview]
Message-ID: <20200706054732.99387-4-gshan@redhat.com> (raw)
In-Reply-To: <20200706054732.99387-1-gshan@redhat.com>
The SDEI parameter is dereferenced by @sdei_event->registered or
@sdei_event->private_registered, depending on the event type. They
can be dereferenced directly so that the intermediate variable
(@regs) can be removed. It makes the code looks a bit simplified.
Also, @event->event_num instead of @event_num is used for retrieving
the event number for the shared event, which makes the code similar
to the case of private event. Besides, the local scoped variables
are reordered according to their importance by the way.
Signed-off-by: Gavin Shan <gshan@redhat.com>
---
drivers/firmware/arm_sdei.c | 25 +++++++++++--------------
1 file changed, 11 insertions(+), 14 deletions(-)
diff --git a/drivers/firmware/arm_sdei.c b/drivers/firmware/arm_sdei.c
index a75212a743d3..35a319e7e1e6 100644
--- a/drivers/firmware/arm_sdei.c
+++ b/drivers/firmware/arm_sdei.c
@@ -211,38 +211,35 @@ static struct sdei_event *sdei_event_create(u32 event_num,
event->type = result;
if (event->type == SDEI_EVENT_TYPE_SHARED) {
- reg = kzalloc(sizeof(*reg), GFP_KERNEL);
- if (!reg) {
+ event->registered = kzalloc(sizeof(*reg), GFP_KERNEL);
+ if (!event->registered) {
err = -ENOMEM;
goto fail;
}
- reg->event_num = event_num;
- reg->priority = event->priority;
-
- reg->callback = cb;
- reg->callback_arg = cb_arg;
- event->registered = reg;
+ event->registered->event_num = event->event_num;
+ event->registered->priority = event->priority;
+ event->registered->callback = cb;
+ event->registered->callback_arg = cb_arg;
} else {
int cpu;
- struct sdei_registered_event __percpu *regs;
+ struct sdei_registered_event *reg;
- regs = alloc_percpu(struct sdei_registered_event);
- if (!regs) {
+ event->private_registered =
+ alloc_percpu(struct sdei_registered_event);
+ if (!event->private_registered) {
err = -ENOMEM;
goto fail;
}
for_each_possible_cpu(cpu) {
- reg = per_cpu_ptr(regs, cpu);
+ reg = per_cpu_ptr(event->private_registered, cpu);
reg->event_num = event->event_num;
reg->priority = event->priority;
reg->callback = cb;
reg->callback_arg = cb_arg;
}
-
- event->private_registered = regs;
}
spin_lock(&sdei_list_lock);
--
2.23.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-06 5:50 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-06 5:47 [PATCH 00/14] Refactor SDEI client driver Gavin Shan
2020-07-06 5:47 ` [PATCH 01/14] drivers/firmware/sdei: Remove sdei_is_err() Gavin Shan
2020-07-21 20:39 ` James Morse
2020-07-22 2:04 ` Gavin Shan
2020-07-06 5:47 ` [PATCH 02/14] drivers/firmware/sdei: Common block for failing path in sdei_event_create() Gavin Shan
2020-07-21 20:40 ` James Morse
2020-07-22 2:12 ` Gavin Shan
2020-07-06 5:47 ` Gavin Shan [this message]
2020-07-21 20:41 ` [PATCH 03/14] drivers/firmware/sdei: Dereference SDEI event parameter directly James Morse
2020-07-22 2:38 ` Gavin Shan
2020-07-06 5:47 ` [PATCH 04/14] drivers/firmware/sdei: Rework sdei_init() Gavin Shan
2020-07-21 20:42 ` James Morse
2020-07-22 3:34 ` Gavin Shan
2020-07-06 5:47 ` [PATCH 05/14] drivers/firmware/sdei: Remove sdei_get_conduit() Gavin Shan
2020-07-21 20:42 ` James Morse
2020-07-22 3:50 ` Gavin Shan
2020-07-06 5:47 ` [PATCH 06/14] drivers/firmware/sdei: Drop redundant error message in sdei_probe() Gavin Shan
2020-07-06 5:47 ` [PATCH 07/14] drivers/firmware/sdei: Drop unnecessary while loop Gavin Shan
2020-07-06 5:47 ` [PATCH 08/14] drivers/firmware/sdei: Cleanup on cross call functions Gavin Shan
2020-07-06 5:47 ` [PATCH 09/14] drivers/firmware/sdei: Introduce sdei_do_local_call() Gavin Shan
2020-07-06 5:47 ` [PATCH 10/14] drivers/firmware/sdei: Remove _sdei_event_register() Gavin Shan
2020-07-06 5:47 ` [PATCH 11/14] drivers/firmware/sdei: Remove _sdei_event_unregister() Gavin Shan
2020-07-06 5:47 ` [PATCH 12/14] drivers/firmware/sdei: Identify event by struct sdei_event Gavin Shan
2020-07-06 5:47 ` [PATCH 13/14] drivers/firmware/sdei: Retrieve event signaled property on creation Gavin Shan
2020-07-06 5:47 ` [PATCH 14/14] drivers/firmware/sdei: Add sdei_event_get_info() Gavin Shan
2020-07-21 9:44 ` [PATCH 00/14] Refactor SDEI client driver Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200706054732.99387-4-gshan@redhat.com \
--to=gshan@redhat.com \
--cc=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=shan.gavin@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.