All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maxime Ripard <maxime@cerno.tech>
To: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
	Eric Anholt <eric@anholt.net>
Cc: dri-devel@lists.freedesktop.org,
	linux-rpi-kernel@lists.infradead.org,
	bcm-kernel-feedback-list@broadcom.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Dave Stevenson <dave.stevenson@raspberrypi.com>,
	Tim Gover <tim.gover@raspberrypi.com>,
	Phil Elwell <phil@raspberrypi.com>,
	Maxime Ripard <maxime@cerno.tech>
Subject: [PATCH v4 47/78] drm/vc4: hdmi: Retrieve the vc4_hdmi at unbind using our device
Date: Wed,  8 Jul 2020 19:41:55 +0200	[thread overview]
Message-ID: <0fc40024f73b3bc6d9eba0b47da217ed130c3374.1594230107.git-series.maxime@cerno.tech> (raw)
In-Reply-To: <cover.7a1aa1784976093af26cb31fd283cf5b3ed568bb.1594230107.git-series.maxime@cerno.tech>

The unbind function needs to retrieve a vc4_hdmi structure pointer through
the struct device that we're given since we want to support multiple HDMI
controllers.

However, our optional ASoC support doesn't make that trivial since it will
overwrite the device drvdata if we use it, but obviously won't if we don't
use it.

Let's make sure the fields are at the proper offset to be able to cast
between the snd_soc_card structure and the vc4_hdmi structure
transparently so we can support both cases.

Signed-off-by: Maxime Ripard <maxime@cerno.tech>
---
 drivers/gpu/drm/vc4/vc4_hdmi.c | 24 +++++++++++++++++++++++-
 drivers/gpu/drm/vc4/vc4_hdmi.h |  4 ++--
 2 files changed, 25 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c
index 09b297a1b39d..7cd1394c10fa 100644
--- a/drivers/gpu/drm/vc4/vc4_hdmi.c
+++ b/drivers/gpu/drm/vc4/vc4_hdmi.c
@@ -1200,6 +1200,7 @@ static int vc4_hdmi_bind(struct device *dev, struct device *master, void *data)
 	if (!vc4_hdmi)
 		return -ENOMEM;
 
+	dev_set_drvdata(dev, vc4_hdmi);
 	encoder = &vc4_hdmi->encoder.base.base;
 	vc4_hdmi->encoder.base.type = VC4_ENCODER_TYPE_HDMI0;
 	vc4_hdmi->pdev = pdev;
@@ -1362,7 +1363,28 @@ static void vc4_hdmi_unbind(struct device *dev, struct device *master,
 {
 	struct drm_device *drm = dev_get_drvdata(master);
 	struct vc4_dev *vc4 = drm->dev_private;
-	struct vc4_hdmi *vc4_hdmi = vc4->hdmi;
+	struct vc4_hdmi *vc4_hdmi;
+
+	/*
+	 * ASoC makes it a bit hard to retrieve a pointer to the
+	 * vc4_hdmi structure. Registering the card will overwrite our
+	 * device drvdata with a pointer to the snd_soc_card structure,
+	 * which can then be used to retrieve whatever drvdata we want
+	 * to associate.
+	 *
+	 * However, that doesn't fly in the case where we wouldn't
+	 * register an ASoC card (because of an old DT that is missing
+	 * the dmas properties for example), then the card isn't
+	 * registered and the device drvdata wouldn't be set.
+	 *
+	 * We can deal with both cases by making sure a snd_soc_card
+	 * pointer and a vc4_hdmi structure are pointing to the same
+	 * memory address, so we can treat them indistinctly without any
+	 * issue.
+	 */
+	BUILD_BUG_ON(offsetof(struct vc4_hdmi_audio, card) != 0);
+	BUILD_BUG_ON(offsetof(struct vc4_hdmi, audio) != 0);
+	vc4_hdmi = dev_get_drvdata(dev);
 
 	cec_unregister_adapter(vc4_hdmi->cec_adap);
 	vc4_hdmi_connector_destroy(&vc4_hdmi->connector.base);
diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.h b/drivers/gpu/drm/vc4/vc4_hdmi.h
index 749a807cd1f3..d43462789450 100644
--- a/drivers/gpu/drm/vc4/vc4_hdmi.h
+++ b/drivers/gpu/drm/vc4/vc4_hdmi.h
@@ -53,13 +53,13 @@ struct vc4_hdmi_audio {
 
 /* General HDMI hardware state. */
 struct vc4_hdmi {
+	struct vc4_hdmi_audio audio;
+
 	struct platform_device *pdev;
 
 	struct vc4_hdmi_encoder encoder;
 	struct vc4_hdmi_connector connector;
 
-	struct vc4_hdmi_audio audio;
-
 	struct i2c_adapter *ddc;
 	void __iomem *hdmicore_regs;
 	void __iomem *hd_regs;
-- 
git-series 0.9.1

WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime@cerno.tech>
To: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
	Eric Anholt <eric@anholt.net>
Cc: Tim Gover <tim.gover@raspberrypi.com>,
	Dave Stevenson <dave.stevenson@raspberrypi.com>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	bcm-kernel-feedback-list@broadcom.com,
	linux-rpi-kernel@lists.infradead.org,
	Phil Elwell <phil@raspberrypi.com>,
	linux-arm-kernel@lists.infradead.org,
	Maxime Ripard <maxime@cerno.tech>
Subject: [PATCH v4 47/78] drm/vc4: hdmi: Retrieve the vc4_hdmi at unbind using our device
Date: Wed,  8 Jul 2020 19:41:55 +0200	[thread overview]
Message-ID: <0fc40024f73b3bc6d9eba0b47da217ed130c3374.1594230107.git-series.maxime@cerno.tech> (raw)
In-Reply-To: <cover.7a1aa1784976093af26cb31fd283cf5b3ed568bb.1594230107.git-series.maxime@cerno.tech>

The unbind function needs to retrieve a vc4_hdmi structure pointer through
the struct device that we're given since we want to support multiple HDMI
controllers.

However, our optional ASoC support doesn't make that trivial since it will
overwrite the device drvdata if we use it, but obviously won't if we don't
use it.

Let's make sure the fields are at the proper offset to be able to cast
between the snd_soc_card structure and the vc4_hdmi structure
transparently so we can support both cases.

Signed-off-by: Maxime Ripard <maxime@cerno.tech>
---
 drivers/gpu/drm/vc4/vc4_hdmi.c | 24 +++++++++++++++++++++++-
 drivers/gpu/drm/vc4/vc4_hdmi.h |  4 ++--
 2 files changed, 25 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c
index 09b297a1b39d..7cd1394c10fa 100644
--- a/drivers/gpu/drm/vc4/vc4_hdmi.c
+++ b/drivers/gpu/drm/vc4/vc4_hdmi.c
@@ -1200,6 +1200,7 @@ static int vc4_hdmi_bind(struct device *dev, struct device *master, void *data)
 	if (!vc4_hdmi)
 		return -ENOMEM;
 
+	dev_set_drvdata(dev, vc4_hdmi);
 	encoder = &vc4_hdmi->encoder.base.base;
 	vc4_hdmi->encoder.base.type = VC4_ENCODER_TYPE_HDMI0;
 	vc4_hdmi->pdev = pdev;
@@ -1362,7 +1363,28 @@ static void vc4_hdmi_unbind(struct device *dev, struct device *master,
 {
 	struct drm_device *drm = dev_get_drvdata(master);
 	struct vc4_dev *vc4 = drm->dev_private;
-	struct vc4_hdmi *vc4_hdmi = vc4->hdmi;
+	struct vc4_hdmi *vc4_hdmi;
+
+	/*
+	 * ASoC makes it a bit hard to retrieve a pointer to the
+	 * vc4_hdmi structure. Registering the card will overwrite our
+	 * device drvdata with a pointer to the snd_soc_card structure,
+	 * which can then be used to retrieve whatever drvdata we want
+	 * to associate.
+	 *
+	 * However, that doesn't fly in the case where we wouldn't
+	 * register an ASoC card (because of an old DT that is missing
+	 * the dmas properties for example), then the card isn't
+	 * registered and the device drvdata wouldn't be set.
+	 *
+	 * We can deal with both cases by making sure a snd_soc_card
+	 * pointer and a vc4_hdmi structure are pointing to the same
+	 * memory address, so we can treat them indistinctly without any
+	 * issue.
+	 */
+	BUILD_BUG_ON(offsetof(struct vc4_hdmi_audio, card) != 0);
+	BUILD_BUG_ON(offsetof(struct vc4_hdmi, audio) != 0);
+	vc4_hdmi = dev_get_drvdata(dev);
 
 	cec_unregister_adapter(vc4_hdmi->cec_adap);
 	vc4_hdmi_connector_destroy(&vc4_hdmi->connector.base);
diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.h b/drivers/gpu/drm/vc4/vc4_hdmi.h
index 749a807cd1f3..d43462789450 100644
--- a/drivers/gpu/drm/vc4/vc4_hdmi.h
+++ b/drivers/gpu/drm/vc4/vc4_hdmi.h
@@ -53,13 +53,13 @@ struct vc4_hdmi_audio {
 
 /* General HDMI hardware state. */
 struct vc4_hdmi {
+	struct vc4_hdmi_audio audio;
+
 	struct platform_device *pdev;
 
 	struct vc4_hdmi_encoder encoder;
 	struct vc4_hdmi_connector connector;
 
-	struct vc4_hdmi_audio audio;
-
 	struct i2c_adapter *ddc;
 	void __iomem *hdmicore_regs;
 	void __iomem *hd_regs;
-- 
git-series 0.9.1

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime@cerno.tech>
To: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
	Eric Anholt <eric@anholt.net>
Cc: Tim Gover <tim.gover@raspberrypi.com>,
	Dave Stevenson <dave.stevenson@raspberrypi.com>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	bcm-kernel-feedback-list@broadcom.com,
	linux-rpi-kernel@lists.infradead.org,
	Phil Elwell <phil@raspberrypi.com>,
	linux-arm-kernel@lists.infradead.org,
	Maxime Ripard <maxime@cerno.tech>
Subject: [PATCH v4 47/78] drm/vc4: hdmi: Retrieve the vc4_hdmi at unbind using our device
Date: Wed,  8 Jul 2020 19:41:55 +0200	[thread overview]
Message-ID: <0fc40024f73b3bc6d9eba0b47da217ed130c3374.1594230107.git-series.maxime@cerno.tech> (raw)
In-Reply-To: <cover.7a1aa1784976093af26cb31fd283cf5b3ed568bb.1594230107.git-series.maxime@cerno.tech>

The unbind function needs to retrieve a vc4_hdmi structure pointer through
the struct device that we're given since we want to support multiple HDMI
controllers.

However, our optional ASoC support doesn't make that trivial since it will
overwrite the device drvdata if we use it, but obviously won't if we don't
use it.

Let's make sure the fields are at the proper offset to be able to cast
between the snd_soc_card structure and the vc4_hdmi structure
transparently so we can support both cases.

Signed-off-by: Maxime Ripard <maxime@cerno.tech>
---
 drivers/gpu/drm/vc4/vc4_hdmi.c | 24 +++++++++++++++++++++++-
 drivers/gpu/drm/vc4/vc4_hdmi.h |  4 ++--
 2 files changed, 25 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c
index 09b297a1b39d..7cd1394c10fa 100644
--- a/drivers/gpu/drm/vc4/vc4_hdmi.c
+++ b/drivers/gpu/drm/vc4/vc4_hdmi.c
@@ -1200,6 +1200,7 @@ static int vc4_hdmi_bind(struct device *dev, struct device *master, void *data)
 	if (!vc4_hdmi)
 		return -ENOMEM;
 
+	dev_set_drvdata(dev, vc4_hdmi);
 	encoder = &vc4_hdmi->encoder.base.base;
 	vc4_hdmi->encoder.base.type = VC4_ENCODER_TYPE_HDMI0;
 	vc4_hdmi->pdev = pdev;
@@ -1362,7 +1363,28 @@ static void vc4_hdmi_unbind(struct device *dev, struct device *master,
 {
 	struct drm_device *drm = dev_get_drvdata(master);
 	struct vc4_dev *vc4 = drm->dev_private;
-	struct vc4_hdmi *vc4_hdmi = vc4->hdmi;
+	struct vc4_hdmi *vc4_hdmi;
+
+	/*
+	 * ASoC makes it a bit hard to retrieve a pointer to the
+	 * vc4_hdmi structure. Registering the card will overwrite our
+	 * device drvdata with a pointer to the snd_soc_card structure,
+	 * which can then be used to retrieve whatever drvdata we want
+	 * to associate.
+	 *
+	 * However, that doesn't fly in the case where we wouldn't
+	 * register an ASoC card (because of an old DT that is missing
+	 * the dmas properties for example), then the card isn't
+	 * registered and the device drvdata wouldn't be set.
+	 *
+	 * We can deal with both cases by making sure a snd_soc_card
+	 * pointer and a vc4_hdmi structure are pointing to the same
+	 * memory address, so we can treat them indistinctly without any
+	 * issue.
+	 */
+	BUILD_BUG_ON(offsetof(struct vc4_hdmi_audio, card) != 0);
+	BUILD_BUG_ON(offsetof(struct vc4_hdmi, audio) != 0);
+	vc4_hdmi = dev_get_drvdata(dev);
 
 	cec_unregister_adapter(vc4_hdmi->cec_adap);
 	vc4_hdmi_connector_destroy(&vc4_hdmi->connector.base);
diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.h b/drivers/gpu/drm/vc4/vc4_hdmi.h
index 749a807cd1f3..d43462789450 100644
--- a/drivers/gpu/drm/vc4/vc4_hdmi.h
+++ b/drivers/gpu/drm/vc4/vc4_hdmi.h
@@ -53,13 +53,13 @@ struct vc4_hdmi_audio {
 
 /* General HDMI hardware state. */
 struct vc4_hdmi {
+	struct vc4_hdmi_audio audio;
+
 	struct platform_device *pdev;
 
 	struct vc4_hdmi_encoder encoder;
 	struct vc4_hdmi_connector connector;
 
-	struct vc4_hdmi_audio audio;
-
 	struct i2c_adapter *ddc;
 	void __iomem *hdmicore_regs;
 	void __iomem *hd_regs;
-- 
git-series 0.9.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2020-07-08 17:43 UTC|newest]

Thread overview: 432+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20200709070649epcas1p13664bacc66a0f73443bf4d3e8940f933@epcas1p1.samsung.com>
2020-07-08 17:41 ` [PATCH v4 00/78] drm/vc4: Support BCM2711 Display Pipeline Maxime Ripard
2020-07-08 17:41   ` Maxime Ripard
2020-07-08 17:41   ` Maxime Ripard
2020-07-08 17:41   ` [PATCH v4 01/78] dt-bindings: display: Add support for the BCM2711 HVS Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41   ` [PATCH v4 02/78] drm/vc4: Add support for the BCM2711 HVS5 Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41   ` [PATCH v4 03/78] drm/vc4: hvs: Boost the core clock during modeset Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-09-01 11:21     ` Chanwoo Choi
2020-09-01 11:21       ` Chanwoo Choi
2020-09-01 11:21       ` Chanwoo Choi
2020-09-01 11:48       ` Chanwoo Choi
2020-09-01 11:48         ` Chanwoo Choi
2020-09-01 11:48         ` Chanwoo Choi
2020-09-02 14:48       ` Maxime Ripard
2020-09-02 14:48         ` Maxime Ripard
2020-09-02 14:48         ` Maxime Ripard
2020-07-08 17:41   ` [PATCH v4 04/78] drm/vc4: plane: Change LBM alignment constraint on LBM Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41   ` [PATCH v4 05/78] drm/vc4: plane: Optimize the LBM allocation size Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41   ` [PATCH v4 06/78] drm/vc4: plane: Create more planes Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41   ` [PATCH v4 07/78] drm/vc4: crtc: Deal with different number of pixel per clock Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41   ` [PATCH v4 08/78] drm/vc4: crtc: Use a shared interrupt Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41   ` [PATCH v4 09/78] drm/vc4: crtc: Move the cob allocation outside of bind Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41   ` [PATCH v4 10/78] drm/vc4: crtc: Rename HVS channel to output Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-28  9:48     ` Dave Stevenson
2020-07-28  9:48       ` Dave Stevenson
2020-07-28  9:48       ` Dave Stevenson
2020-07-08 17:41   ` [PATCH v4 11/78] drm/vc4: crtc: Use local chan variable Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-28  9:50     ` Dave Stevenson
2020-07-28  9:50       ` Dave Stevenson
2020-07-28  9:50       ` Dave Stevenson
2020-07-08 17:41   ` [PATCH v4 12/78] drm/vc4: crtc: Enable and disable the PV in atomic_enable / disable Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-28  9:57     ` Dave Stevenson
2020-07-28  9:57       ` Dave Stevenson
2020-07-28  9:57       ` Dave Stevenson
2020-07-08 17:41   ` [PATCH v4 13/78] drm/vc4: kms: Convert to for_each_new_crtc_state Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-29 15:02     ` Dave Stevenson
2020-07-29 15:02       ` Dave Stevenson
2020-07-29 15:02       ` Dave Stevenson
2020-09-02 17:59       ` Maxime Ripard
2020-09-02 17:59         ` Maxime Ripard
2020-09-02 17:59         ` Maxime Ripard
2020-07-08 17:41   ` [PATCH v4 14/78] drm/vc4: crtc: Assign output to channel automatically Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-29 14:31     ` Dave Stevenson
2020-07-29 14:31       ` Dave Stevenson
2020-07-29 14:31       ` Dave Stevenson
2020-07-08 17:41   ` [PATCH v4 15/78] drm/vc4: crtc: Add FIFO depth to vc4_crtc_data Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41   ` [PATCH v4 16/78] drm/vc4: crtc: Add function to compute FIFO level bits Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41   ` [PATCH v4 17/78] drm/vc4: crtc: Rename HDMI encoder type to HDMI0 Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41   ` [PATCH v4 18/78] drm/vc4: crtc: Add HDMI1 encoder type Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41   ` [PATCH v4 19/78] drm/vc4: crtc: Disable color management for HVS5 Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41   ` [PATCH v4 20/78] drm/vc4: crtc: Turn pixelvalve reset into a function Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41   ` [PATCH v4 21/78] drm/vc4: crtc: Move PV dump to config_pv Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-28 10:30     ` Dave Stevenson
2020-07-28 10:30       ` Dave Stevenson
2020-07-28 10:30       ` Dave Stevenson
2020-07-08 17:41   ` [PATCH v4 22/78] drm/vc4: crtc: Move HVS init and close to a function Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-28 10:31     ` Dave Stevenson
2020-07-28 10:31       ` Dave Stevenson
2020-07-28 10:31       ` Dave Stevenson
2020-07-08 17:41   ` [PATCH v4 23/78] drm/vc4: crtc: Move the HVS gamma LUT setup to our init function Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-29 14:42     ` Dave Stevenson
2020-07-29 14:42       ` Dave Stevenson
2020-07-29 14:42       ` Dave Stevenson
2020-07-08 17:41   ` [PATCH v4 24/78] drm/vc4: hvs: Make sure our channel is reset Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-28 10:37     ` Dave Stevenson
2020-07-28 10:37       ` Dave Stevenson
2020-07-28 10:37       ` Dave Stevenson
2020-07-08 17:41   ` [PATCH v4 25/78] drm/vc4: crtc: Remove mode_set_nofb Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-28 10:38     ` Dave Stevenson
2020-07-28 10:38       ` Dave Stevenson
2020-07-28 10:38       ` Dave Stevenson
2020-07-08 17:41   ` [PATCH v4 26/78] drm/vc4: crtc: Remove redundant pixelvalve reset Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-28 10:39     ` Dave Stevenson
2020-07-28 10:39       ` Dave Stevenson
2020-07-28 10:39       ` Dave Stevenson
2020-07-08 17:41   ` [PATCH v4 27/78] drm/vc4: crtc: Move HVS channel init before the PV initialisation Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-28 10:40     ` Dave Stevenson
2020-07-28 10:40       ` Dave Stevenson
2020-07-28 10:40       ` Dave Stevenson
2020-07-08 17:41   ` [PATCH v4 28/78] drm/vc4: encoder: Add finer-grained encoder callbacks Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-28 11:25     ` Dave Stevenson
2020-07-28 11:25       ` Dave Stevenson
2020-07-28 11:25       ` Dave Stevenson
2020-07-08 17:41   ` [PATCH v4 29/78] drm/vc4: crtc: Add a delay after disabling the PixelValve output Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-29 14:09     ` Dave Stevenson
2020-07-29 14:09       ` Dave Stevenson
2020-07-29 14:09       ` Dave Stevenson
2020-07-29 14:42       ` Maxime Ripard
2020-07-29 14:42         ` Maxime Ripard
2020-07-29 14:42         ` Maxime Ripard
2020-07-29 14:45         ` Dave Stevenson
2020-07-29 14:45           ` Dave Stevenson
2020-07-29 14:45           ` Dave Stevenson
2020-07-29 15:50         ` Stefan Wahren
2020-07-29 15:50           ` Stefan Wahren
2020-07-29 15:50           ` Stefan Wahren
2020-08-25 15:06           ` Maxime Ripard
2020-08-25 15:06             ` Maxime Ripard
2020-08-25 15:06             ` Maxime Ripard
2020-08-25 21:30             ` Stefan Wahren
2020-08-25 21:30               ` Stefan Wahren
2020-08-25 21:30               ` Stefan Wahren
2020-09-01  9:58               ` Maxime Ripard
2020-09-01  9:58                 ` Maxime Ripard
2020-09-01  9:58                 ` Maxime Ripard
2020-09-01 16:31                 ` Stefan Wahren
2020-09-01 16:31                   ` Stefan Wahren
2020-09-01 16:31                   ` Stefan Wahren
2020-09-02 15:08                   ` Maxime Ripard
2020-09-02 15:08                     ` Maxime Ripard
2020-09-02 15:08                     ` Maxime Ripard
2020-07-08 17:41   ` [PATCH v4 30/78] drm/vc4: crtc: Clear the PixelValve FIFO on disable Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-28 11:40     ` Dave Stevenson
2020-07-28 11:40       ` Dave Stevenson
2020-07-28 11:40       ` Dave Stevenson
2020-07-08 17:41   ` [PATCH v4 31/78] drm/vc4: crtc: Clear the PixelValve FIFO during configuration Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-28 11:41     ` Dave Stevenson
2020-07-28 11:41       ` Dave Stevenson
2020-07-28 11:41       ` Dave Stevenson
2020-07-08 17:41   ` [PATCH v4 32/78] drm/vc4: hvs: Make the stop_channel function public Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41   ` [PATCH v4 33/78] drm/vc4: hvs: Introduce a function to get the assigned FIFO Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41   ` [PATCH v4 34/78] drm/vc4: crtc: Move the CRTC disable out Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41   ` [PATCH v4 35/78] drm/vc4: drv: Disable the CRTC at boot time Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41   ` [PATCH v4 36/78] dt-bindings: display: vc4: pv: Add BCM2711 pixel valves Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41   ` [PATCH v4 37/78] drm/vc4: crtc: Add BCM2711 pixelvalves Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41   ` [PATCH v4 38/78] drm/vc4: hdmi: Use debugfs private field Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41   ` [PATCH v4 39/78] drm/vc4: hdmi: Move structure to header Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41   ` [PATCH v4 40/78] drm/vc4: hdmi: rework connectors and encoders Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-28 11:58     ` Dave Stevenson
2020-07-28 11:58       ` Dave Stevenson
2020-07-28 11:58       ` Dave Stevenson
2020-07-08 17:41   ` [PATCH v4 41/78] drm/vc4: hdmi: Remove DDC argument to connector_init Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41   ` [PATCH v4 42/78] drm/vc4: hdmi: Rename hdmi to vc4_hdmi Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41   ` [PATCH v4 43/78] drm/vc4: hdmi: Move accessors " Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41   ` [PATCH v4 44/78] drm/vc4: hdmi: Use local vc4_hdmi directly Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41   ` [PATCH v4 45/78] drm/vc4: hdmi: Add container_of macros for encoders and connectors Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41   ` [PATCH v4 46/78] drm/vc4: hdmi: Pass vc4_hdmi to CEC code Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41   ` Maxime Ripard [this message]
2020-07-08 17:41     ` [PATCH v4 47/78] drm/vc4: hdmi: Retrieve the vc4_hdmi at unbind using our device Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-28 12:32     ` Dave Stevenson
2020-07-28 12:32       ` Dave Stevenson
2020-07-28 12:32       ` Dave Stevenson
2020-07-08 17:41   ` [PATCH v4 48/78] drm/vc4: hdmi: Remove vc4_dev hdmi pointer Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41   ` [PATCH v4 49/78] drm/vc4: hdmi: Remove vc4_hdmi_connector Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41   ` [PATCH v4 50/78] drm/vc4: hdmi: Introduce resource init and variant Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-28 12:37     ` Dave Stevenson
2020-07-28 12:37       ` Dave Stevenson
2020-07-28 12:37       ` Dave Stevenson
2020-07-08 17:41   ` [PATCH v4 51/78] drm/vc4: hdmi: Implement a register layout abstraction Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-08 17:41     ` Maxime Ripard
2020-07-28 12:59     ` Dave Stevenson
2020-07-28 12:59       ` Dave Stevenson
2020-07-28 12:59       ` Dave Stevenson
2020-07-08 17:42   ` [PATCH v4 52/78] drm/vc4: hdmi: Add reset callback Maxime Ripard
2020-07-08 17:42     ` Maxime Ripard
2020-07-08 17:42     ` Maxime Ripard
2020-07-28 13:00     ` Dave Stevenson
2020-07-28 13:00       ` Dave Stevenson
2020-07-28 13:00       ` Dave Stevenson
2020-07-08 17:42   ` [PATCH v4 53/78] drm/vc4: hdmi: Add PHY init and disable function Maxime Ripard
2020-07-08 17:42     ` Maxime Ripard
2020-07-08 17:42     ` Maxime Ripard
2020-07-28 13:03     ` Dave Stevenson
2020-07-28 13:03       ` Dave Stevenson
2020-07-28 13:03       ` Dave Stevenson
2020-07-08 17:42   ` [PATCH v4 54/78] drm/vc4: hdmi: Add PHY RNG enable / " Maxime Ripard
2020-07-08 17:42     ` Maxime Ripard
2020-07-08 17:42     ` Maxime Ripard
2020-07-28 13:04     ` Dave Stevenson
2020-07-28 13:04       ` Dave Stevenson
2020-07-28 13:04       ` Dave Stevenson
2020-07-08 17:42   ` [PATCH v4 55/78] drm/vc4: hdmi: Add a CSC setup callback Maxime Ripard
2020-07-08 17:42     ` Maxime Ripard
2020-07-08 17:42     ` Maxime Ripard
2020-07-28 13:12     ` Dave Stevenson
2020-07-28 13:12       ` Dave Stevenson
2020-07-28 13:12       ` Dave Stevenson
2020-07-08 17:42   ` [PATCH v4 56/78] drm/vc4: hdmi: Store the encoder type in the variant structure Maxime Ripard
2020-07-08 17:42     ` Maxime Ripard
2020-07-08 17:42     ` Maxime Ripard
2020-07-28 13:18     ` Dave Stevenson
2020-07-28 13:18       ` Dave Stevenson
2020-07-28 13:18       ` Dave Stevenson
2020-07-08 17:42   ` [PATCH v4 57/78] drm/vc4: hdmi: Deal with multiple debugfs files Maxime Ripard
2020-07-08 17:42     ` Maxime Ripard
2020-07-08 17:42     ` Maxime Ripard
2020-07-28 13:20     ` Dave Stevenson
2020-07-28 13:20       ` Dave Stevenson
2020-07-28 13:20       ` Dave Stevenson
2020-07-08 17:42   ` [PATCH v4 58/78] drm/vc4: hdmi: Move CEC init to its own function Maxime Ripard
2020-07-08 17:42     ` Maxime Ripard
2020-07-08 17:42     ` Maxime Ripard
2020-07-28 13:23     ` Dave Stevenson
2020-07-28 13:23       ` Dave Stevenson
2020-07-28 13:23       ` Dave Stevenson
2020-07-08 17:42   ` [PATCH v4 59/78] drm/vc4: hdmi: Add CEC support flag Maxime Ripard
2020-07-08 17:42     ` Maxime Ripard
2020-07-08 17:42     ` Maxime Ripard
2020-07-28 13:25     ` Dave Stevenson
2020-07-28 13:25       ` Dave Stevenson
2020-07-28 13:25       ` Dave Stevenson
2020-07-08 17:42   ` [PATCH v4 60/78] drm/vc4: hdmi: Remove unused CEC_CLOCK_DIV define Maxime Ripard
2020-07-08 17:42     ` Maxime Ripard
2020-07-08 17:42     ` Maxime Ripard
2020-07-28 13:26     ` Dave Stevenson
2020-07-28 13:26       ` Dave Stevenson
2020-07-28 13:26       ` Dave Stevenson
2020-07-08 17:42   ` [PATCH v4 61/78] drm/vc4: hdmi: Rename drm_encoder pointer in mode_valid Maxime Ripard
2020-07-08 17:42     ` Maxime Ripard
2020-07-08 17:42     ` Maxime Ripard
2020-07-28 14:45     ` Dave Stevenson
2020-07-28 14:45       ` Dave Stevenson
2020-07-28 14:45       ` Dave Stevenson
2020-07-08 17:42   ` [PATCH v4 62/78] drm/vc4: hdmi: Adjust HSM clock rate depending on pixel rate Maxime Ripard
2020-07-08 17:42     ` Maxime Ripard
2020-07-08 17:42     ` Maxime Ripard
2020-07-28 14:56     ` Dave Stevenson
2020-07-28 14:56       ` Dave Stevenson
2020-07-28 14:56       ` Dave Stevenson
2020-09-01  4:36     ` Chanwoo Choi
2020-09-01  4:36       ` Chanwoo Choi
2020-09-01  4:36       ` Chanwoo Choi
2020-09-01  9:45       ` Maxime Ripard
2020-09-01  9:45         ` Maxime Ripard
2020-09-01  9:45         ` Maxime Ripard
2020-09-01 10:48         ` Chanwoo Choi
2020-09-01 10:48           ` Chanwoo Choi
2020-09-01 10:48           ` Chanwoo Choi
2020-07-08 17:42   ` [PATCH v4 63/78] drm/vc4: hdmi: Use clk_set_min_rate instead Maxime Ripard
2020-07-08 17:42     ` Maxime Ripard
2020-07-08 17:42     ` Maxime Ripard
2020-07-28 14:57     ` Dave Stevenson
2020-07-28 14:57       ` Dave Stevenson
2020-07-28 14:57       ` Dave Stevenson
2020-07-08 17:42   ` [PATCH v4 64/78] drm/vc4: hdmi: Use reg-names to retrieve the HDMI audio registers Maxime Ripard
2020-07-08 17:42     ` Maxime Ripard
2020-07-08 17:42     ` Maxime Ripard
2020-07-08 17:42   ` [PATCH v4 65/78] drm/vc4: hdmi: Reset audio infoframe on encoder_enable if previously streaming Maxime Ripard
2020-07-08 17:42     ` Maxime Ripard
2020-07-08 17:42     ` Maxime Ripard
2020-07-08 17:42   ` [PATCH v4 66/78] drm/vc4: hdmi: Set the b-frame marker to the match ALSA's default Maxime Ripard
2020-07-08 17:42     ` Maxime Ripard
2020-07-08 17:42     ` Maxime Ripard
2020-07-08 17:42   ` [PATCH v4 67/78] drm/vc4: hdmi: Add audio-related callbacks Maxime Ripard
2020-07-08 17:42     ` Maxime Ripard
2020-07-08 17:42     ` Maxime Ripard
2020-07-08 17:42   ` [PATCH v4 68/78] drm/vc4: hdmi: Deal with multiple ALSA cards Maxime Ripard
2020-07-08 17:42     ` Maxime Ripard
2020-07-08 17:42     ` Maxime Ripard
2020-07-28 15:00     ` Dave Stevenson
2020-07-28 15:00       ` Dave Stevenson
2020-07-28 15:00       ` Dave Stevenson
2020-07-08 17:42   ` [PATCH v4 69/78] drm/vc4: hdmi: Remove register dumps in enable Maxime Ripard
2020-07-08 17:42     ` Maxime Ripard
2020-07-08 17:42     ` Maxime Ripard
2020-07-28 15:01     ` Dave Stevenson
2020-07-28 15:01       ` Dave Stevenson
2020-07-28 15:01       ` Dave Stevenson
2020-07-08 17:42   ` [PATCH v4 70/78] drm/vc4: hdmi: Always recenter the HDMI FIFO Maxime Ripard
2020-07-08 17:42     ` Maxime Ripard
2020-07-08 17:42     ` Maxime Ripard
2020-07-28 15:03     ` Dave Stevenson
2020-07-28 15:03       ` Dave Stevenson
2020-07-28 15:03       ` Dave Stevenson
2020-07-08 17:42   ` [PATCH v4 71/78] drm/vc4: hdmi: Implement finer-grained hooks Maxime Ripard
2020-07-08 17:42     ` Maxime Ripard
2020-07-08 17:42     ` Maxime Ripard
2020-07-28 15:04     ` Dave Stevenson
2020-07-28 15:04       ` Dave Stevenson
2020-07-28 15:04       ` Dave Stevenson
2020-07-08 17:42   ` [PATCH v4 72/78] drm/vc4: hdmi: Do the VID_CTL configuration at once Maxime Ripard
2020-07-08 17:42     ` Maxime Ripard
2020-07-08 17:42     ` Maxime Ripard
2020-07-28 15:06     ` Dave Stevenson
2020-07-28 15:06       ` Dave Stevenson
2020-07-28 15:06       ` Dave Stevenson
2020-07-08 17:42   ` [PATCH v4 73/78] drm/vc4: hdmi: Switch to blank pixels when disabled Maxime Ripard
2020-07-08 17:42     ` Maxime Ripard
2020-07-08 17:42     ` Maxime Ripard
2020-07-28 15:09     ` Dave Stevenson
2020-07-28 15:09       ` Dave Stevenson
2020-07-28 15:09       ` Dave Stevenson
2020-07-08 17:42   ` [PATCH v4 74/78] drm/vc4: hdmi: Support the BCM2711 HDMI controllers Maxime Ripard
2020-07-08 17:42     ` Maxime Ripard
2020-07-08 17:42     ` Maxime Ripard
2020-07-28 15:21     ` Dave Stevenson
2020-07-28 15:21       ` Dave Stevenson
2020-07-28 15:21       ` Dave Stevenson
2020-07-08 17:42   ` [PATCH v4 75/78] dt-bindings: display: vc4: hdmi: Add BCM2711 HDMI controllers bindings Maxime Ripard
2020-07-08 17:42     ` Maxime Ripard
2020-07-08 17:42     ` Maxime Ripard
2020-09-01  4:45     ` Chanwoo Choi
2020-09-01  4:45       ` Chanwoo Choi
2020-09-01  4:45       ` Chanwoo Choi
2020-09-01  9:52       ` Maxime Ripard
2020-09-01  9:52         ` Maxime Ripard
2020-09-01  9:52         ` Maxime Ripard
2020-07-08 17:42   ` [PATCH v4 76/78] dt-bindings: display: vc4: Document BCM2711 VC5 Maxime Ripard
2020-07-08 17:42     ` Maxime Ripard
2020-07-08 17:42     ` Maxime Ripard
2020-07-08 17:42   ` [PATCH v4 77/78] drm/vc4: drv: Support BCM2711 Maxime Ripard
2020-07-08 17:42     ` Maxime Ripard
2020-07-08 17:42     ` Maxime Ripard
2020-07-28 15:30     ` Dave Stevenson
2020-07-28 15:30       ` Dave Stevenson
2020-07-28 15:30       ` Dave Stevenson
2020-09-01 10:19       ` Maxime Ripard
2020-09-01 10:19         ` Maxime Ripard
2020-09-01 10:19         ` Maxime Ripard
2020-07-08 17:42   ` [PATCH v4 78/78] ARM: dts: bcm2711: Enable the display pipeline Maxime Ripard
2020-07-08 17:42     ` Maxime Ripard
2020-07-08 17:42     ` Maxime Ripard
2020-07-28 15:35     ` Dave Stevenson
2020-07-28 15:35       ` Dave Stevenson
2020-07-28 15:35       ` Dave Stevenson
2020-07-10  7:37   ` [PATCH v4 00/78] drm/vc4: Support BCM2711 Display Pipeline Jian-Hong Pan
2020-07-10  7:37     ` Jian-Hong Pan
2020-07-10  7:37     ` Jian-Hong Pan
2020-07-10  9:58   ` Stefan Wahren
2020-07-10  9:58     ` Stefan Wahren
2020-07-10  9:58     ` Stefan Wahren
2020-08-21  7:18   ` Hoegeun Kwon
2020-08-21  7:18     ` Hoegeun Kwon
2020-08-21  7:18     ` Hoegeun Kwon
2020-09-02 13:32     ` Maxime Ripard
2020-09-02 13:32       ` Maxime Ripard
2020-09-02 13:32       ` Maxime Ripard
2020-09-02 13:52       ` Maxime Ripard
2020-09-02 13:52         ` Maxime Ripard
2020-09-02 13:52         ` Maxime Ripard
2020-08-31  2:36   ` Chanwoo Choi
2020-08-31  2:36     ` Chanwoo Choi
2020-08-31  2:36     ` Chanwoo Choi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0fc40024f73b3bc6d9eba0b47da217ed130c3374.1594230107.git-series.maxime@cerno.tech \
    --to=maxime@cerno.tech \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=dave.stevenson@raspberrypi.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=eric@anholt.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=nsaenzjulienne@suse.de \
    --cc=phil@raspberrypi.com \
    --cc=tim.gover@raspberrypi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.