From: Gustavo Pimentel <gustavo.pimentel@synopsys.com> To: Andrey Smirnov <andrew.smirnov@gmail.com>, Gustavo Pimentel <gustavo.pimentel@synopsys.com> Cc: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>, Bjorn Helgaas <bhelgaas@google.com>, "Fabio Estevam" <fabio.estevam@nxp.com>, Chris Healy <cphealy@gmail.com>, "Lucas Stach" <l.stach@pengutronix.de>, Leonard Crestez <leonard.crestez@nxp.com>, "A.s. Dong" <aisheng.dong@nxp.com>, Richard Zhu <hongxing.zhu@nxp.com>, "linux-imx@nxp.com" <linux-imx@nxp.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: Re: [PATCH 11/21] PCI: designware: Make use of BIT() in constant definitions Date: Wed, 2 Jan 2019 18:31:43 +0000 [thread overview] Message-ID: <0fd12beb-1e53-4596-a261-9870452a6c19@synopsys.com> (raw) In-Reply-To: <CAHQ1cqH3uFj51ORhp1eHPp6jVNoM0D1nv5qHvQESnmPX3-ESoQ@mail.gmail.com> Hi, On 02/01/2019 18:28, Andrey Smirnov wrote: > On Wed, Dec 26, 2018 at 7:19 AM Gustavo Pimentel > <gustavo.pimentel@synopsys.com> wrote: >> >> Hi, >> >> On 21/12/2018 07:27, Andrey Smirnov wrote: >>> Avoid using explicit left shifts and convert various definitions to >>> use BIT() instead. No functional change intended. >>> >>> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> >>> Cc: Bjorn Helgaas <bhelgaas@google.com> >>> Cc: Fabio Estevam <fabio.estevam@nxp.com> >>> Cc: Chris Healy <cphealy@gmail.com> >>> Cc: Lucas Stach <l.stach@pengutronix.de> >>> Cc: Leonard Crestez <leonard.crestez@nxp.com> >>> Cc: "A.s. Dong" <aisheng.dong@nxp.com> >>> Cc: Richard Zhu <hongxing.zhu@nxp.com> >>> Cc: linux-imx@nxp.com >>> Cc: linux-arm-kernel@lists.infradead.org >>> Cc: linux-kernel@vger.kernel.org >>> Cc: linux-pci@vger.kernel.org >>> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> >>> --- >>> drivers/pci/controller/dwc/pcie-designware.c | 2 +- >>> drivers/pci/controller/dwc/pcie-designware.h | 18 +++++++++--------- >>> 2 files changed, 10 insertions(+), 10 deletions(-) >>> >>> diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c >>> index d123ac290b9e..086e87a40316 100644 >>> --- a/drivers/pci/controller/dwc/pcie-designware.c >>> +++ b/drivers/pci/controller/dwc/pcie-designware.c >>> @@ -300,7 +300,7 @@ void dw_pcie_disable_atu(struct dw_pcie *pci, int index, >>> } >>> >>> dw_pcie_writel_dbi(pci, PCIE_ATU_VIEWPORT, region | index); >>> - dw_pcie_writel_dbi(pci, PCIE_ATU_CR2, ~PCIE_ATU_ENABLE); >>> + dw_pcie_writel_dbi(pci, PCIE_ATU_CR2, (u32)~PCIE_ATU_ENABLE); >> >> This is unrelated with the patch description purpose. >> > > This is a direct result of converting PCIE_ATU_ENABLE to BIT(31). > BIT(31) expands to (1UL << 31) so, without that cast I get > > drivers/pci/controller/dwc/pcie-designware.c: In function > ‘dw_pcie_disable_atu’: > drivers/pci/controller/dwc/pcie-designware.c:303:40: warning: large > integer implicitly truncated to unsigned type [-Woverflow] > dw_pcie_writel_dbi(pci, PCIE_ATU_CR2, ~PCIE_ATU_ENABLE); > > on AArch64. I am guessing that original definition of (1 << 31) avoids > this problem by being an "int" instead of "unsigned long". Ok, understood. Acked-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com> > > Thanks, > Andrey Smirnov >
WARNING: multiple messages have this Message-ID (diff)
From: Gustavo Pimentel <gustavo.pimentel@synopsys.com> To: Andrey Smirnov <andrew.smirnov@gmail.com>, Gustavo Pimentel <gustavo.pimentel@synopsys.com> Cc: "A.s. Dong" <aisheng.dong@nxp.com>, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>, Richard Zhu <hongxing.zhu@nxp.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Fabio Estevam <fabio.estevam@nxp.com>, "linux-imx@nxp.com" <linux-imx@nxp.com>, Bjorn Helgaas <bhelgaas@google.com>, Leonard Crestez <leonard.crestez@nxp.com>, Chris Healy <cphealy@gmail.com>, Lucas Stach <l.stach@pengutronix.de> Subject: Re: [PATCH 11/21] PCI: designware: Make use of BIT() in constant definitions Date: Wed, 2 Jan 2019 18:31:43 +0000 [thread overview] Message-ID: <0fd12beb-1e53-4596-a261-9870452a6c19@synopsys.com> (raw) In-Reply-To: <CAHQ1cqH3uFj51ORhp1eHPp6jVNoM0D1nv5qHvQESnmPX3-ESoQ@mail.gmail.com> Hi, On 02/01/2019 18:28, Andrey Smirnov wrote: > On Wed, Dec 26, 2018 at 7:19 AM Gustavo Pimentel > <gustavo.pimentel@synopsys.com> wrote: >> >> Hi, >> >> On 21/12/2018 07:27, Andrey Smirnov wrote: >>> Avoid using explicit left shifts and convert various definitions to >>> use BIT() instead. No functional change intended. >>> >>> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> >>> Cc: Bjorn Helgaas <bhelgaas@google.com> >>> Cc: Fabio Estevam <fabio.estevam@nxp.com> >>> Cc: Chris Healy <cphealy@gmail.com> >>> Cc: Lucas Stach <l.stach@pengutronix.de> >>> Cc: Leonard Crestez <leonard.crestez@nxp.com> >>> Cc: "A.s. Dong" <aisheng.dong@nxp.com> >>> Cc: Richard Zhu <hongxing.zhu@nxp.com> >>> Cc: linux-imx@nxp.com >>> Cc: linux-arm-kernel@lists.infradead.org >>> Cc: linux-kernel@vger.kernel.org >>> Cc: linux-pci@vger.kernel.org >>> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> >>> --- >>> drivers/pci/controller/dwc/pcie-designware.c | 2 +- >>> drivers/pci/controller/dwc/pcie-designware.h | 18 +++++++++--------- >>> 2 files changed, 10 insertions(+), 10 deletions(-) >>> >>> diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c >>> index d123ac290b9e..086e87a40316 100644 >>> --- a/drivers/pci/controller/dwc/pcie-designware.c >>> +++ b/drivers/pci/controller/dwc/pcie-designware.c >>> @@ -300,7 +300,7 @@ void dw_pcie_disable_atu(struct dw_pcie *pci, int index, >>> } >>> >>> dw_pcie_writel_dbi(pci, PCIE_ATU_VIEWPORT, region | index); >>> - dw_pcie_writel_dbi(pci, PCIE_ATU_CR2, ~PCIE_ATU_ENABLE); >>> + dw_pcie_writel_dbi(pci, PCIE_ATU_CR2, (u32)~PCIE_ATU_ENABLE); >> >> This is unrelated with the patch description purpose. >> > > This is a direct result of converting PCIE_ATU_ENABLE to BIT(31). > BIT(31) expands to (1UL << 31) so, without that cast I get > > drivers/pci/controller/dwc/pcie-designware.c: In function > ‘dw_pcie_disable_atu’: > drivers/pci/controller/dwc/pcie-designware.c:303:40: warning: large > integer implicitly truncated to unsigned type [-Woverflow] > dw_pcie_writel_dbi(pci, PCIE_ATU_CR2, ~PCIE_ATU_ENABLE); > > on AArch64. I am guessing that original definition of (1 << 31) avoids > this problem by being an "int" instead of "unsigned long". Ok, understood. Acked-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com> > > Thanks, > Andrey Smirnov > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-02 18:36 UTC|newest] Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-12-21 7:26 [PATCH 00/21] i.MX6, DesignWare PCI improvements Andrey Smirnov 2018-12-21 7:26 ` Andrey Smirnov 2018-12-21 7:26 ` [PATCH 01/21] PCI: imx6: Simplify imx7d_pcie_wait_for_phy_pll_lock() Andrey Smirnov 2018-12-21 7:26 ` Andrey Smirnov 2018-12-21 7:26 ` [PATCH 02/21] PCI: imx6: Remove redundant debug tracing Andrey Smirnov 2018-12-21 7:26 ` Andrey Smirnov 2018-12-21 7:26 ` [PATCH 03/21] PCI: imx6: Return -ETIMEOUT from imx6_pcie_wait_for_speed_change() Andrey Smirnov 2018-12-21 7:26 ` Andrey Smirnov 2018-12-21 7:26 ` [PATCH 04/21] PCI: imx6: Remove duplicate macro definitions Andrey Smirnov 2018-12-21 7:26 ` Andrey Smirnov 2018-12-21 7:27 ` [PATCH 05/21] PCI: imx6: Remove PCIE_PL_PFLR_* constants Andrey Smirnov 2018-12-21 7:27 ` Andrey Smirnov 2018-12-21 7:27 ` [PATCH 06/21] PCI: imx6: Remove PCIE_PHY_RX_ASIC_OUT* constants Andrey Smirnov 2018-12-21 7:27 ` Andrey Smirnov 2018-12-21 7:27 ` [PATCH 07/21] PCI: designware: Make use of IS_ALIGNED() Andrey Smirnov 2018-12-21 7:27 ` Andrey Smirnov 2019-01-02 9:33 ` Gustavo Pimentel 2019-01-04 18:37 ` Joe Perches 2019-01-04 18:37 ` Joe Perches 2019-01-04 18:52 ` Andrey Smirnov 2019-01-04 18:52 ` Andrey Smirnov 2018-12-21 7:27 ` [PATCH 08/21] PCI: designware: Share code for dw_pcie_rd/wr_other_conf() Andrey Smirnov 2018-12-21 7:27 ` Andrey Smirnov 2019-01-02 10:21 ` Gustavo Pimentel 2018-12-21 7:27 ` [PATCH 09/21] PCI: imx6: Drop imx6_pcie_link_up() Andrey Smirnov 2018-12-21 7:27 ` Andrey Smirnov 2018-12-21 18:55 ` Trent Piepho 2018-12-21 18:55 ` Trent Piepho 2018-12-22 0:39 ` Andrey Smirnov 2018-12-22 0:39 ` Andrey Smirnov 2018-12-21 7:27 ` [PATCH 10/21] PCI: designware: imx6: Share PHY debug register definitions Andrey Smirnov 2018-12-21 7:27 ` Andrey Smirnov 2018-12-21 7:27 ` [PATCH 11/21] PCI: designware: Make use of BIT() in constant definitions Andrey Smirnov 2018-12-21 7:27 ` Andrey Smirnov 2018-12-26 15:14 ` Gustavo Pimentel 2018-12-26 15:14 ` Gustavo Pimentel 2019-01-02 18:28 ` Andrey Smirnov 2019-01-02 18:28 ` Andrey Smirnov 2019-01-02 18:31 ` Gustavo Pimentel [this message] 2019-01-02 18:31 ` Gustavo Pimentel 2018-12-21 7:27 ` [PATCH 12/21] PCI: imx6: " Andrey Smirnov 2018-12-21 7:27 ` Andrey Smirnov 2018-12-21 7:27 ` [PATCH 13/21] PCI: imx6: Simplify bit operations in PHY functions Andrey Smirnov 2018-12-21 7:27 ` Andrey Smirnov 2018-12-21 7:27 ` [PATCH 14/21] PCI: imx6: Simplify pcie_phy_poll_ack() Andrey Smirnov 2018-12-21 7:27 ` Andrey Smirnov 2018-12-21 7:27 ` [PATCH 15/21] PCI: imx6: Restrict PHY register data to 16-bit Andrey Smirnov 2018-12-21 7:27 ` Andrey Smirnov 2018-12-21 7:27 ` [PATCH 16/21] PCI: imx6: Pass data to dw_pcie_writel_dbi() directly Andrey Smirnov 2018-12-21 7:27 ` Andrey Smirnov 2018-12-21 7:27 ` [PATCH 17/21] PCI: imx6: Use common mask in imx6_pcie_reset_phy() Andrey Smirnov 2018-12-21 7:27 ` Andrey Smirnov 2018-12-21 7:27 ` [PATCH 18/21] PCI: imx6: Simplify bit operations in imx6_setup_phy_mpll() Andrey Smirnov 2018-12-21 7:27 ` Andrey Smirnov 2018-12-21 7:27 ` [PATCH 19/21] PCI: imx6: Remove magic numbers from imx6_pcie_establish_link() Andrey Smirnov 2018-12-21 7:27 ` Andrey Smirnov 2018-12-21 7:27 ` [PATCH 20/21] PCI: designware: Make use of GENMASK/FIELD_PREP Andrey Smirnov 2018-12-21 7:27 ` Andrey Smirnov 2018-12-26 15:07 ` Gustavo Pimentel 2018-12-26 15:07 ` Gustavo Pimentel 2018-12-21 7:27 ` [PATCH 21/21] PCI: designware: Remove superfluous shifting in definitions Andrey Smirnov 2018-12-21 7:27 ` Andrey Smirnov 2018-12-26 14:49 ` Gustavo Pimentel 2018-12-26 14:49 ` Gustavo Pimentel 2018-12-26 15:26 ` [PATCH 00/21] i.MX6, DesignWare PCI improvements Gustavo Pimentel 2018-12-26 15:26 ` Gustavo Pimentel
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=0fd12beb-1e53-4596-a261-9870452a6c19@synopsys.com \ --to=gustavo.pimentel@synopsys.com \ --cc=aisheng.dong@nxp.com \ --cc=andrew.smirnov@gmail.com \ --cc=bhelgaas@google.com \ --cc=cphealy@gmail.com \ --cc=fabio.estevam@nxp.com \ --cc=hongxing.zhu@nxp.com \ --cc=l.stach@pengutronix.de \ --cc=leonard.crestez@nxp.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=lorenzo.pieralisi@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.