From: "Heiko Stübner" <heiko@sntech.de>
To: Johan Jonker <jbx6244@gmail.com>
Cc: helen.koike@collabora.com, dafna.hirschfeld@collabora.com,
devel@driverdev.osuosl.org, devicetree@vger.kernel.org,
ezequiel@collabora.com, hverkuil-cisco@xs4all.nl,
karthik.poduval@gmail.com, kernel@collabora.com,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux-rockchip@lists.infradead.org, mark.rutland@arm.com,
robh+dt@kernel.org
Subject: Re: [PATCH 3/4] arm64: dts: rockchip: add rx0 mipi-phy for rk3399
Date: Thu, 02 Apr 2020 16:31:11 +0200 [thread overview]
Message-ID: <105956984.FXDh2DO4ZE@diego> (raw)
In-Reply-To: <970b9e48-e38f-7e7a-3472-7dc5a4737e58@gmail.com>
Am Donnerstag, 2. April 2020, 15:48:02 CEST schrieb Johan Jonker:
> Hi Helen,
>
> > From: Helen Koike <helen.koike@collabora.com>
>
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> > index 33cc21fcf4c10..fc0295d2a65a1 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> > +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> > @@ -1394,6 +1394,17 @@ io_domains: io-domains {
> > status = "disabled";
> > };
> >
>
> > + mipi_dphy_rx0: mipi-dphy-rx0 {
>
> For Heiko sort syscon@ff770000 subnodes alphabetical or reg value first?
Similar to main nodes ... so things without reg alphabetical,
the rest by reg address
>
> > + compatible = "rockchip,rk3399-mipi-dphy-rx0";
> > + clocks = <&cru SCLK_MIPIDPHY_REF>,
>
> > + <&cru SCLK_DPHY_RX0_CFG>,
> > + <&cru PCLK_VIO_GRF>;
>
> Align ^
>
> > + clock-names = "dphy-ref", "dphy-cfg", "grf";
> > + power-domains = <&power RK3399_PD_VIO>;
> > + #phy-cells = <0>;
> > + status = "disabled";
> > + };
> > +
> > u2phy0: usb2-phy@e450 {
> > compatible = "rockchip,rk3399-usb2phy";
> > reg = <0xe450 0x10>;
>
>
WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: Johan Jonker <jbx6244@gmail.com>
Cc: devel@driverdev.osuosl.org, devicetree@vger.kernel.org,
dafna.hirschfeld@collabora.com, karthik.poduval@gmail.com,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
helen.koike@collabora.com, robh+dt@kernel.org,
hverkuil-cisco@xs4all.nl, mark.rutland@arm.com,
kernel@collabora.com, ezequiel@collabora.com,
linux-media@vger.kernel.org
Subject: Re: [PATCH 3/4] arm64: dts: rockchip: add rx0 mipi-phy for rk3399
Date: Thu, 02 Apr 2020 16:31:11 +0200 [thread overview]
Message-ID: <105956984.FXDh2DO4ZE@diego> (raw)
In-Reply-To: <970b9e48-e38f-7e7a-3472-7dc5a4737e58@gmail.com>
Am Donnerstag, 2. April 2020, 15:48:02 CEST schrieb Johan Jonker:
> Hi Helen,
>
> > From: Helen Koike <helen.koike@collabora.com>
>
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> > index 33cc21fcf4c10..fc0295d2a65a1 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> > +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> > @@ -1394,6 +1394,17 @@ io_domains: io-domains {
> > status = "disabled";
> > };
> >
>
> > + mipi_dphy_rx0: mipi-dphy-rx0 {
>
> For Heiko sort syscon@ff770000 subnodes alphabetical or reg value first?
Similar to main nodes ... so things without reg alphabetical,
the rest by reg address
>
> > + compatible = "rockchip,rk3399-mipi-dphy-rx0";
> > + clocks = <&cru SCLK_MIPIDPHY_REF>,
>
> > + <&cru SCLK_DPHY_RX0_CFG>,
> > + <&cru PCLK_VIO_GRF>;
>
> Align ^
>
> > + clock-names = "dphy-ref", "dphy-cfg", "grf";
> > + power-domains = <&power RK3399_PD_VIO>;
> > + #phy-cells = <0>;
> > + status = "disabled";
> > + };
> > +
> > u2phy0: usb2-phy@e450 {
> > compatible = "rockchip,rk3399-usb2phy";
> > reg = <0xe450 0x10>;
>
>
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2020-04-02 14:31 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-02 0:02 [PATCH 0/4] move Rockchip ISP bindings out of staging / add ISP DT nodes for RK3399 Helen Koike
2020-04-02 0:02 ` Helen Koike
2020-04-02 0:02 ` [PATCH 1/4] dt-bindings: phy: phy-rockchip-dphy-rx0: move rockchip dphy rx0 bindings out of staging Helen Koike
2020-04-02 0:02 ` Helen Koike
2020-04-02 0:02 ` Helen Koike
2020-04-02 12:16 ` Johan Jonker
2020-04-02 12:16 ` Johan Jonker
2020-04-02 14:42 ` Helen Koike
2020-04-02 14:42 ` Helen Koike
2020-04-02 16:17 ` Ezequiel Garcia
2020-04-02 16:17 ` Ezequiel Garcia
2020-04-03 13:00 ` Helen Koike
2020-04-03 13:00 ` Helen Koike
2020-04-03 13:00 ` Helen Koike
2020-04-02 0:02 ` [PATCH 2/4] dt-bindings: media: rkisp1: move rockchip-isp1 " Helen Koike
2020-04-02 0:02 ` Helen Koike
2020-04-02 11:35 ` Johan Jonker
2020-04-02 11:35 ` Johan Jonker
2020-04-02 11:35 ` Johan Jonker
2020-04-02 14:42 ` Helen Koike
2020-04-02 14:42 ` Helen Koike
2020-04-02 14:42 ` Helen Koike
2020-04-02 0:02 ` [PATCH 3/4] arm64: dts: rockchip: add rx0 mipi-phy for rk3399 Helen Koike
2020-04-02 0:02 ` Helen Koike
2020-04-02 13:48 ` Johan Jonker
2020-04-02 13:48 ` Johan Jonker
2020-04-02 13:48 ` Johan Jonker
2020-04-02 14:31 ` Heiko Stübner [this message]
2020-04-02 14:31 ` Heiko Stübner
2020-04-02 14:37 ` Johan Jonker
2020-04-02 14:37 ` Johan Jonker
2020-04-02 14:37 ` Johan Jonker
2020-04-02 14:49 ` Heiko Stübner
2020-04-02 14:49 ` Heiko Stübner
2020-04-02 14:43 ` Helen Koike
2020-04-02 14:43 ` Helen Koike
2020-04-02 0:02 ` [PATCH 4/4] arm64: dts: rockchip: add isp0 node " Helen Koike
2020-04-02 0:02 ` Helen Koike
2020-04-02 0:02 ` Helen Koike
2020-04-02 17:20 ` Johan Jonker
2020-04-02 17:20 ` Johan Jonker
2020-04-02 19:46 ` Helen Koike
2020-04-02 19:46 ` Helen Koike
2020-04-02 19:46 ` Helen Koike
2020-04-02 20:10 ` Johan Jonker
2020-04-02 20:10 ` Johan Jonker
2020-04-02 20:10 ` Johan Jonker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=105956984.FXDh2DO4ZE@diego \
--to=heiko@sntech.de \
--cc=dafna.hirschfeld@collabora.com \
--cc=devel@driverdev.osuosl.org \
--cc=devicetree@vger.kernel.org \
--cc=ezequiel@collabora.com \
--cc=helen.koike@collabora.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jbx6244@gmail.com \
--cc=karthik.poduval@gmail.com \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.