From: Daniel Lezcano <daniel.lezcano@linaro.org> To: Marek Szyprowski <m.szyprowski@samsung.com>, m.majewski2@samsung.com, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>, "linux-samsung-soc@vger.kernel.org" <linux-samsung-soc@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>, "Rafael J. Wysocki" <rafael@kernel.org>, Amit Kucheria <amitk@kernel.org>, Zhang Rui <rui.zhang@intel.com>, ALIM AKHTAR <alim.akhtar@samsung.com>, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org> Subject: Re: [PATCH v2 4/7] thermal: exynos: simplify regulator (de)initialization Date: Fri, 29 Sep 2023 13:45:07 +0200 [thread overview] Message-ID: <10e6377e-ab3f-c318-9860-56ff3b8aed92@linaro.org> (raw) In-Reply-To: <a6f943be-a92f-f9ec-4103-7edc70a2c9a8@samsung.com> On 29/09/2023 13:03, Marek Szyprowski wrote: > On 29.09.2023 12:46, Daniel Lezcano wrote: >> On 26/09/2023 13:02, Mateusz Majewski wrote: >>> Hi, >>> >>>> This is not equivalent. If regulator is provided and enable fails, the >>>> old code is nicely returning error. Now, it will print misleading >>>> message - failed to get regulator - and continue. >>>> >>>> While this simplifies the code, it ignores important running >>>> condition - >>>> having regulator enabled. >>> >>> Would doing this be correct? >>> >>> ret = devm_regulator_get_enable_optional(&pdev->dev, "vtmu"); >>> switch (ret) { >>> case 0: >>> case -ENODEV: >> >> Not sure to understand why -NODEV is not an error > > > Because this what devm_regulator_get_enable_optional() returns if no > regulator is defined. I also got confused by this a few times. The code before this change calls devm_regulator_get_optional() which returns -ENODEV too, right ? But there is no special case for this error. So this change uses devm_regulator_get_enable_optional() and handle the ENODEV as a non-error, so there is a change in the behavior. >>> break; >>> case -EPROBE_DEFER: >>> return -EPROBE_DEFER; >>> default: >>> dev_err(&pdev->dev, "Failed to get enabled regulator: %d\n", >>> ret); >>> return ret; >>> } >> >> ret = devm_regulator_get_enable_optional(&pdev->dev, "vtmu"); >> if (ret < 0) { >> if (ret != EPROBE_DEFER) >> dev_err(&pdev->dev, "Failed to get enabled regulator: %d\n", >> ret); >> return ret; >> } >> >> ?? >> > Best regards -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Lezcano <daniel.lezcano@linaro.org> To: Marek Szyprowski <m.szyprowski@samsung.com>, m.majewski2@samsung.com, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>, "linux-samsung-soc@vger.kernel.org" <linux-samsung-soc@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>, "Rafael J. Wysocki" <rafael@kernel.org>, Amit Kucheria <amitk@kernel.org>, Zhang Rui <rui.zhang@intel.com>, ALIM AKHTAR <alim.akhtar@samsung.com>, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org> Subject: Re: [PATCH v2 4/7] thermal: exynos: simplify regulator (de)initialization Date: Fri, 29 Sep 2023 13:45:07 +0200 [thread overview] Message-ID: <10e6377e-ab3f-c318-9860-56ff3b8aed92@linaro.org> (raw) In-Reply-To: <a6f943be-a92f-f9ec-4103-7edc70a2c9a8@samsung.com> On 29/09/2023 13:03, Marek Szyprowski wrote: > On 29.09.2023 12:46, Daniel Lezcano wrote: >> On 26/09/2023 13:02, Mateusz Majewski wrote: >>> Hi, >>> >>>> This is not equivalent. If regulator is provided and enable fails, the >>>> old code is nicely returning error. Now, it will print misleading >>>> message - failed to get regulator - and continue. >>>> >>>> While this simplifies the code, it ignores important running >>>> condition - >>>> having regulator enabled. >>> >>> Would doing this be correct? >>> >>> ret = devm_regulator_get_enable_optional(&pdev->dev, "vtmu"); >>> switch (ret) { >>> case 0: >>> case -ENODEV: >> >> Not sure to understand why -NODEV is not an error > > > Because this what devm_regulator_get_enable_optional() returns if no > regulator is defined. I also got confused by this a few times. The code before this change calls devm_regulator_get_optional() which returns -ENODEV too, right ? But there is no special case for this error. So this change uses devm_regulator_get_enable_optional() and handle the ENODEV as a non-error, so there is a change in the behavior. >>> break; >>> case -EPROBE_DEFER: >>> return -EPROBE_DEFER; >>> default: >>> dev_err(&pdev->dev, "Failed to get enabled regulator: %d\n", >>> ret); >>> return ret; >>> } >> >> ret = devm_regulator_get_enable_optional(&pdev->dev, "vtmu"); >> if (ret < 0) { >> if (ret != EPROBE_DEFER) >> dev_err(&pdev->dev, "Failed to get enabled regulator: %d\n", >> ret); >> return ret; >> } >> >> ?? >> > Best regards -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-09-29 11:45 UTC|newest] Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <CGME20230911133607eucas1p2c9a5b6c3bd785a5d03d78a1db872b188@eucas1p2.samsung.com> 2023-09-11 13:34 ` [PATCH v2 0/7] Improve Exynos thermal driver Mateusz Majewski 2023-09-11 13:34 ` Mateusz Majewski [not found] ` <CGME20230911133611eucas1p286e43809a6ca785911c0bbdce15dc15d@eucas1p2.samsung.com> 2023-09-11 13:34 ` [PATCH v2 1/7] thermal: exynos: remove an unnecessary field description Mateusz Majewski 2023-09-11 13:34 ` Mateusz Majewski 2023-09-13 8:00 ` Krzysztof Kozlowski 2023-09-13 8:00 ` Krzysztof Kozlowski [not found] ` <CGME20230911133613eucas1p1671b7d154e1d567b02516d8c4d8074ab@eucas1p1.samsung.com> 2023-09-11 13:34 ` [PATCH v2 2/7] thermal: exynos: drop id field Mateusz Majewski 2023-09-11 13:34 ` Mateusz Majewski [not found] ` <CGME20230911133615eucas1p123b3bed5bfa998bda65196d425f9b49d@eucas1p1.samsung.com> 2023-09-11 13:34 ` [PATCH v2 3/7] thermal: exynos: switch from workqueue-driven interrupt handling to threaded interrupts Mateusz Majewski 2023-09-11 13:34 ` Mateusz Majewski 2023-09-13 8:03 ` Krzysztof Kozlowski 2023-09-13 8:03 ` Krzysztof Kozlowski [not found] ` <CGME20230911133616eucas1p10c5eeb0f0240dde975ccc5935cb5c311@eucas1p1.samsung.com> 2023-09-11 13:34 ` [PATCH v2 4/7] thermal: exynos: simplify regulator (de)initialization Mateusz Majewski 2023-09-11 13:34 ` Mateusz Majewski 2023-09-13 8:11 ` Krzysztof Kozlowski 2023-09-13 8:11 ` Krzysztof Kozlowski [not found] ` <CGME20230911133616eucas1p10c5eeb0f0240dde975ccc5935cb5c311@eucms1p2> 2023-09-26 11:02 ` Mateusz Majewski 2023-09-26 11:02 ` Mateusz Majewski 2023-09-29 10:46 ` Daniel Lezcano 2023-09-29 10:46 ` Daniel Lezcano 2023-09-29 11:03 ` Marek Szyprowski 2023-09-29 11:03 ` Marek Szyprowski 2023-09-29 11:45 ` Daniel Lezcano [this message] 2023-09-29 11:45 ` Daniel Lezcano 2023-09-29 12:00 ` Marek Szyprowski 2023-09-29 12:00 ` Marek Szyprowski 2023-10-03 9:06 ` Krzysztof Kozlowski 2023-10-03 9:06 ` Krzysztof Kozlowski [not found] ` <CGME20230911133618eucas1p2d40b075ee6baebbec9f991eb01f21d89@eucas1p2.samsung.com> 2023-09-11 13:34 ` [PATCH v2 5/7] thermal: exynos: stop using the threshold mechanism on Exynos 4210 Mateusz Majewski 2023-09-11 13:34 ` Mateusz Majewski [not found] ` <CGME20230911133620eucas1p27a0d0f480638c97fa59bf9c4f34a02cb@eucas1p2.samsung.com> 2023-09-11 13:34 ` [PATCH v2 6/7] thermal: exynos: split initialization of TMU and the thermal zone Mateusz Majewski 2023-09-11 13:34 ` Mateusz Majewski [not found] ` <CGME20230911133622eucas1p2d27118647d37fa2fe2973773f70359c4@eucas1p2.samsung.com> 2023-09-11 13:34 ` [PATCH v2 7/7] thermal: exynos: use set_trips Mateusz Majewski 2023-09-11 13:34 ` Mateusz Majewski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=10e6377e-ab3f-c318-9860-56ff3b8aed92@linaro.org \ --to=daniel.lezcano@linaro.org \ --cc=alim.akhtar@samsung.com \ --cc=amitk@kernel.org \ --cc=broonie@kernel.org \ --cc=bzolnier@gmail.com \ --cc=krzysztof.kozlowski@linaro.org \ --cc=lgirdwood@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=m.majewski2@samsung.com \ --cc=m.szyprowski@samsung.com \ --cc=rafael@kernel.org \ --cc=rui.zhang@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.