All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josef Bacik <josef@toxicpanda.com>
To: Xie Yongji <xieyongji@bytedance.com>, axboe@kernel.dk
Cc: jiangyadong@bytedance.com, linux-block@vger.kernel.org,
	nbd@other.debian.org
Subject: Re: [PATCH RESEND] nbd: Aovid double completion of a request
Date: Fri, 13 Aug 2021 11:45:04 -0400	[thread overview]
Message-ID: <10f5ac3e-4420-2635-1edc-7beca28e9619@toxicpanda.com> (raw)
In-Reply-To: <20210813151330.96-1-xieyongji@bytedance.com>

On 8/13/21 11:13 AM, Xie Yongji wrote:
> There is a race between iterating over requests in
> nbd_clear_que() and completing requests in recv_work(),
> which can lead to double completion of a request.
> 
> To fix it, flush the recv worker before iterating over
> the requests and don't abort the completed request
> while iterating.
> 
> Fixes: 96d97e17828f ("nbd: clear_sock on netlink disconnect")
> Reported-by: Jiang Yadong <jiangyadong@bytedance.com>
> Signed-off-by: Xie Yongji <xieyongji@bytedance.com>

Thanks for resending this, my email client messed up.

Reviewed-by: Josef Bacik <josef@toxicpanda.com>

Josef

  reply	other threads:[~2021-08-13 15:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-13 15:13 [PATCH RESEND] nbd: Aovid double completion of a request Xie Yongji
2021-08-13 15:45 ` Josef Bacik [this message]
2021-08-13 15:47 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=10f5ac3e-4420-2635-1edc-7beca28e9619@toxicpanda.com \
    --to=josef@toxicpanda.com \
    --cc=axboe@kernel.dk \
    --cc=jiangyadong@bytedance.com \
    --cc=linux-block@vger.kernel.org \
    --cc=nbd@other.debian.org \
    --cc=xieyongji@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.