From: Jens Axboe <axboe@kernel.dk>
To: Xie Yongji <xieyongji@bytedance.com>, josef@toxicpanda.com
Cc: jiangyadong@bytedance.com, linux-block@vger.kernel.org,
nbd@other.debian.org
Subject: Re: [PATCH RESEND] nbd: Aovid double completion of a request
Date: Fri, 13 Aug 2021 09:47:28 -0600 [thread overview]
Message-ID: <2b10e7bd-f00f-33de-5e53-38947b270fe3@kernel.dk> (raw)
In-Reply-To: <20210813151330.96-1-xieyongji@bytedance.com>
On 8/13/21 9:13 AM, Xie Yongji wrote:
> There is a race between iterating over requests in
> nbd_clear_que() and completing requests in recv_work(),
> which can lead to double completion of a request.
>
> To fix it, flush the recv worker before iterating over
> the requests and don't abort the completed request
> while iterating.
Applied, thanks.
--
Jens Axboe
prev parent reply other threads:[~2021-08-13 15:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-13 15:13 [PATCH RESEND] nbd: Aovid double completion of a request Xie Yongji
2021-08-13 15:45 ` Josef Bacik
2021-08-13 15:47 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b10e7bd-f00f-33de-5e53-38947b270fe3@kernel.dk \
--to=axboe@kernel.dk \
--cc=jiangyadong@bytedance.com \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=nbd@other.debian.org \
--cc=xieyongji@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.