From: Neil Armstrong <narmstrong@baylibre.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Artem Lapkin <email2tema@gmail.com>
Cc: khilman@baylibre.com, robh+dt@kernel.org, jbrunet@baylibre.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
art@khadas.com, nick@khadas.com, gouwa@khadas.com
Subject: Re: [PATCH 1/8] arm64: dts: meson: update spifc node on Khadas VIM2 meson-gxm-khadas-vim2
Date: Mon, 28 Sep 2020 09:54:12 +0200 [thread overview]
Message-ID: <10f7b5fd-a86c-c705-fb3e-5bc6c998ab2c@baylibre.com> (raw)
In-Reply-To: <CAFBinCDcwHUJzK4HsvKxs1n4_jH9K47bNZcZobocLxKVj7+iNw@mail.gmail.com>
On 25/09/2020 09:51, Martin Blumenstingl wrote:
> Hi Artem,
>
> On Fri, Sep 25, 2020 at 5:30 AM Artem Lapkin <email2tema@gmail.com> wrote:
>>
>> 1) The VIM2 Boards use w25q128 spi chip only not w25q32 or w25q16
>> it's not really seriously becouse have 'jedec,spi-nor' which
>> have auto chips identifications
> according to the "VIM2 - Transitioning From v1.2 to v1.4" document [0]
> (page 7) both board revisions are using different SPI flash sizes
> for which board revision are your changes?
Indeed, if you changed the flash for the v14 VIM2 board, please:
- move arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts into meson-gxm-khadas-vim2.dtsi leaving only the
root compatible, model and the v12 spi flash model&size into the meson-gxm-khadas-vim2.dts file
- add "khadas,vim2-v14" to amlogic board bindings
- introduce a arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2-v14.dts file adding the
changes (spi flash change, MCU) with a different root compatible & model
Neil
>
>> 2) max-frequency is 104Mhz
> (note to self: according to the w25q16 datasheet it supports a maximum
> clock frequency of 104MHz, so this is fine)
>
>
> Best regards,
> Martin
>
WARNING: multiple messages have this Message-ID (diff)
From: Neil Armstrong <narmstrong@baylibre.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Artem Lapkin <email2tema@gmail.com>
Cc: devicetree@vger.kernel.org, gouwa@khadas.com,
khilman@baylibre.com, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, nick@khadas.com,
linux-amlogic@lists.infradead.org, art@khadas.com,
linux-arm-kernel@lists.infradead.org, jbrunet@baylibre.com
Subject: Re: [PATCH 1/8] arm64: dts: meson: update spifc node on Khadas VIM2 meson-gxm-khadas-vim2
Date: Mon, 28 Sep 2020 09:54:12 +0200 [thread overview]
Message-ID: <10f7b5fd-a86c-c705-fb3e-5bc6c998ab2c@baylibre.com> (raw)
In-Reply-To: <CAFBinCDcwHUJzK4HsvKxs1n4_jH9K47bNZcZobocLxKVj7+iNw@mail.gmail.com>
On 25/09/2020 09:51, Martin Blumenstingl wrote:
> Hi Artem,
>
> On Fri, Sep 25, 2020 at 5:30 AM Artem Lapkin <email2tema@gmail.com> wrote:
>>
>> 1) The VIM2 Boards use w25q128 spi chip only not w25q32 or w25q16
>> it's not really seriously becouse have 'jedec,spi-nor' which
>> have auto chips identifications
> according to the "VIM2 - Transitioning From v1.2 to v1.4" document [0]
> (page 7) both board revisions are using different SPI flash sizes
> for which board revision are your changes?
Indeed, if you changed the flash for the v14 VIM2 board, please:
- move arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts into meson-gxm-khadas-vim2.dtsi leaving only the
root compatible, model and the v12 spi flash model&size into the meson-gxm-khadas-vim2.dts file
- add "khadas,vim2-v14" to amlogic board bindings
- introduce a arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2-v14.dts file adding the
changes (spi flash change, MCU) with a different root compatible & model
Neil
>
>> 2) max-frequency is 104Mhz
> (note to self: according to the w25q16 datasheet it supports a maximum
> clock frequency of 104MHz, so this is fine)
>
>
> Best regards,
> Martin
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Neil Armstrong <narmstrong@baylibre.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Artem Lapkin <email2tema@gmail.com>
Cc: devicetree@vger.kernel.org, gouwa@khadas.com,
khilman@baylibre.com, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, nick@khadas.com,
linux-amlogic@lists.infradead.org, art@khadas.com,
linux-arm-kernel@lists.infradead.org, jbrunet@baylibre.com
Subject: Re: [PATCH 1/8] arm64: dts: meson: update spifc node on Khadas VIM2 meson-gxm-khadas-vim2
Date: Mon, 28 Sep 2020 09:54:12 +0200 [thread overview]
Message-ID: <10f7b5fd-a86c-c705-fb3e-5bc6c998ab2c@baylibre.com> (raw)
In-Reply-To: <CAFBinCDcwHUJzK4HsvKxs1n4_jH9K47bNZcZobocLxKVj7+iNw@mail.gmail.com>
On 25/09/2020 09:51, Martin Blumenstingl wrote:
> Hi Artem,
>
> On Fri, Sep 25, 2020 at 5:30 AM Artem Lapkin <email2tema@gmail.com> wrote:
>>
>> 1) The VIM2 Boards use w25q128 spi chip only not w25q32 or w25q16
>> it's not really seriously becouse have 'jedec,spi-nor' which
>> have auto chips identifications
> according to the "VIM2 - Transitioning From v1.2 to v1.4" document [0]
> (page 7) both board revisions are using different SPI flash sizes
> for which board revision are your changes?
Indeed, if you changed the flash for the v14 VIM2 board, please:
- move arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts into meson-gxm-khadas-vim2.dtsi leaving only the
root compatible, model and the v12 spi flash model&size into the meson-gxm-khadas-vim2.dts file
- add "khadas,vim2-v14" to amlogic board bindings
- introduce a arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2-v14.dts file adding the
changes (spi flash change, MCU) with a different root compatible & model
Neil
>
>> 2) max-frequency is 104Mhz
> (note to self: according to the w25q16 datasheet it supports a maximum
> clock frequency of 104MHz, so this is fine)
>
>
> Best regards,
> Martin
>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2020-09-28 7:54 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 3:30 [PATCH 0/8] dts updates and fixes for Khadas VIM1 VIM2 VIM3 VIML boards Artem Lapkin
2020-09-25 3:30 ` Artem Lapkin
2020-09-25 3:30 ` Artem Lapkin
2020-09-25 3:30 ` [PATCH 1/8] arm64: dts: meson: update spifc node on Khadas VIM2 meson-gxm-khadas-vim2 Artem Lapkin
2020-09-25 3:30 ` Artem Lapkin
2020-09-25 3:30 ` Artem Lapkin
2020-09-25 7:41 ` Neil Armstrong
2020-09-25 7:41 ` Neil Armstrong
2020-09-25 7:41 ` Neil Armstrong
2020-09-25 7:51 ` Martin Blumenstingl
2020-09-25 7:51 ` Martin Blumenstingl
2020-09-25 7:51 ` Martin Blumenstingl
2020-09-28 7:54 ` Neil Armstrong [this message]
2020-09-28 7:54 ` Neil Armstrong
2020-09-28 7:54 ` Neil Armstrong
2020-09-25 3:30 ` [PATCH 2/8] arm64: dts: meson: update leds node on Khadas VIM3/VIM3L boards meson-khadas-vim3 Artem Lapkin
2020-09-25 3:30 ` Artem Lapkin
2020-09-25 3:30 ` Artem Lapkin
2020-09-25 7:36 ` Neil Armstrong
2020-09-25 7:36 ` Neil Armstrong
2020-09-25 7:36 ` Neil Armstrong
2020-09-25 3:30 ` [PATCH 3/8] arm64: dts: meson: update leds node on Khadas VIM3/VIM3L board meson-khadas-vim3 Artem Lapkin
2020-09-25 3:30 ` Artem Lapkin
2020-09-25 3:30 ` Artem Lapkin
2020-09-25 7:39 ` Neil Armstrong
2020-09-25 7:39 ` Neil Armstrong
2020-09-25 7:39 ` Neil Armstrong
2020-09-25 3:30 ` [PATCH 4/8] arm64: dts: meson: remove fixed memory size for Khadas VIM3/VIM3L meson-khadas-vim3 Artem Lapkin
2020-09-25 3:30 ` Artem Lapkin
2020-09-25 3:30 ` Artem Lapkin
2020-09-25 7:37 ` Martin Blumenstingl
2020-09-25 7:37 ` Martin Blumenstingl
2020-09-25 7:37 ` Martin Blumenstingl
2020-09-25 7:40 ` Neil Armstrong
2020-09-25 7:40 ` Neil Armstrong
2020-09-25 7:40 ` Neil Armstrong
2020-09-25 3:30 ` [PATCH 5/8] arm64: dts: meson: remove reset-gpios from ethernet node for VIM2 meson-gxm-khadas-vim2 Artem Lapkin
2020-09-25 3:30 ` Artem Lapkin
2020-09-25 3:30 ` Artem Lapkin
2020-09-25 7:41 ` Martin Blumenstingl
2020-09-25 7:41 ` Martin Blumenstingl
2020-09-25 7:41 ` Martin Blumenstingl
[not found] ` <CAKaHn9+CWLJYN1Tt46VxBGNBEbVVJZWeL6ZJSf9w-5DmoxrvgQ@mail.gmail.com>
2020-09-25 8:04 ` Martin Blumenstingl
2020-09-25 8:04 ` Martin Blumenstingl
2020-09-25 8:04 ` Martin Blumenstingl
[not found] ` <CAKaHn9K6O8u6Br84S63V0PDFBhiRbMdd4-bvC5FxFe6izj_Dvg@mail.gmail.com>
2020-09-25 11:26 ` Martin Blumenstingl
2020-09-25 11:26 ` Martin Blumenstingl
2020-09-25 11:26 ` Martin Blumenstingl
[not found] ` <CAKaHn9JxKBKW5AYvUNBAA+sNcHfNQNrx95NtLMnrfd0ypOaAoA@mail.gmail.com>
2020-09-28 20:41 ` Martin Blumenstingl
2020-09-28 20:41 ` Martin Blumenstingl
2020-09-28 20:41 ` Martin Blumenstingl
2020-09-25 3:30 ` [PATCH 6/8] arm64: dts: meson: disable vrtc for VIM3L boards meson-khadas-vim3 Artem Lapkin
2020-09-25 3:30 ` Artem Lapkin
2020-09-25 3:30 ` Artem Lapkin
2020-09-25 7:44 ` Neil Armstrong
2020-09-25 7:44 ` Neil Armstrong
2020-09-25 7:44 ` Neil Armstrong
2020-09-25 3:30 ` [PATCH 7/8] arm64: dts: meson: enable RTC for VIM1 meson-gxl-s905x-khadas-vim Artem Lapkin
2020-09-25 3:30 ` Artem Lapkin
2020-09-25 3:30 ` Artem Lapkin
2020-09-25 7:31 ` Martin Blumenstingl
2020-09-25 7:31 ` Martin Blumenstingl
2020-09-25 7:31 ` Martin Blumenstingl
2020-09-25 3:30 ` [PATCH 8/8] arm64: dts: meson: enable RTC for VIM2 meson-gxm-khadas-vim2 Artem Lapkin
2020-09-25 3:30 ` Artem Lapkin
2020-09-25 3:30 ` Artem Lapkin
2020-09-25 8:58 ` Jerome Brunet
2020-09-25 8:58 ` Jerome Brunet
2020-09-25 8:58 ` Jerome Brunet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10f7b5fd-a86c-c705-fb3e-5bc6c998ab2c@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=art@khadas.com \
--cc=devicetree@vger.kernel.org \
--cc=email2tema@gmail.com \
--cc=gouwa@khadas.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=nick@khadas.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.