From: David Howells <dhowells@redhat.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: dhowells@redhat.com, Xu Wang <vulab@iscas.ac.cn>,
dwmw2@infradead.org, keyrings@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scrpits: Remove unneeded assignment parentheses
Date: Thu, 21 May 2020 14:28:35 +0000 [thread overview]
Message-ID: <116524.1590071315@warthog.procyon.org.uk> (raw)
In-Reply-To: <1590070442.4669.12.camel@HansenPartnership.com>
James Bottomley <James.Bottomley@HansenPartnership.com> wrote:
> > Remove unneeded assignment parentheses.
>
> I really don't think this is a good idea. Best practice for macros is
> to parenthesize every argument even if there are technically some cases
> where it's unnecessary because the problems in the majority cases are
> huge and unexpected.
Yep.
David
WARNING: multiple messages have this Message-ID (diff)
From: David Howells <dhowells@redhat.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: dhowells@redhat.com, Xu Wang <vulab@iscas.ac.cn>,
dwmw2@infradead.org, keyrings@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scrpits: Remove unneeded assignment parentheses
Date: Thu, 21 May 2020 15:28:35 +0100 [thread overview]
Message-ID: <116524.1590071315@warthog.procyon.org.uk> (raw)
In-Reply-To: <1590070442.4669.12.camel@HansenPartnership.com>
James Bottomley <James.Bottomley@HansenPartnership.com> wrote:
> > Remove unneeded assignment parentheses.
>
> I really don't think this is a good idea. Best practice for macros is
> to parenthesize every argument even if there are technically some cases
> where it's unnecessary because the problems in the majority cases are
> huge and unexpected.
Yep.
David
next prev parent reply other threads:[~2020-05-21 14:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-21 6:32 [PATCH] scrpits: Remove unneeded assignment parentheses Xu Wang
2020-05-21 14:14 ` James Bottomley
2020-05-21 14:14 ` James Bottomley
2020-05-21 14:28 ` David Howells [this message]
2020-05-21 14:28 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=116524.1590071315@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=dwmw2@infradead.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.