From: "kanchan" <joshi.k@samsung.com>
To: "'Martin K. Petersen'" <martin.petersen@oracle.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-block@vger.kernel.org>,
<linux-nvme@lists.infradead.org>, <linux-fsdevel@vger.kernel.org>,
<linux-ext4@vger.kernel.org>, <axboe@fb.com>,
<prakash.v@samsung.com>, <anshul@samsung.com>,
<joshiiitr@gmail.com>
Subject: RE: [PATCH v3 7/7] fs/ext4,jbd2: add support for passing write-hint with journal
Date: Wed, 3 Apr 2019 19:12:00 +0530 [thread overview]
Message-ID: <11cd01d4ea23$1bb6b260$53241720$@samsung.com> (raw)
In-Reply-To: <yq14l7fokx0.fsf@oracle.com>
Hi Martin,
> Why not just introduce REQ_JOURNAL and let the device driver decide how to
turn that into something appropriate for the device?
It began with that kind of thought/goal i.e. introduce something just for
FS journal. But it seems to have evolved for good.
Current approach extends write-hint infra so that whole thing becomes
extensible for other kind of use-cases (than FS journal) as well.
Also in this approach, driver will do little, while block-layer will do
majority of the work.
> That's what I'll need for SCSI. Existing SCSI streams are not a good fit.
Do you see that it's difficult for SCSI to use write-hint infrastructure for
streams?
-----Original Message-----
From: Martin K. Petersen [mailto:martin.petersen@oracle.com]
Sent: Wednesday, April 03, 2019 8:28 AM
To: Kanchan Joshi <joshi.k@samsung.com>
Cc: linux-kernel@vger.kernel.org; linux-block@vger.kernel.org;
linux-nvme@lists.infradead.org; linux-fsdevel@vger.kernel.org;
linux-ext4@vger.kernel.org; axboe@fb.com; prakash.v@samsung.com;
anshul@samsung.com; joshiiitr@gmail.com
Subject: Re: [PATCH v3 7/7] fs/ext4,jbd2: add support for passing write-hint
with journal
Kanchan,
> For NAND based SSDs, mixing of data with different life-time reduces
> efficiency of internal garbage-collection. During FS operations,
> series of journal updates will follow/precede series of data/meta
> updates, causing intermixing inside SSD. By passing a write-hint with
> journal, its write can be isolated from other data/meta writes,
> leading to endurance/performance benefit on SSD.
Why not just introduce REQ_JOURNAL and let the device driver decide how to
turn that into something appropriate for the device?
That's what I'll need for SCSI. Existing SCSI streams are not a good fit.
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: joshi.k@samsung.com (kanchan)
Subject: [PATCH v3 7/7] fs/ext4,jbd2: add support for passing write-hint with journal
Date: Wed, 3 Apr 2019 19:12:00 +0530 [thread overview]
Message-ID: <11cd01d4ea23$1bb6b260$53241720$@samsung.com> (raw)
In-Reply-To: <yq14l7fokx0.fsf@oracle.com>
Hi Martin,
> Why not just introduce REQ_JOURNAL and let the device driver decide how to
turn that into something appropriate for the device?
It began with that kind of thought/goal i.e. introduce something just for
FS journal. But it seems to have evolved for good.
Current approach extends write-hint infra so that whole thing becomes
extensible for other kind of use-cases (than FS journal) as well.
Also in this approach, driver will do little, while block-layer will do
majority of the work.
> That's what I'll need for SCSI. Existing SCSI streams are not a good fit.
Do you see that it's difficult for SCSI to use write-hint infrastructure for
streams?
-----Original Message-----
From: Martin K. Petersen [mailto:martin.petersen@oracle.com]
Sent: Wednesday, April 03, 2019 8:28 AM
To: Kanchan Joshi <joshi.k at samsung.com>
Cc: linux-kernel at vger.kernel.org; linux-block at vger.kernel.org;
linux-nvme at lists.infradead.org; linux-fsdevel at vger.kernel.org;
linux-ext4 at vger.kernel.org; axboe at fb.com; prakash.v at samsung.com;
anshul at samsung.com; joshiiitr at gmail.com
Subject: Re: [PATCH v3 7/7] fs/ext4,jbd2: add support for passing write-hint
with journal
Kanchan,
> For NAND based SSDs, mixing of data with different life-time reduces
> efficiency of internal garbage-collection. During FS operations,
> series of journal updates will follow/precede series of data/meta
> updates, causing intermixing inside SSD. By passing a write-hint with
> journal, its write can be isolated from other data/meta writes,
> leading to endurance/performance benefit on SSD.
Why not just introduce REQ_JOURNAL and let the device driver decide how to
turn that into something appropriate for the device?
That's what I'll need for SCSI. Existing SCSI streams are not a good fit.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2019-04-03 13:42 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190329075737epcas1p4f32cad26279c1146982a6c91b3378eab@epcas1p4.samsung.com>
2019-03-29 7:53 ` [PATCH v3 0/7] Extend write-hint for in-kernel use Kanchan Joshi
2019-03-29 7:53 ` Kanchan Joshi
[not found] ` <CGME20190329075743epcas1p12f1d290e65ddf84eb74ed94a5ae6eb74@epcas1p1.samsung.com>
2019-03-29 7:53 ` [PATCH v3 1/7] block: extend stream count " Kanchan Joshi
2019-03-29 7:53 ` Kanchan Joshi
2019-03-30 17:48 ` Andreas Dilger
2019-03-30 17:48 ` Andreas Dilger
2019-04-01 5:02 ` Dave Chinner
2019-04-01 5:02 ` Dave Chinner
[not found] ` <CGME20190329075746epcas1p19e5a93c1f593b5fed3f98eddf9159aa5@epcas1p1.samsung.com>
2019-03-29 7:53 ` [PATCH v3 2/7] block: introduce API to register stream information with block layer Kanchan Joshi
2019-03-29 7:53 ` Kanchan Joshi
[not found] ` <CGME20190329075749epcas2p22b85cbdbb7ccb4f7f3ecf69b84f75dc9@epcas2p2.samsung.com>
2019-03-29 7:53 ` [PATCH v3 3/7] block: add write-hint to stream-id conversion Kanchan Joshi
2019-03-29 7:53 ` Kanchan Joshi
2019-04-01 5:08 ` Dave Chinner
2019-04-01 5:08 ` Dave Chinner
2019-04-02 9:20 ` Jan Kara
2019-04-02 9:20 ` Jan Kara
2019-04-02 20:35 ` Dave Chinner
2019-04-02 20:35 ` Dave Chinner
2019-04-03 9:36 ` Jan Kara
2019-04-03 9:36 ` Jan Kara
2019-04-03 14:47 ` kanchan
2019-04-03 14:47 ` kanchan
[not found] ` <CGME20190329075753epcas1p16ce37362f83ccb8520a782b845dcb905@epcas1p1.samsung.com>
2019-03-29 7:53 ` [PATCH v3 4/7] nvme: register stream info with block layer Kanchan Joshi
2019-03-29 7:53 ` Kanchan Joshi
2019-03-29 16:58 ` Heitke, Kenneth
2019-03-29 16:58 ` Heitke, Kenneth
[not found] ` <CGME20190329075755epcas2p2d2670db217ae3519d2c4b93d5e3749d1@epcas2p2.samsung.com>
2019-03-29 7:53 ` [PATCH v3 5/7] fs: introduce APIs to enable sending write-hint with buffer-head Kanchan Joshi
2019-03-29 7:53 ` Kanchan Joshi
[not found] ` <CGME20190329075758epcas1p335511dcb10bb5592ea72409a1d01e752@epcas1p3.samsung.com>
2019-03-29 7:53 ` [PATCH v3 6/7] fs: introduce write-hint start point for in-kernel hints Kanchan Joshi
2019-03-29 7:53 ` Kanchan Joshi
2019-04-01 5:12 ` Dave Chinner
2019-04-01 5:12 ` Dave Chinner
2019-04-03 14:30 ` kanchan
2019-04-03 14:30 ` kanchan
[not found] ` <CGME20190329075800epcas2p4731f10eabf7d70dc7096117d161b05a3@epcas2p4.samsung.com>
2019-03-29 7:53 ` [PATCH v3 7/7] fs/ext4,jbd2: add support for passing write-hint with journal Kanchan Joshi
2019-03-29 7:53 ` Kanchan Joshi
2019-03-30 17:49 ` Andreas Dilger
2019-03-30 17:49 ` Andreas Dilger
2019-04-02 9:07 ` Jan Kara
2019-04-02 9:07 ` Jan Kara
2019-04-03 2:57 ` Martin K. Petersen
2019-04-03 2:57 ` [PATCH v3 7/7] fs/ext4, jbd2: " Martin K. Petersen
2019-04-03 13:42 ` kanchan [this message]
2019-04-03 13:42 ` [PATCH v3 7/7] fs/ext4,jbd2: " kanchan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='11cd01d4ea23$1bb6b260$53241720$@samsung.com' \
--to=joshi.k@samsung.com \
--cc=anshul@samsung.com \
--cc=axboe@fb.com \
--cc=joshiiitr@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=martin.petersen@oracle.com \
--cc=prakash.v@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.