Re: [RESEND 2/6 v2] media: uapi: Document format MEDIA_BUS_FMT_RGB565_1X24_CPADHI

From: Hans Verkuil <hverkuil@xs4all.nl>
To: Chris Morgan <macroalpha82@gmail.com>, dri-devel@lists.freedesktop.org
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	thierry.reding@gmail.com, sam@ravnborg.org, airlied@linux.ie,
	daniel@ffwll.ch, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, mchehab@kernel.org,
	emma@anholt.net, mripard@kernel.org,
	Chris Morgan <macromorgan@hotmail.com>
Subject: Re: [RESEND 2/6 v2] media: uapi: Document format MEDIA_BUS_FMT_RGB565_1X24_CPADHI
Date: Thu, 24 Nov 2022 16:11:13 +0100	[thread overview]
Message-ID: <11e1c489-85d8-82e2-8334-c47265a587f2@xs4all.nl> (raw)
In-Reply-To: <20220519162935.1585-3-macroalpha82@gmail.com>

On 19/05/2022 18:29, Chris Morgan wrote:
> From: Chris Morgan <macromorgan@hotmail.com>
> 
> Add support for MEDIA_BUS_FMT_RGB565_1X24_CPADHI. This format is used
> by the Geekworm MZP280 panel which interfaces with the Raspberry Pi.
> 
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> ---
>  .../media/v4l/subdev-formats.rst              | 37 +++++++++++++++++++
>  1 file changed, 37 insertions(+)
> 
> diff --git a/Documentation/userspace-api/media/v4l/subdev-formats.rst b/Documentation/userspace-api/media/v4l/subdev-formats.rst
> index 0cbc045d5..e43e07634 100644
> --- a/Documentation/userspace-api/media/v4l/subdev-formats.rst
> +++ b/Documentation/userspace-api/media/v4l/subdev-formats.rst
> @@ -624,6 +624,43 @@ The following tables list existing packed RGB formats.
>        - b\ :sub:`2`
>        - b\ :sub:`1`
>        - b\ :sub:`0`
> +    * .. _MEDIA_BUS_FMT_RGB565_1X24_CPADHI:
> +
> +      - MEDIA_BUS_FMT_RGB565_1X24_CPADHI
> +      - 0x101e

Given the latest media tree this is now 0x1022.

Otherwise:

Acked-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>

It's an old series by now, but as far as I am concerned this can go through
the drm subsystem (after updating this value).

Regards,

	Hans

> +      -
> +      -
> +      -
> +      -
> +      -
> +      -
> +      -
> +      -
> +      -
> +      - 0
> +      - 0
> +      - 0
> +      - r\ :sub:`4`
> +      - r\ :sub:`3`
> +      - r\ :sub:`2`
> +      - r\ :sub:`1`
> +      - r\ :sub:`0`
> +      - 0
> +      - 0
> +      - g\ :sub:`5`
> +      - g\ :sub:`4`
> +      - g\ :sub:`3`
> +      - g\ :sub:`2`
> +      - g\ :sub:`1`
> +      - g\ :sub:`0`
> +      - 0
> +      - 0
> +      - 0
> +      - b\ :sub:`4`
> +      - b\ :sub:`3`
> +      - b\ :sub:`2`
> +      - b\ :sub:`1`
> +      - b\ :sub:`0`
>      * .. _MEDIA-BUS-FMT-BGR565-2X8-BE:
>  
>        - MEDIA_BUS_FMT_BGR565_2X8_BE