Re: [PATCH 1/5] virtio-net: Allow setting the MAC address via set_config

From: Alex Williamson <alex.williamson@hp.com>
To: dlaor@redhat.com
Cc: kvm <kvm@vger.kernel.org>, qemu-devel <qemu-devel@nongnu.org>,
	Mark McLoughlin <markmc@redhat.com>
Subject: Re: [PATCH 1/5] virtio-net: Allow setting the MAC address via set_config
Date: Wed, 14 Jan 2009 08:34:58 -0700	[thread overview]
Message-ID: <1231947298.7109.262.camel@lappy> (raw)
In-Reply-To: <496DB8D1.2070101@redhat.com>

On Wed, 2009-01-14 at 12:05 +0200, Dor Laor wrote:
> Alex Williamson wrote:  
> > +static void virtio_net_set_config(VirtIODevice *vdev, const uint8_t *config)
> > +{
> > +    VirtIONet *n = to_virtio_net(vdev);
> > +    struct virtio_net_config netcfg;
> > +
> > +    memcpy(&netcfg, config, sizeof(netcfg));
> > +
> > +    if (memcmp(netcfg.mac, n->mac, 6)) {
> > +        memcpy(n->mac, netcfg.mac, 6);
> > +        qemu_format_nic_info_str(n->vc, n->mac);
> > +    }
> > +}
> > +
> >   
> 
> What if the guest will chose the host's mac?
> Thinking about it, I don't think we should test that.
> A concerned host mgmt app can add ebtables roles for such a case.
> 
> Maybe we can optionally allow/deny it?

What's the topology you're thinking of that the virtio-net MAC is also
the host MAC?  I typically use a bridge with a tap device, so the
virtio-net MAC is isolated from the host.  Thanks,

Alex

-- 
Alex Williamson                             HP Open Source & Linux Org.