From: Adrian McMenamin <adrian@newgolddream.dyndns.info>
To: Mike Frysinger <vapier@gentoo.org>
Cc: Paul Mundt <lethal@linux-sh.org>, Greg KH <greg@kroah.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
dwmw2 <dwmw2@infradead.org>, LKML <linux-kernel@vger.kernel.org>,
MTD <linux-mtd@lists.infradead.org>,
linux-sh <linux-sh@vger.kernel.org>,
linux-input <linux-input@vger.kernel.org>
Subject: Re: [PATCH] sh: maple: add support for Visual Memory Card devices,
Date: Mon, 09 Feb 2009 21:41:56 +0000 [thread overview]
Message-ID: <1234215716.6756.18.camel@localhost.localdomain> (raw)
In-Reply-To: <200902091433.57126.vapier@gentoo.org>
On Mon, 2009-02-09 at 14:33 -0500, Mike Frysinger wrote:
>
> then you'd end up with 4 clearly marked files (assuming your log message for
> each change is clear). in the summary, you should then make statements like:
> Patch 1 (... subject ...) in this series can be applied by itself for the bus
> driver. Then patch 2 (... subject ...) and 3 (... subject ...) can be applied
> as they need the bus changes.
> -mike
Fair enough.
I ought to resubmit patches anyway because previous code has a memory
leak/race which I've now fixed with a couple of extra lines.
But the basic point here is that changing the bus code is necessary to
get the VMU driver (or *any* VMU driver) to work, but changing the bus
driver also breaks the two existing drivers in mainline that use the
bus. The breakage in terms of lines to be fixed is small, but it still
needs to be done 'all at once'.
WARNING: multiple messages have this Message-ID (diff)
From: Adrian McMenamin <adrian@newgolddream.dyndns.info>
To: Mike Frysinger <vapier@gentoo.org>
Cc: Paul Mundt <lethal@linux-sh.org>, Greg KH <greg@kroah.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
dwmw2 <dwmw2@infradead.org>, LKML <linux-kernel@vger.kernel.org>,
MTD <linux-mtd@lists.infradead.org>,
linux-sh <linux-sh@vger.kernel.org>,
linux-input <linux-input@vger.kernel.org>
Subject: Re: [PATCH] sh: maple: add support for Visual Memory Card devices, and make consequential changes to maple input drivers - 2/3 - v5
Date: Mon, 09 Feb 2009 21:41:56 +0000 [thread overview]
Message-ID: <1234215716.6756.18.camel@localhost.localdomain> (raw)
In-Reply-To: <200902091433.57126.vapier@gentoo.org>
On Mon, 2009-02-09 at 14:33 -0500, Mike Frysinger wrote:
>
> then you'd end up with 4 clearly marked files (assuming your log message for
> each change is clear). in the summary, you should then make statements like:
> Patch 1 (... subject ...) in this series can be applied by itself for the bus
> driver. Then patch 2 (... subject ...) and 3 (... subject ...) can be applied
> as they need the bus changes.
> -mike
Fair enough.
I ought to resubmit patches anyway because previous code has a memory
leak/race which I've now fixed with a couple of extra lines.
But the basic point here is that changing the bus code is necessary to
get the VMU driver (or *any* VMU driver) to work, but changing the bus
driver also breaks the two existing drivers in mainline that use the
bus. The breakage in terms of lines to be fixed is small, but it still
needs to be done 'all at once'.
WARNING: multiple messages have this Message-ID (diff)
From: Adrian McMenamin <adrian@newgolddream.dyndns.info>
To: Mike Frysinger <vapier@gentoo.org>
Cc: linux-sh <linux-sh@vger.kernel.org>, Greg KH <greg@kroah.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
Paul Mundt <lethal@linux-sh.org>,
MTD <linux-mtd@lists.infradead.org>,
linux-input <linux-input@vger.kernel.org>,
dwmw2 <dwmw2@infradead.org>
Subject: Re: [PATCH] sh: maple: add support for Visual Memory Card devices, and make consequential changes to maple input drivers - 2/3 - v5
Date: Mon, 09 Feb 2009 21:41:56 +0000 [thread overview]
Message-ID: <1234215716.6756.18.camel@localhost.localdomain> (raw)
In-Reply-To: <200902091433.57126.vapier@gentoo.org>
On Mon, 2009-02-09 at 14:33 -0500, Mike Frysinger wrote:
>
> then you'd end up with 4 clearly marked files (assuming your log message for
> each change is clear). in the summary, you should then make statements like:
> Patch 1 (... subject ...) in this series can be applied by itself for the bus
> driver. Then patch 2 (... subject ...) and 3 (... subject ...) can be applied
> as they need the bus changes.
> -mike
Fair enough.
I ought to resubmit patches anyway because previous code has a memory
leak/race which I've now fixed with a couple of extra lines.
But the basic point here is that changing the bus code is necessary to
get the VMU driver (or *any* VMU driver) to work, but changing the bus
driver also breaks the two existing drivers in mainline that use the
bus. The breakage in terms of lines to be fixed is small, but it still
needs to be done 'all at once'.
next prev parent reply other threads:[~2009-02-09 21:41 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-08 19:41 [PATCH] sh: maple: add support for Visual Memory Card devices, and Adrian McMenamin
2009-02-08 19:41 ` [PATCH] sh: maple: add support for Visual Memory Card devices, and make consequential changes to maple input drivers - 0/3 - v5 Adrian McMenamin
2009-02-08 19:41 ` Adrian McMenamin
2009-02-08 19:52 ` [PATCH] sh: maple: add support for Visual Memory Card devices, Adrian McMenamin
2009-02-08 19:52 ` [PATCH] sh: maple: add support for Visual Memory Card devices, and make consequential changes to maple input drivers - 0/3 - v5 - diff stat correction Adrian McMenamin
2009-02-08 19:52 ` Adrian McMenamin
2009-02-08 20:00 ` [PATCH] sh: maple: add support for Visual Memory Card devices, and Adrian McMenamin
2009-02-08 20:00 ` [PATCH] sh: maple: add support for Visual Memory Card devices, and make consequential changes to maple input drivers - 1/3 - v5 Adrian McMenamin
2009-02-08 20:00 ` Adrian McMenamin
2009-02-08 20:00 ` Adrian McMenamin
2009-02-08 20:04 ` [PATCH] sh: maple: add support for Visual Memory Card devices, and Adrian McMenamin
2009-02-08 20:04 ` [PATCH] sh: maple: add support for Visual Memory Card devices, and make consequential changes to maple input drivers - 2/3 - v5 Adrian McMenamin
2009-02-08 20:04 ` Adrian McMenamin
2009-02-08 20:04 ` Adrian McMenamin
2009-02-09 6:56 ` [PATCH] sh: maple: add support for Visual Memory Card devices, and make consequential changes to Paul Mundt
2009-02-09 6:56 ` [PATCH] sh: maple: add support for Visual Memory Card devices, and make consequential changes to maple input drivers - 2/3 - v5 Paul Mundt
2009-02-09 6:56 ` Paul Mundt
2009-02-09 19:17 ` [PATCH] sh: maple: add support for Visual Memory Card devices, Adrian McMenamin
2009-02-09 19:17 ` [PATCH] sh: maple: add support for Visual Memory Card devices, and make consequential changes to maple input drivers - 2/3 - v5 Adrian McMenamin
2009-02-09 19:17 ` Adrian McMenamin
2009-02-09 19:33 ` [PATCH] sh: maple: add support for Visual Memory Card devices, and make consequential changes to Mike Frysinger
2009-02-09 19:33 ` [PATCH] sh: maple: add support for Visual Memory Card devices, and make consequential changes to maple input drivers - 2/3 - v5 Mike Frysinger
2009-02-09 19:33 ` Mike Frysinger
2009-02-09 21:41 ` Adrian McMenamin [this message]
2009-02-09 21:41 ` Adrian McMenamin
2009-02-09 21:41 ` Adrian McMenamin
2009-02-10 0:11 ` [PATCH] sh: maple: add support for Visual Memory Card devices, and make consequential changes to Mike Frysinger
2009-02-10 0:11 ` [PATCH] sh: maple: add support for Visual Memory Card devices, and make consequential changes to maple input drivers - 2/3 - v5 Mike Frysinger
2009-02-10 0:11 ` Mike Frysinger
2009-02-08 20:07 ` [PATCH] sh: maple: add support for Visual Memory Card devices, Adrian McMenamin
2009-02-08 20:07 ` [PATCH] sh: maple: add support for Visual Memory Card devices, and make consequential changes to maple input drivers - 0/3 - v5 Adrian McMenamin
2009-02-08 20:07 ` Adrian McMenamin
2009-02-08 20:07 ` Adrian McMenamin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1234215716.6756.18.camel@localhost.localdomain \
--to=adrian@newgolddream.dyndns.info \
--cc=dmitry.torokhov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=greg@kroah.com \
--cc=lethal@linux-sh.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-sh@vger.kernel.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.