From: Nigel Cunningham <nigel@tuxonice.net>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Linux PCI <linux-pci@vger.kernel.org>,
pm list <linux-pm@lists.linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [linux-pm] [RFC][PATCH 1/2] PCI PM: Introduce __pci_set_power_state()
Date: Mon, 23 Mar 2009 10:08:05 +1100 [thread overview]
Message-ID: <1237763285.11186.2.camel@nigel-laptop> (raw)
In-Reply-To: <200903222211.50930.rjw@sisk.pl>
Hi.
It's not an error if we fail to set the desired state? (I see you have a
dev_warn only).
(If it is an error, the radeon_set_suspend patch needs to be adjusted to
not ignore the error code).
Regards,
Nigel
WARNING: multiple messages have this Message-ID (diff)
From: Nigel Cunningham <nigel@tuxonice.net>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: LKML <linux-kernel@vger.kernel.org>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
Linux PCI <linux-pci@vger.kernel.org>,
pm list <linux-pm@lists.linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [RFC][PATCH 1/2] PCI PM: Introduce __pci_set_power_state()
Date: Mon, 23 Mar 2009 10:08:05 +1100 [thread overview]
Message-ID: <1237763285.11186.2.camel@nigel-laptop> (raw)
In-Reply-To: <200903222211.50930.rjw@sisk.pl>
Hi.
It's not an error if we fail to set the desired state? (I see you have a
dev_warn only).
(If it is an error, the radeon_set_suspend patch needs to be adjusted to
not ignore the error code).
Regards,
Nigel
next prev parent reply other threads:[~2009-03-22 23:13 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-20 23:03 [RFC][PATCH] PCI PM: Be extra careful when changing power states of devices Rafael J. Wysocki
2009-03-22 21:08 ` [RFC][PATCH 0/2] Make radeonfb use PCI PM core for suspendig device (was: Re: [RFC][PATCH] PCI PM: Be extra careful when changing power states of devices) Rafael J. Wysocki
2009-03-22 21:08 ` Rafael J. Wysocki
2009-03-22 21:11 ` [RFC][PATCH 1/2] PCI PM: Introduce __pci_set_power_state() Rafael J. Wysocki
2009-03-22 23:08 ` Nigel Cunningham [this message]
2009-03-22 23:08 ` Nigel Cunningham
2009-03-23 18:14 ` [linux-pm] " Rafael J. Wysocki
2009-03-23 18:14 ` Rafael J. Wysocki
2009-03-22 21:11 ` Rafael J. Wysocki
2009-03-22 21:13 ` [RFC][PATCH 2/2] radeonfb: Avoid open coding of PCI PM operations Rafael J. Wysocki
2009-03-22 21:13 ` Rafael J. Wysocki
2009-03-23 0:09 ` [RFC][PATCH 0/2] Make radeonfb use PCI PM core for suspendig device (was: Re: [RFC][PATCH] PCI PM: Be extra careful when changing power states of devices) Benjamin Herrenschmidt
2009-03-23 0:09 ` Benjamin Herrenschmidt
2009-03-23 23:01 ` Rafael J. Wysocki
2009-03-23 23:01 ` Rafael J. Wysocki
2009-03-23 21:30 ` [RFC][PATCH 0/2] Export platform_pci_set_power_state() and make radeonfb use it Rafael J. Wysocki
2009-03-23 21:31 ` [RFC][PATCH 1/2] PCI PM: Export platform_pci_set_power_state() Rafael J. Wysocki
2009-03-23 21:31 ` Rafael J. Wysocki
2009-03-23 21:32 ` [RFC][PATCH 2/2] radeonfb: Use platform_pci_set_power_state() Rafael J. Wysocki
2009-03-23 21:32 ` Rafael J. Wysocki
2009-03-23 22:23 ` [RFC][PATCH 0/2] Export platform_pci_set_power_state() and make radeonfb use it Jesse Barnes
2009-03-23 22:23 ` Jesse Barnes
2009-03-24 0:57 ` Benjamin Herrenschmidt
2009-03-24 0:57 ` Benjamin Herrenschmidt
2009-03-24 1:14 ` Jesse Barnes
2009-03-24 1:14 ` Jesse Barnes
2009-03-24 11:00 ` Rafael J. Wysocki
2009-03-24 21:12 ` Benjamin Herrenschmidt
2009-03-24 21:12 ` Benjamin Herrenschmidt
2009-03-24 22:00 ` Rafael J. Wysocki
2009-03-24 22:00 ` Rafael J. Wysocki
2009-03-24 22:25 ` Rafael J. Wysocki
2009-03-24 22:25 ` Rafael J. Wysocki
2009-03-24 11:00 ` Rafael J. Wysocki
2009-03-24 22:04 ` Alex Deucher
2009-03-24 22:04 ` Alex Deucher
2009-03-23 21:30 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1237763285.11186.2.camel@nigel-laptop \
--to=nigel@tuxonice.net \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=rjw@sisk.pl \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.