All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Williamson <alex.williamson@hp.com>
To: Sridhar Samudrala <sri@us.ibm.com>
Cc: kvm@vger.kernel.org
Subject: Re: virtio-net not working with the latest qemu-kvm git
Date: Mon, 04 May 2009 11:44:48 -0600	[thread overview]
Message-ID: <1241459088.26045.1.camel@lappy> (raw)
In-Reply-To: <1241455836.16915.20.camel@w-sridhar.beaverton.ibm.com>

On Mon, 2009-05-04 at 09:50 -0700, Sridhar Samudrala wrote:
> When i moved to the latest qemu-kvm git tree from kvm-85, i noticed that
> networking stopped working between the host and the guest.
> It started working when i put the device in promiscuos mode by running
> tcpdump in background on the guest. 
> 
> After browsing through the recent patches, i found that the following commit
> is causing the regression.
> 
> Remove stray GSO code from virtio_net (Mark McLoughlin)
> http://git.kernel.org/?p=virt/kvm/qemu-kvm.git;a=commitdiff;h=559a8f45f34cc50d1a60b4f67a06614d506b2e01
> 
> The comment doesn't seem to match with the code that is removed with this patch.

Yep, I agree, the removed code is not bogus.  We have to skip the vnet
header to to get to the ethernet header, which we do the filtering on.

Alex


  reply	other threads:[~2009-05-04 17:44 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-04 16:50 virtio-net not working with the latest qemu-kvm git Sridhar Samudrala
2009-05-04 17:44 ` Alex Williamson [this message]
2009-05-05  8:56   ` [PATCH 1/1] qemu-kvm: virtio-net: Re-instate GSO code removed upstream Mark McLoughlin
2009-05-06  9:11     ` Avi Kivity
2009-09-29 20:45     ` Mark McLoughlin
2009-09-29 20:47       ` Mark McLoughlin
2009-09-30  6:24       ` Avi Kivity
2009-09-30 11:24         ` Glauber Costa
2009-09-30 11:24           ` Mark McLoughlin
2009-09-30 13:01         ` Anthony Liguori
2009-09-30 13:51       ` Christoph Hellwig
2009-09-30 13:51         ` [Qemu-devel] " Christoph Hellwig
2009-09-30 13:55         ` Avi Kivity
2009-09-30 13:55           ` [Qemu-devel] " Avi Kivity
2009-09-30 13:59           ` Mark McLoughlin
2009-09-30 13:59             ` [Qemu-devel] " Mark McLoughlin
2009-09-30 19:15             ` Gerd Hoffmann
2009-09-30 19:15               ` [Qemu-devel] " Gerd Hoffmann
2009-10-01  6:59               ` Mark McLoughlin
2009-10-01 16:49             ` Avi Kivity
2009-10-01 16:49               ` [Qemu-devel] " Avi Kivity
2009-10-01 17:00               ` Mark McLoughlin
2009-10-01 17:00                 ` [Qemu-devel] " Mark McLoughlin
2009-10-01 17:04                 ` Avi Kivity
2009-10-01 17:04                   ` [Qemu-devel] " Avi Kivity
2009-05-05  8:56   ` virtio-net not working with the latest qemu-kvm git Mark McLoughlin
2009-05-06  9:12 ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1241459088.26045.1.camel@lappy \
    --to=alex.williamson@hp.com \
    --cc=kvm@vger.kernel.org \
    --cc=sri@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.