Re: [PATCH 1/1] qemu-kvm: virtio-net: Re-instate GSO code removed upstream

From: Avi Kivity <avi@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Mark McLoughlin <markmc@redhat.com>,
	kvm@vger.kernel.org, qemu-devel@nongnu.org
Subject: Re: [PATCH 1/1] qemu-kvm: virtio-net: Re-instate GSO code removed upstream
Date: Wed, 30 Sep 2009 15:55:33 +0200	[thread overview]
Message-ID: <4AC36355.8040908@redhat.com> (raw)
In-Reply-To: <20090930135144.GA29956@infradead.org>

On 09/30/2009 03:51 PM, Christoph Hellwig wrote:
> I might sound like a broken record, but why isn't the full GSO support
> for virtio-net upstream in qemu?
>    

IIRC the current hacks are not upstream quality.

The problem (again IIRC) is that the guest and host negotiate a 
protocol, but the qemu vlan model doesn't have a guest and a host, it 
has peers (possibly more than two), so a lot of translation has to take 
place if you have one peer supporting a guest feature and another not.

IMO the best way out is to drop the vlan model.  It has its uses, but 
they can all be implemented in other ways, and are all have minor usage 
compared to the business of getting data into and out of a guest.

-- 
error compiling committee.c: too many arguments to function