Re: [AUTOTEST] [PATCH 1/2] Add latest LTP test in autotest

From: Lucas Meneghel Rodrigues <lmr@redhat.com>
To: sudhir kumar <smalikphy@gmail.com>
Cc: Autotest mailing list <autotest@test.kernel.org>,
	kvm-devel <kvm@vger.kernel.org>,
	Lucas Meneghel Rodrigues <mrodrigu@redhat.com>,
	Uri Lublin <uril@redhat.com>
Subject: Re: [AUTOTEST] [PATCH 1/2] Add latest LTP test in autotest
Date: Mon, 06 Jul 2009 03:58:39 -0300	[thread overview]
Message-ID: <1246863519.2865.18.camel@localhost.localdomain> (raw)
In-Reply-To: <a50cf5ab0907052240xf22b2b2rf7b90cc819d0ee87@mail.gmail.com>

On Mon, 2009-07-06 at 11:10 +0530, sudhir kumar wrote:
> This patch updates the ltp wrapper in autotest to execute the latest ltp.
> At present autotest contains ltp which is more than 1 year old. There have
> been added lots of testcases in ltp within this period. So this patch updates
> the wrapper to run the June2009 release of ltp which is available at
> http://prdownloads.sourceforge.net/ltp/ltp-full-20090630.tgz

Indeed it would be a good time to update the LTP version being used on
autotest.

> Issues: LTP has a history of some of the testcases getting broken. Anyways
> that has nothing to worry about with respect to autotest. One of the known issue
> is broken memory controller issue with latest kernels(cgroups and memory
> resource controller enabled kernels). The workaround for them I use is to
> disable or delete those tests from ltp source and tar it again with the same
> name. Though people might use different workarounds for it.

A good start would be LTP build being more failure resilent (ie, if one
particular test fails to compile, don't fail the whole build). I will
raise this question on the LTP mailing list.

> I have added an option which generates a fancy html results file. Also the
> run is left to be a default run as expected.
> 
> For autotest users, please untar the results file I am sending, run
> cd results/default; firefox results.html, click ltp_results.html
> This is a symlink to the ltp_results.html which is generated by ltp.
> 
> Please provide your comments, concerns and issues.
> 
> Signed-off-by: Sudhir Kumar <skumar@linux.vnet.ibm.com>
> 
> Index: autotest/client/tests/ltp/ltp.py
> ===================================================================
> --- autotest.orig/client/tests/ltp/ltp.py
> +++ autotest/client/tests/ltp/ltp.py
> @@ -23,8 +23,8 @@ class ltp(test.test):
>          self.job.require_gcc()
> 
> 
> -    # http://prdownloads.sourceforge.net/ltp/ltp-full-20080229.tgz
> -    def setup(self, tarball = 'ltp-full-20080229.tar.bz2'):
> +    # http://prdownloads.sourceforge.net/ltp/ltp-full-20090630.tgz
> +    def setup(self, tarball = 'ltp-full-20090630.tgz'):
>          tarball = utils.unmap_url(self.bindir, tarball, self.tmpdir)
>          utils.extract_tarball_to_dir(tarball, self.srcdir)
>          os.chdir(self.srcdir)
> @@ -52,8 +52,9 @@ class ltp(test.test):
>          # In case the user wants to run another test script
>          if script == 'runltp':
>              logfile = os.path.join(self.resultsdir, 'ltp.log')
> +            htmlfile = os.path.join(self.resultsdir, 'ltp_results.html')
>              failcmdfile = os.path.join(self.debugdir, 'failcmdfile')
> -            args2 = '-q -l %s -C %s -d %s' % (logfile, failcmdfile,
> self.tmpdir)
> +            args2 = '-l %s -g %s -C %s -d %s' % (logfile, htmlfile,
> failcmdfile, self.tmpdir)
>              args = args + ' ' + args2
> 
>          cmd = os.path.join(self.srcdir, script) + ' ' + args

Patch looks good to me.