From: Vivek Goyal <vgoyal@redhat.com> To: linux-kernel@vger.kernel.org, containers@lists.linux-foundation.org, dm-devel@redhat.com, jens.axboe@oracle.com, nauman@google.com, dpshah@google.com, ryov@valinux.co.jp, guijianfeng@cn.fujitsu.com, balbir@linux.vnet.ibm.com, righi.andrea@gmail.com Cc: lizf@cn.fujitsu.com, mikew@google.com, fchecconi@gmail.com, paolo.valente@unimore.it, fernando@oss.ntt.co.jp, s-uchida@ap.jp.nec.com, taka@valinux.co.jp, jmoyer@redhat.com, dhaval@linux.vnet.ibm.com, m-ikeda@ds.jp.nec.com, agk@redhat.com, vgoyal@redhat.com, akpm@linux-foundation.org, peterz@infradead.org Subject: [PATCH 09/24] io-controller: cfq changes to use hierarchical fair queuing code in elevaotor layer Date: Fri, 24 Jul 2009 16:27:39 -0400 [thread overview] Message-ID: <1248467274-32073-10-git-send-email-vgoyal@redhat.com> (raw) In-Reply-To: <1248467274-32073-1-git-send-email-vgoyal@redhat.com> Make cfq hierarhical. Signed-off-by: Nauman Rafique <nauman@google.com> Signed-off-by: Fabio Checconi <fabio@gandalf.sssup.it> Signed-off-by: Paolo Valente <paolo.valente@unimore.it> Signed-off-by: Aristeu Rozanski <aris@redhat.com> Signed-off-by: Vivek Goyal <vgoyal@redhat.com> --- block/Kconfig.iosched | 8 ++++++ block/cfq-iosched.c | 62 +++++++++++++++++++++++++++++++++++++++++++++++- init/Kconfig | 2 +- 3 files changed, 69 insertions(+), 3 deletions(-) diff --git a/block/Kconfig.iosched b/block/Kconfig.iosched index dd5224d..a91a807 100644 --- a/block/Kconfig.iosched +++ b/block/Kconfig.iosched @@ -54,6 +54,14 @@ config IOSCHED_CFQ working environment, suitable for desktop systems. This is the default I/O scheduler. +config IOSCHED_CFQ_HIER + bool "CFQ Hierarchical Scheduling support" + depends on IOSCHED_CFQ && CGROUPS + select GROUP_IOSCHED + default n + ---help--- + Enable hierarhical scheduling in cfq. + choice prompt "Default I/O scheduler" default DEFAULT_CFQ diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c index 98fd508..a362ce1 100644 --- a/block/cfq-iosched.c +++ b/block/cfq-iosched.c @@ -1283,6 +1283,60 @@ static void cfq_init_cfqq(struct cfq_data *cfqd, struct cfq_queue *cfqq, cfqq->pid = pid; } +#ifdef CONFIG_IOSCHED_CFQ_HIER +static void changed_cgroup(struct io_context *ioc, struct cfq_io_context *cic) +{ + struct cfq_queue *async_cfqq = cic_to_cfqq(cic, 0); + struct cfq_queue *sync_cfqq = cic_to_cfqq(cic, 1); + struct cfq_data *cfqd = cic->key; + struct io_group *iog, *__iog; + unsigned long flags; + struct request_queue *q; + + if (unlikely(!cfqd)) + return; + + q = cfqd->queue; + + spin_lock_irqsave(q->queue_lock, flags); + + iog = io_get_io_group(q, 0); + + if (async_cfqq != NULL) { + __iog = cfqq_to_io_group(async_cfqq); + if (iog != __iog) { + /* cgroup changed, drop the reference to async queue */ + cic_set_cfqq(cic, NULL, 0); + cfq_put_queue(async_cfqq); + } + } + + if (sync_cfqq != NULL) { + __iog = cfqq_to_io_group(sync_cfqq); + + /* + * Drop reference to sync queue. A new sync queue will + * be assigned in new group upon arrival of a fresh request. + * If old queue has got requests, those reuests will be + * dispatched over a period of time and queue will be freed + * automatically. + */ + if (iog != __iog) { + cic_set_cfqq(cic, NULL, 1); + cfq_put_queue(sync_cfqq); + } + } + + spin_unlock_irqrestore(q->queue_lock, flags); +} + +static void cfq_ioc_set_cgroup(struct io_context *ioc) +{ + call_for_each_cic(ioc, changed_cgroup); + ioc->cgroup_changed = 0; +} +#endif /* CONFIG_IOSCHED_CFQ_HIER */ + static struct cfq_queue * cfq_find_alloc_queue(struct cfq_data *cfqd, int is_sync, struct io_context *ioc, gfp_t gfp_mask) @@ -1294,7 +1348,7 @@ cfq_find_alloc_queue(struct cfq_data *cfqd, int is_sync, struct io_group *iog = NULL; retry: - iog = io_get_io_group(q); + iog = io_get_io_group(q, 1); cic = cfq_cic_lookup(cfqd, ioc); /* cic always exists here */ @@ -1384,7 +1438,7 @@ cfq_get_queue(struct cfq_data *cfqd, int is_sync, struct io_context *ioc, const int ioprio_class = task_ioprio_class(ioc); struct cfq_queue *async_cfqq = NULL; struct cfq_queue *cfqq = NULL; - struct io_group *iog = io_get_io_group(cfqd->queue); + struct io_group *iog = io_get_io_group(cfqd->queue, 1); if (!is_sync) { async_cfqq = io_group_async_queue_prio(iog, ioprio_class, @@ -1540,6 +1594,10 @@ out: smp_read_barrier_depends(); if (unlikely(ioc->ioprio_changed)) cfq_ioc_set_ioprio(ioc); +#ifdef CONFIG_IOSCHED_CFQ_HIER + if (unlikely(ioc->cgroup_changed)) + cfq_ioc_set_cgroup(ioc); +#endif return cic; err_free: cfq_cic_free(cic); diff --git a/init/Kconfig b/init/Kconfig index fa3edd6..7a368d8 100644 --- a/init/Kconfig +++ b/init/Kconfig @@ -613,7 +613,7 @@ config CGROUP_MEM_RES_CTLR_SWAP size is 4096bytes, 512k per 1Gbytes of swap. config GROUP_IOSCHED - bool "Group IO Scheduler" + bool depends on CGROUPS && ELV_FAIR_QUEUING default n ---help--- -- 1.6.0.6
WARNING: multiple messages have this Message-ID (diff)
From: Vivek Goyal <vgoyal@redhat.com> To: linux-kernel@vger.kernel.org, containers@lists.linux-foundation.org, dm-devel@redhat.com, jens.axboe@oracle.com, nauman@google.com, dpshah@google.com, ryov@valinux.co.jp, guijianfeng@c Cc: paolo.valente@unimore.it, dhaval@linux.vnet.ibm.com, peterz@infradead.org, fernando@oss.ntt.co.jp, lizf@cn.fujitsu.com, jmoyer@redhat.com, mikew@google.com, fchecconi@gmail.com, vgoyal@redhat.com, s-uchida@ap.jp.nec.com, akpm@linux-foundation.org, agk@redhat.com, m-ikeda@ds.jp.nec.com Subject: [PATCH 09/24] io-controller: cfq changes to use hierarchical fair queuing code in elevaotor layer Date: Fri, 24 Jul 2009 16:27:39 -0400 [thread overview] Message-ID: <1248467274-32073-10-git-send-email-vgoyal@redhat.com> (raw) In-Reply-To: <1248467274-32073-1-git-send-email-vgoyal@redhat.com> Make cfq hierarhical. Signed-off-by: Nauman Rafique <nauman@google.com> Signed-off-by: Fabio Checconi <fabio@gandalf.sssup.it> Signed-off-by: Paolo Valente <paolo.valente@unimore.it> Signed-off-by: Aristeu Rozanski <aris@redhat.com> Signed-off-by: Vivek Goyal <vgoyal@redhat.com> --- block/Kconfig.iosched | 8 ++++++ block/cfq-iosched.c | 62 +++++++++++++++++++++++++++++++++++++++++++++++- init/Kconfig | 2 +- 3 files changed, 69 insertions(+), 3 deletions(-) diff --git a/block/Kconfig.iosched b/block/Kconfig.iosched index dd5224d..a91a807 100644 --- a/block/Kconfig.iosched +++ b/block/Kconfig.iosched @@ -54,6 +54,14 @@ config IOSCHED_CFQ working environment, suitable for desktop systems. This is the default I/O scheduler. +config IOSCHED_CFQ_HIER + bool "CFQ Hierarchical Scheduling support" + depends on IOSCHED_CFQ && CGROUPS + select GROUP_IOSCHED + default n + ---help--- + Enable hierarhical scheduling in cfq. + choice prompt "Default I/O scheduler" default DEFAULT_CFQ diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c index 98fd508..a362ce1 100644 --- a/block/cfq-iosched.c +++ b/block/cfq-iosched.c @@ -1283,6 +1283,60 @@ static void cfq_init_cfqq(struct cfq_data *cfqd, struct cfq_queue *cfqq, cfqq->pid = pid; } +#ifdef CONFIG_IOSCHED_CFQ_HIER +static void changed_cgroup(struct io_context *ioc, struct cfq_io_context *cic) +{ + struct cfq_queue *async_cfqq = cic_to_cfqq(cic, 0); + struct cfq_queue *sync_cfqq = cic_to_cfqq(cic, 1); + struct cfq_data *cfqd = cic->key; + struct io_group *iog, *__iog; + unsigned long flags; + struct request_queue *q; + + if (unlikely(!cfqd)) + return; + + q = cfqd->queue; + + spin_lock_irqsave(q->queue_lock, flags); + + iog = io_get_io_group(q, 0); + + if (async_cfqq != NULL) { + __iog = cfqq_to_io_group(async_cfqq); + if (iog != __iog) { + /* cgroup changed, drop the reference to async queue */ + cic_set_cfqq(cic, NULL, 0); + cfq_put_queue(async_cfqq); + } + } + + if (sync_cfqq != NULL) { + __iog = cfqq_to_io_group(sync_cfqq); + + /* + * Drop reference to sync queue. A new sync queue will + * be assigned in new group upon arrival of a fresh request. + * If old queue has got requests, those reuests will be + * dispatched over a period of time and queue will be freed + * automatically. + */ + if (iog != __iog) { + cic_set_cfqq(cic, NULL, 1); + cfq_put_queue(sync_cfqq); + } + } + + spin_unlock_irqrestore(q->queue_lock, flags); +} + +static void cfq_ioc_set_cgroup(struct io_context *ioc) +{ + call_for_each_cic(ioc, changed_cgroup); + ioc->cgroup_changed = 0; +} +#endif /* CONFIG_IOSCHED_CFQ_HIER */ + static struct cfq_queue * cfq_find_alloc_queue(struct cfq_data *cfqd, int is_sync, struct io_context *ioc, gfp_t gfp_mask) @@ -1294,7 +1348,7 @@ cfq_find_alloc_queue(struct cfq_data *cfqd, int is_sync, struct io_group *iog = NULL; retry: - iog = io_get_io_group(q); + iog = io_get_io_group(q, 1); cic = cfq_cic_lookup(cfqd, ioc); /* cic always exists here */ @@ -1384,7 +1438,7 @@ cfq_get_queue(struct cfq_data *cfqd, int is_sync, struct io_context *ioc, const int ioprio_class = task_ioprio_class(ioc); struct cfq_queue *async_cfqq = NULL; struct cfq_queue *cfqq = NULL; - struct io_group *iog = io_get_io_group(cfqd->queue); + struct io_group *iog = io_get_io_group(cfqd->queue, 1); if (!is_sync) { async_cfqq = io_group_async_queue_prio(iog, ioprio_class, @@ -1540,6 +1594,10 @@ out: smp_read_barrier_depends(); if (unlikely(ioc->ioprio_changed)) cfq_ioc_set_ioprio(ioc); +#ifdef CONFIG_IOSCHED_CFQ_HIER + if (unlikely(ioc->cgroup_changed)) + cfq_ioc_set_cgroup(ioc); +#endif return cic; err_free: cfq_cic_free(cic); diff --git a/init/Kconfig b/init/Kconfig index fa3edd6..7a368d8 100644 --- a/init/Kconfig +++ b/init/Kconfig @@ -613,7 +613,7 @@ config CGROUP_MEM_RES_CTLR_SWAP size is 4096bytes, 512k per 1Gbytes of swap. config GROUP_IOSCHED - bool "Group IO Scheduler" + bool depends on CGROUPS && ELV_FAIR_QUEUING default n ---help--- -- 1.6.0.6
next prev parent reply other threads:[~2009-07-24 20:29 UTC|newest] Thread overview: 120+ messages / expand[flat|nested] mbox.gz Atom feed top 2009-07-24 20:27 [RFC] IO scheduler based IO controller V7 Vivek Goyal 2009-07-24 20:27 ` Vivek Goyal 2009-07-24 20:27 ` [PATCH 01/24] io-controller: Documentation Vivek Goyal 2009-07-24 20:27 ` Vivek Goyal 2009-07-24 20:27 ` [PATCH 02/24] io-controller: Core of the B-WF2Q+ scheduler Vivek Goyal 2009-07-24 20:27 ` Vivek Goyal 2009-07-24 20:27 ` [PATCH 03/24] io-controller: bfq support of in-class preemption Vivek Goyal 2009-07-24 20:27 ` Vivek Goyal 2009-07-27 16:54 ` Jerome Marchand [not found] ` <4A6DDBDE.8020608-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2009-07-27 22:41 ` Vivek Goyal 2009-07-27 22:41 ` Vivek Goyal 2009-07-27 22:41 ` Vivek Goyal [not found] ` <20090727224138.GA3702-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2009-07-28 11:44 ` Jerome Marchand 2009-07-28 11:44 ` Jerome Marchand 2009-07-28 13:52 ` Vivek Goyal 2009-07-28 13:52 ` Vivek Goyal 2009-07-28 14:29 ` Jerome Marchand 2009-07-28 15:03 ` Vivek Goyal 2009-07-28 15:03 ` Vivek Goyal 2009-07-28 15:37 ` Jerome Marchand [not found] ` <4A6F1B4F.6080709-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2009-07-28 18:45 ` Vivek Goyal 2009-07-28 18:45 ` Vivek Goyal 2009-07-28 18:45 ` Vivek Goyal [not found] ` <20090728150310.GA3870-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2009-07-28 15:37 ` Jerome Marchand [not found] ` <4A6F0B32.7060801-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2009-07-28 15:03 ` Vivek Goyal [not found] ` <20090728135212.GC6133-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2009-07-28 14:29 ` Jerome Marchand [not found] ` <4A6EE4A0.6080700-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2009-07-28 13:52 ` Vivek Goyal [not found] ` <1248467274-32073-4-git-send-email-vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2009-07-27 16:54 ` Jerome Marchand 2009-07-24 20:27 ` [PATCH 04/24] io-controller: Common flat fair queuing code in elevaotor layer Vivek Goyal 2009-07-24 20:27 ` Vivek Goyal 2009-07-24 20:27 ` [PATCH 05/24] io-controller: Modify cfq to make use of flat elevator fair queuing Vivek Goyal 2009-07-24 20:27 ` Vivek Goyal [not found] ` <1248467274-32073-6-git-send-email-vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2009-07-30 6:30 ` Gui Jianfeng 2009-07-30 15:42 ` Jerome Marchand 2009-07-30 6:30 ` Gui Jianfeng [not found] ` <4A713E10.2030204-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org> 2009-07-31 13:18 ` Vivek Goyal 2009-07-31 13:18 ` Vivek Goyal 2009-07-31 13:18 ` Vivek Goyal 2009-07-30 15:42 ` Jerome Marchand [not found] ` <4A71BF76.6040709-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2009-07-30 18:30 ` Vivek Goyal 2009-07-30 18:30 ` Vivek Goyal 2009-07-30 18:30 ` Vivek Goyal 2009-07-24 20:27 ` [PATCH 06/24] io-controller: core bfq scheduler changes for hierarchical setup Vivek Goyal 2009-07-24 20:27 ` Vivek Goyal 2009-07-24 20:27 ` [PATCH 07/24] io-controller: cgroup related changes for hierarchical group support Vivek Goyal 2009-07-24 20:27 ` Vivek Goyal 2009-07-24 20:27 ` [PATCH 08/24] io-controller: Common hierarchical fair queuing code in elevaotor layer Vivek Goyal 2009-07-24 20:27 ` Vivek Goyal 2009-07-24 20:27 ` Vivek Goyal [this message] 2009-07-24 20:27 ` [PATCH 09/24] io-controller: cfq changes to use " Vivek Goyal 2009-07-24 20:27 ` [PATCH 11/24] io-controller: Debug hierarchical IO scheduling Vivek Goyal 2009-07-24 20:27 ` Vivek Goyal 2009-07-24 20:27 ` [PATCH 12/24] io-controller: Introduce group idling Vivek Goyal 2009-07-24 20:27 ` Vivek Goyal 2009-07-24 20:27 ` [PATCH 13/24] io-controller: Wait for requests to complete from last queue before new queue is scheduled Vivek Goyal 2009-07-24 20:27 ` Vivek Goyal 2009-07-24 20:27 ` [PATCH 14/24] io-controller: Separate out queue and data Vivek Goyal 2009-07-24 20:27 ` Vivek Goyal 2009-07-24 20:27 ` [PATCH 15/24] io-conroller: Prepare elevator layer for single queue schedulers Vivek Goyal 2009-07-24 20:27 ` Vivek Goyal 2009-07-24 20:27 ` [PATCH 16/24] io-controller: noop changes for hierarchical fair queuing Vivek Goyal 2009-07-24 20:27 ` Vivek Goyal 2009-07-24 20:27 ` [PATCH 17/24] io-controller: deadline " Vivek Goyal 2009-07-24 20:27 ` Vivek Goyal 2009-07-24 20:27 ` [PATCH 18/24] io-controller: anticipatory " Vivek Goyal 2009-07-24 20:27 ` Vivek Goyal [not found] ` <1248467274-32073-1-git-send-email-vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2009-07-24 20:27 ` [PATCH 01/24] io-controller: Documentation Vivek Goyal 2009-07-24 20:27 ` [PATCH 02/24] io-controller: Core of the B-WF2Q+ scheduler Vivek Goyal 2009-07-24 20:27 ` [PATCH 03/24] io-controller: bfq support of in-class preemption Vivek Goyal 2009-07-24 20:27 ` [PATCH 04/24] io-controller: Common flat fair queuing code in elevaotor layer Vivek Goyal 2009-07-24 20:27 ` [PATCH 05/24] io-controller: Modify cfq to make use of flat elevator fair queuing Vivek Goyal 2009-07-24 20:27 ` [PATCH 06/24] io-controller: core bfq scheduler changes for hierarchical setup Vivek Goyal 2009-07-24 20:27 ` [PATCH 07/24] io-controller: cgroup related changes for hierarchical group support Vivek Goyal 2009-07-24 20:27 ` [PATCH 08/24] io-controller: Common hierarchical fair queuing code in elevaotor layer Vivek Goyal 2009-07-24 20:27 ` [PATCH 09/24] io-controller: cfq changes to use " Vivek Goyal 2009-07-24 20:27 ` [PATCH 10/24] io-controller: Export disk time used and nr sectors dipatched through cgroups Vivek Goyal 2009-07-24 20:27 ` Vivek Goyal 2009-07-24 20:27 ` [PATCH 11/24] io-controller: Debug hierarchical IO scheduling Vivek Goyal 2009-07-24 20:27 ` [PATCH 12/24] io-controller: Introduce group idling Vivek Goyal 2009-07-24 20:27 ` [PATCH 13/24] io-controller: Wait for requests to complete from last queue before new queue is scheduled Vivek Goyal 2009-07-24 20:27 ` [PATCH 14/24] io-controller: Separate out queue and data Vivek Goyal 2009-07-24 20:27 ` [PATCH 15/24] io-conroller: Prepare elevator layer for single queue schedulers Vivek Goyal 2009-07-24 20:27 ` [PATCH 16/24] io-controller: noop changes for hierarchical fair queuing Vivek Goyal 2009-07-24 20:27 ` [PATCH 17/24] io-controller: deadline " Vivek Goyal 2009-07-24 20:27 ` [PATCH 18/24] io-controller: anticipatory " Vivek Goyal 2009-07-24 20:27 ` [PATCH 19/24] blkio_cgroup patches from Ryo to track async bios Vivek Goyal 2009-07-24 20:27 ` [PATCH 20/24] io-controller: map async requests to appropriate cgroup Vivek Goyal 2009-07-24 20:27 ` [PATCH 21/24] io-controller: Per cgroup request descriptor support Vivek Goyal 2009-07-24 20:27 ` [PATCH 22/24] io-controller: Per io group bdi congestion interface Vivek Goyal 2009-07-24 20:27 ` [PATCH 23/24] io-controller: Support per cgroup per device weights and io class Vivek Goyal 2009-07-24 20:27 ` [PATCH 24/24] map sync requests to group using bio tracking info Vivek Goyal 2009-07-31 5:21 ` [RFC] IO scheduler based IO controller V7 Gui Jianfeng 2009-07-24 20:27 ` [PATCH 19/24] blkio_cgroup patches from Ryo to track async bios Vivek Goyal 2009-07-24 20:27 ` Vivek Goyal 2009-07-24 20:27 ` [PATCH 20/24] io-controller: map async requests to appropriate cgroup Vivek Goyal 2009-07-24 20:27 ` Vivek Goyal 2009-07-24 20:27 ` [PATCH 21/24] io-controller: Per cgroup request descriptor support Vivek Goyal 2009-07-24 20:27 ` Vivek Goyal 2009-07-24 20:27 ` [PATCH 22/24] io-controller: Per io group bdi congestion interface Vivek Goyal 2009-07-24 20:27 ` Vivek Goyal 2009-08-08 8:14 ` Gui Jianfeng [not found] ` <1248467274-32073-23-git-send-email-vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2009-08-08 8:14 ` Gui Jianfeng 2009-07-24 20:27 ` [PATCH 23/24] io-controller: Support per cgroup per device weights and io class Vivek Goyal 2009-07-24 20:27 ` Vivek Goyal 2009-07-24 20:27 ` [PATCH 24/24] map sync requests to group using bio tracking info Vivek Goyal 2009-07-24 20:27 ` Vivek Goyal 2009-07-31 5:21 ` [RFC] IO scheduler based IO controller V7 Gui Jianfeng 2009-07-31 5:21 ` Gui Jianfeng [not found] ` <4A727F6F.9010005-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org> 2009-07-31 13:13 ` Vivek Goyal 2009-07-31 13:13 ` Vivek Goyal 2009-07-31 13:13 ` Vivek Goyal 2009-08-03 0:40 ` Gui Jianfeng 2009-08-04 0:48 ` Gui Jianfeng [not found] ` <4A778540.5050502-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org> 2009-08-04 1:30 ` Vivek Goyal 2009-08-04 1:30 ` Vivek Goyal 2009-08-04 1:30 ` Vivek Goyal 2009-08-18 0:42 ` Gui Jianfeng [not found] ` <20090804013001.GB2282-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2009-08-18 0:42 ` Gui Jianfeng [not found] ` <20090731131359.GA3668-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2009-08-03 0:40 ` Gui Jianfeng 2009-08-04 0:48 ` Gui Jianfeng
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1248467274-32073-10-git-send-email-vgoyal@redhat.com \ --to=vgoyal@redhat.com \ --cc=agk@redhat.com \ --cc=akpm@linux-foundation.org \ --cc=balbir@linux.vnet.ibm.com \ --cc=containers@lists.linux-foundation.org \ --cc=dhaval@linux.vnet.ibm.com \ --cc=dm-devel@redhat.com \ --cc=dpshah@google.com \ --cc=fchecconi@gmail.com \ --cc=fernando@oss.ntt.co.jp \ --cc=guijianfeng@cn.fujitsu.com \ --cc=jens.axboe@oracle.com \ --cc=jmoyer@redhat.com \ --cc=linux-kernel@vger.kernel.org \ --cc=lizf@cn.fujitsu.com \ --cc=m-ikeda@ds.jp.nec.com \ --cc=mikew@google.com \ --cc=nauman@google.com \ --cc=paolo.valente@unimore.it \ --cc=peterz@infradead.org \ --cc=righi.andrea@gmail.com \ --cc=ryov@valinux.co.jp \ --cc=s-uchida@ap.jp.nec.com \ --cc=taka@valinux.co.jp \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.