From: Tero Kristo <tero.kristo@nokia.com> To: linux-arm-kernel@lists.infradead.org Cc: linux-omap@vger.kernel.org Subject: [PATCH 1/2] ARM: Implemented support for VFP PM context saving Date: Tue, 24 Nov 2009 12:37:03 +0200 [thread overview] Message-ID: <1259059024-23719-2-git-send-email-tero.kristo@nokia.com> (raw) In-Reply-To: <1259059024-23719-1-git-send-email-tero.kristo@nokia.com> From: Tero Kristo <tero.kristo@nokia.com> In some ARM architectures, like OMAP3, the VFP context can be lost during dynamic sleep cycle. For this purpose, there is now a function vfp_pm_save_context() that should be called before the VFP is assumed to lose context. Next VFP trap will then restore context automatically. We need to have the last_VFP_context[cpu] cleared after the save in idle, else the restore would fail to restore when it sees that the last_VFP_context is same as the current threads vfp_state. This happens when the same process/thread traps an exception post idle. Main work for this patch was done by Peter and Rajendra. Some cleanup and optimization by Tero. Signed-off-by: Tero Kristo <tero.kristo@nokia.com> Acked-by: Tony Lindgren <tony@atomide.com> Cc: Vishwanath Sripathy <vishwanath.bs@ti.com> Cc: Rajendra Nayak <rnayak@ti.com> Cc: Richard Woodruff <r-woodruff2@ti.com> Cc: Peter 'p2' De Schrijver <peter.de-schrijver@nokia.com> --- arch/arm/vfp/vfpmodule.c | 25 +++++++++++++++++++++++++ 1 files changed, 25 insertions(+), 0 deletions(-) diff --git a/arch/arm/vfp/vfpmodule.c b/arch/arm/vfp/vfpmodule.c index 2d7423a..80a08bd 100644 --- a/arch/arm/vfp/vfpmodule.c +++ b/arch/arm/vfp/vfpmodule.c @@ -329,6 +329,31 @@ static void vfp_enable(void *unused) #ifdef CONFIG_PM #include <linux/sysdev.h> +void vfp_pm_save_context(void) +{ + struct thread_info *thread = current_thread_info(); + u32 fpexc = fmrx(FPEXC); + __u32 cpu = thread->cpu; + + if (last_VFP_context[cpu]) { + if (!(fpexc & FPEXC_EN)) { + /* enable vfp now to save context */ + vfp_enable(NULL); + fmxr(FPEXC, fmrx(FPEXC) | FPEXC_EN); + } + vfp_save_state(last_VFP_context[cpu], fpexc); + + /* Disable vfp. The next inst traps an exception and restores*/ + fmxr(FPEXC, fmrx(FPEXC) & ~FPEXC_EN); + + /* + * This is needed else the restore might fail if it sees + * last_VFP_context if same as the current threads vfp_state. + */ + last_VFP_context[cpu] = NULL; + } +} + static int vfp_pm_suspend(struct sys_device *dev, pm_message_t state) { struct thread_info *ti = current_thread_info(); -- 1.5.4.3
WARNING: multiple messages have this Message-ID (diff)
From: tero.kristo@nokia.com (Tero Kristo) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/2] ARM: Implemented support for VFP PM context saving Date: Tue, 24 Nov 2009 12:37:03 +0200 [thread overview] Message-ID: <1259059024-23719-2-git-send-email-tero.kristo@nokia.com> (raw) In-Reply-To: <1259059024-23719-1-git-send-email-tero.kristo@nokia.com> From: Tero Kristo <tero.kristo@nokia.com> In some ARM architectures, like OMAP3, the VFP context can be lost during dynamic sleep cycle. For this purpose, there is now a function vfp_pm_save_context() that should be called before the VFP is assumed to lose context. Next VFP trap will then restore context automatically. We need to have the last_VFP_context[cpu] cleared after the save in idle, else the restore would fail to restore when it sees that the last_VFP_context is same as the current threads vfp_state. This happens when the same process/thread traps an exception post idle. Main work for this patch was done by Peter and Rajendra. Some cleanup and optimization by Tero. Signed-off-by: Tero Kristo <tero.kristo@nokia.com> Acked-by: Tony Lindgren <tony@atomide.com> Cc: Vishwanath Sripathy <vishwanath.bs@ti.com> Cc: Rajendra Nayak <rnayak@ti.com> Cc: Richard Woodruff <r-woodruff2@ti.com> Cc: Peter 'p2' De Schrijver <peter.de-schrijver@nokia.com> --- arch/arm/vfp/vfpmodule.c | 25 +++++++++++++++++++++++++ 1 files changed, 25 insertions(+), 0 deletions(-) diff --git a/arch/arm/vfp/vfpmodule.c b/arch/arm/vfp/vfpmodule.c index 2d7423a..80a08bd 100644 --- a/arch/arm/vfp/vfpmodule.c +++ b/arch/arm/vfp/vfpmodule.c @@ -329,6 +329,31 @@ static void vfp_enable(void *unused) #ifdef CONFIG_PM #include <linux/sysdev.h> +void vfp_pm_save_context(void) +{ + struct thread_info *thread = current_thread_info(); + u32 fpexc = fmrx(FPEXC); + __u32 cpu = thread->cpu; + + if (last_VFP_context[cpu]) { + if (!(fpexc & FPEXC_EN)) { + /* enable vfp now to save context */ + vfp_enable(NULL); + fmxr(FPEXC, fmrx(FPEXC) | FPEXC_EN); + } + vfp_save_state(last_VFP_context[cpu], fpexc); + + /* Disable vfp. The next inst traps an exception and restores*/ + fmxr(FPEXC, fmrx(FPEXC) & ~FPEXC_EN); + + /* + * This is needed else the restore might fail if it sees + * last_VFP_context if same as the current threads vfp_state. + */ + last_VFP_context[cpu] = NULL; + } +} + static int vfp_pm_suspend(struct sys_device *dev, pm_message_t state) { struct thread_info *ti = current_thread_info(); -- 1.5.4.3
next prev parent reply other threads:[~2009-11-24 10:40 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2009-11-24 10:37 [PATCH 0/2] VFP save/restore for OMAP3 Tero Kristo 2009-11-24 10:37 ` Tero Kristo 2009-11-24 10:37 ` Tero Kristo [this message] 2009-11-24 10:37 ` [PATCH 1/2] ARM: Implemented support for VFP PM context saving Tero Kristo 2009-11-24 10:37 ` [PATCH 2/2] OMAP3: Implemented VFP restore/save context Tero Kristo 2009-11-24 10:37 ` Tero Kristo 2009-11-24 11:34 ` Sripathy, Vishwanath 2009-11-24 11:34 ` Sripathy, Vishwanath 2009-11-24 11:47 ` Tero.Kristo 2009-11-24 11:47 ` Tero.Kristo at nokia.com 2009-11-24 11:48 ` [PATCH 1/2] ARM: Implemented support for VFP PM context saving Russell King - ARM Linux 2009-11-24 11:48 ` Russell King - ARM Linux 2009-11-24 13:20 ` Catalin Marinas 2009-11-24 13:20 ` Catalin Marinas 2009-11-24 14:05 ` Tero.Kristo 2009-11-24 14:05 ` Tero.Kristo at nokia.com 2009-11-24 15:19 ` Russell King - ARM Linux 2009-11-24 15:19 ` Russell King - ARM Linux 2009-11-27 10:06 ` Tero.Kristo 2009-11-27 10:06 ` Tero.Kristo at nokia.com -- strict thread matches above, loose matches on Subject: below -- 2009-11-19 17:06 [PATCH 0/2] VFP context save/restore support for OMAP3 Tero Kristo 2009-11-19 17:06 ` [PATCH 1/2] ARM: Implemented support for VFP PM context saving Tero Kristo 2009-11-23 17:39 ` Tony Lindgren
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1259059024-23719-2-git-send-email-tero.kristo@nokia.com \ --to=tero.kristo@nokia.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-omap@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.