From: Alberto Panizzo <maramaopercheseimorto@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Lothar Waßmann" <LW@KARO-electronics.de>,
"H Hartley Sweeten" <hartleys@visionengravers.com>,
"Sascha linux-arm" <s.hauer@pengutronix.de>,
linux-input <linux-input@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v6] input: IMX: add imx-keypad driver to support the Keypad Port present in the imx application processors family.
Date: Sun, 31 Jan 2010 14:42:31 +0100 [thread overview]
Message-ID: <1264945351.2433.10.camel@realization> (raw)
In-Reply-To: <20100131090802.GD12320@core.coreip.homeip.net>
On dom, 2010-01-31 at 01:08 -0800, Dmitry Torokhov wrote:
> Hi Alberto,
>
> On Sat, Jan 30, 2010 at 12:53:27PM +0100, Alberto Panizzo wrote:
> >
> > Changes in v6:
> > -MXC to IMX pattern change (apart of Kconfig dependencies)
> > -Comment style fixes
> > -Greater check delay in debouncing process (10).
> > -Improve the usage of keypad->exit_flag: now it is false only
> between open and
> > close functions. And if we handle an interrupt out there, leave all
> interrupts
> > masked, and wait for another open to re enable they.
> > -Remove unnecessary "free events" mechanism (tested with evtest).
> >
>
> I took the liberty of making some changes to the driver, could you
> please give the patch below a try and if I did not mess it up I will
> fold it into your v6 version and apply to next.
>
> Thank you.
>
> --
> Dmitry
For me it is ok. Your patch looks good and I tested your changes and all
goes well. I have to work on my English and other changes make the
source code more readable.
Dmitry, put also your Signed-off line in v6 patch after merge if you
feel to wont this. (I've already thought to ask you this before this
patch fix) You help me a lot on building this version and an Acked-by
maybe is not fair about your work.
Thank You Dmirty :)
--
Alberto!
WARNING: multiple messages have this Message-ID (diff)
From: maramaopercheseimorto@gmail.com (Alberto Panizzo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6] input: IMX: add imx-keypad driver to support the Keypad Port present in the imx application processors family.
Date: Sun, 31 Jan 2010 14:42:31 +0100 [thread overview]
Message-ID: <1264945351.2433.10.camel@realization> (raw)
In-Reply-To: <20100131090802.GD12320@core.coreip.homeip.net>
On dom, 2010-01-31 at 01:08 -0800, Dmitry Torokhov wrote:
> Hi Alberto,
>
> On Sat, Jan 30, 2010 at 12:53:27PM +0100, Alberto Panizzo wrote:
> >
> > Changes in v6:
> > -MXC to IMX pattern change (apart of Kconfig dependencies)
> > -Comment style fixes
> > -Greater check delay in debouncing process (10).
> > -Improve the usage of keypad->exit_flag: now it is false only
> between open and
> > close functions. And if we handle an interrupt out there, leave all
> interrupts
> > masked, and wait for another open to re enable they.
> > -Remove unnecessary "free events" mechanism (tested with evtest).
> >
>
> I took the liberty of making some changes to the driver, could you
> please give the patch below a try and if I did not mess it up I will
> fold it into your v6 version and apply to next.
>
> Thank you.
>
> --
> Dmitry
For me it is ok. Your patch looks good and I tested your changes and all
goes well. I have to work on my English and other changes make the
source code more readable.
Dmitry, put also your Signed-off line in v6 patch after merge if you
feel to wont this. (I've already thought to ask you this before this
patch fix) You help me a lot on building this version and an Acked-by
maybe is not fair about your work.
Thank You Dmirty :)
--
Alberto!
next prev parent reply other threads:[~2010-01-31 13:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-30 11:53 [PATCH v6] input: IMX: add imx-keypad driver to support the Keypad Port present in the imx application processors family Alberto Panizzo
2010-01-30 11:53 ` Alberto Panizzo
2010-01-31 9:08 ` Dmitry Torokhov
2010-01-31 9:08 ` Dmitry Torokhov
2010-01-31 13:42 ` Alberto Panizzo [this message]
2010-01-31 13:42 ` Alberto Panizzo
2010-02-01 2:01 ` Dmitry Torokhov
2010-02-01 2:01 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1264945351.2433.10.camel@realization \
--to=maramaopercheseimorto@gmail.com \
--cc=LW@KARO-electronics.de \
--cc=dmitry.torokhov@gmail.com \
--cc=hartleys@visionengravers.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.