From: ville.syrjala@nokia.com
To: Tomi Valkeinen <tomi.valkeinen@nokia.com>
Cc: "Imre Deak" <imre.deak@nokia.com>,
linux-fbdev@vger.kernel.org, linux-omap@vger.kernel.org,
"Ville Syrjälä" <ville.syrjala@nokia.com>
Subject: [PATCH v4 3/8] DSS2: OMAPFB: Skip unnecessary set_overlay_info()
Date: Wed, 17 Mar 2010 22:46:18 +0000 [thread overview]
Message-ID: <1268865983-16270-4-git-send-email-ville.syrjala@nokia.com> (raw)
In-Reply-To: <1268865983-16270-1-git-send-email-ville.syrjala@nokia.com>
From: Ville Syrj채l채 <ville.syrjala@nokia.com>
In omapfb_enable_overlay() if the overlay state is already what we want
skip the set_overlay_info().
Signed-off-by: Ville Syrj채l채 <ville.syrjala@nokia.com>
---
drivers/video/omap2/omapfb/omapfb.h | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/video/omap2/omapfb/omapfb.h b/drivers/video/omap2/omapfb/omapfb.h
index cd54fdb..c9866be 100644
--- a/drivers/video/omap2/omapfb/omapfb.h
+++ b/drivers/video/omap2/omapfb/omapfb.h
@@ -148,6 +148,8 @@ static inline int omapfb_overlay_enable(struct omap_overlay *ovl,
struct omap_overlay_info info;
ovl->get_overlay_info(ovl, &info);
+ if (info.enabled = enable)
+ return 0;
info.enabled = enable;
return ovl->set_overlay_info(ovl, &info);
}
--
1.6.4.4
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: ville.syrjala@nokia.com
To: Tomi Valkeinen <tomi.valkeinen@nokia.com>
Cc: "Imre Deak" <imre.deak@nokia.com>,
linux-fbdev@vger.kernel.org, linux-omap@vger.kernel.org,
"Ville Syrjälä" <ville.syrjala@nokia.com>
Subject: [PATCH v4 3/8] DSS2: OMAPFB: Skip unnecessary set_overlay_info()
Date: Thu, 18 Mar 2010 00:46:18 +0200 [thread overview]
Message-ID: <1268865983-16270-4-git-send-email-ville.syrjala@nokia.com> (raw)
In-Reply-To: <1268865983-16270-1-git-send-email-ville.syrjala@nokia.com>
From: Ville Syrjälä <ville.syrjala@nokia.com>
In omapfb_enable_overlay() if the overlay state is already what we want
skip the set_overlay_info().
Signed-off-by: Ville Syrjälä <ville.syrjala@nokia.com>
---
drivers/video/omap2/omapfb/omapfb.h | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/video/omap2/omapfb/omapfb.h b/drivers/video/omap2/omapfb/omapfb.h
index cd54fdb..c9866be 100644
--- a/drivers/video/omap2/omapfb/omapfb.h
+++ b/drivers/video/omap2/omapfb/omapfb.h
@@ -148,6 +148,8 @@ static inline int omapfb_overlay_enable(struct omap_overlay *ovl,
struct omap_overlay_info info;
ovl->get_overlay_info(ovl, &info);
+ if (info.enabled == enable)
+ return 0;
info.enabled = enable;
return ovl->set_overlay_info(ovl, &info);
}
--
1.6.4.4
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-03-17 22:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-17 22:46 omapfb mem_idx patchset ville.syrjala
2010-03-17 22:46 ` ville.syrjala
2010-03-17 22:46 ` [PATCH v4 1/8] DSS2: OMAPFB: Refactor overlay address calculations ville.syrjala
2010-03-17 22:46 ` ville.syrjala
2010-03-17 22:46 ` [PATCH v4 2/8] DSS2: OMAPFB: Check var even if there isn't memory ville.syrjala
2010-03-17 22:46 ` ville.syrjala
2010-03-17 22:46 ` ville.syrjala [this message]
2010-03-17 22:46 ` [PATCH v4 3/8] DSS2: OMAPFB: Skip unnecessary set_overlay_info() ville.syrjala
2010-03-17 22:46 ` [PATCH v4 4/8] DSS2: OMAPFB: Add support for switching memory regions ville.syrjala
2010-03-17 22:46 ` ville.syrjala
2010-03-17 22:46 ` [PATCH v4 5/8] DSS2: OMAPFB: Add locking for " ville.syrjala
2010-03-17 22:46 ` ville.syrjala
2010-03-17 22:46 ` [PATCH v4 6/8] DSS2: OMAPFB: Convert the memory region locking to rwsem ville.syrjala
2010-03-17 22:46 ` ville.syrjala
2010-03-17 22:46 ` [PATCH v4 7/8] DSS2: OMAPFB: Make lockdep happy ville.syrjala
2010-03-17 22:46 ` ville.syrjala
2010-03-17 22:46 ` [PATCH v4 8/8] DSS2: OMAPFB: Add some locking debug checks ville.syrjala
2010-03-17 22:46 ` ville.syrjala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1268865983-16270-4-git-send-email-ville.syrjala@nokia.com \
--to=ville.syrjala@nokia.com \
--cc=imre.deak@nokia.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tomi.valkeinen@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.