From: Ian Campbell <Ian.Campbell@eu.citrix.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Jeremy Fitzhardinge" <jeremy@goop.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Grant Likely <grant.likely@secretlab.ca>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"linuxppc-dev@ozlabs.org" <linuxppc-dev@ozlabs.org>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>
Subject: Re: [PATCH 1/4] irq: rename IRQF_TIMER to IRQF_NO_SUSPEND
Date: Thu, 29 Jul 2010 10:03:34 +0100 [thread overview]
Message-ID: <1280394214.24292.1594.camel@zakaz.uk.xensource.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1007291045060.2471@localhost.localdomain>
On Thu, 2010-07-29 at 09:49 +0100, Thomas Gleixner wrote:
> On Wed, 28 Jul 2010, Ian Campbell wrote:
>
> > Continue to provide IRQF_TIMER as an alias to IRQF_NO_SUSPEND since I
> > think it is worth preserving the nice self-documenting name (where it
> > is used appropriately). It also avoid needing to patch all the many
> > users who are using the flag for an actual timer interrupt.
>
> I'm not happy about the alias. What about:
>
> #define __IRQF_TIMER 0x00000200
> #define IRQF_NO_SUSPEND 0x00000400
>
> #define IRQF_TIMER (__IRQF_TIMER | IRQF_NO_SUSPEND)
Sure, I'll rework along those lines.
Ian.
WARNING: multiple messages have this Message-ID (diff)
From: Ian Campbell <Ian.Campbell@eu.citrix.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linuxppc-dev@ozlabs.org" <linuxppc-dev@ozlabs.org>,
Paul Mackerras <paulus@samba.org>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>
Subject: Re: [PATCH 1/4] irq: rename IRQF_TIMER to IRQF_NO_SUSPEND
Date: Thu, 29 Jul 2010 10:03:34 +0100 [thread overview]
Message-ID: <1280394214.24292.1594.camel@zakaz.uk.xensource.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1007291045060.2471@localhost.localdomain>
On Thu, 2010-07-29 at 09:49 +0100, Thomas Gleixner wrote:
> On Wed, 28 Jul 2010, Ian Campbell wrote:
>
> > Continue to provide IRQF_TIMER as an alias to IRQF_NO_SUSPEND since I
> > think it is worth preserving the nice self-documenting name (where it
> > is used appropriately). It also avoid needing to patch all the many
> > users who are using the flag for an actual timer interrupt.
>
> I'm not happy about the alias. What about:
>
> #define __IRQF_TIMER 0x00000200
> #define IRQF_NO_SUSPEND 0x00000400
>
> #define IRQF_TIMER (__IRQF_TIMER | IRQF_NO_SUSPEND)
Sure, I'll rework along those lines.
Ian.
next prev parent reply other threads:[~2010-07-29 9:03 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-28 10:54 [GIT/PATCH 0/4] Do not use IRQF_TIMER for non timer interrupts Ian Campbell
2010-07-28 10:54 ` Ian Campbell
2010-07-28 10:54 ` Ian Campbell
2010-07-28 10:54 ` [PATCH 1/4] irq: rename IRQF_TIMER to IRQF_NO_SUSPEND Ian Campbell
2010-07-28 10:54 ` Ian Campbell
2010-07-29 8:49 ` Thomas Gleixner
2010-07-29 8:49 ` Thomas Gleixner
2010-07-29 9:03 ` Ian Campbell [this message]
2010-07-29 9:03 ` Ian Campbell
2010-07-29 9:03 ` Ian Campbell
2010-07-29 10:16 ` [GIT/PATCH 0/4] Do not use IRQF_TIMER for non timer interrupts Ian Campbell
2010-07-29 10:16 ` Ian Campbell
2010-07-29 10:16 ` Ian Campbell
2010-07-29 10:16 ` [PATCH 1/4] irq: Add new IRQ flag IRQF_NO_SUSPEND Ian Campbell
2010-07-29 10:16 ` Ian Campbell
2010-07-29 11:30 ` [tip:irq/core] " tip-bot for Ian Campbell
2010-07-30 10:29 ` [PATCH 1/4] " Benjamin Herrenschmidt
2010-07-30 10:29 ` Benjamin Herrenschmidt
2010-07-30 10:29 ` Benjamin Herrenschmidt
2010-07-29 10:16 ` [PATCH 2/4] ixp4xx-beeper: Use IRQF_NO_SUSPEND not IRQF_TIMER for non-timer interrupt Ian Campbell
2010-07-29 11:31 ` [tip:irq/core] " tip-bot for Ian Campbell
2010-07-29 10:16 ` [PATCH 3/4] powerpc: Use IRQF_NO_SUSPEND not IRQF_TIMER for non-timer interrupts Ian Campbell
2010-07-29 10:16 ` Ian Campbell
2010-07-29 11:31 ` [tip:irq/core] " tip-bot for Ian Campbell
2010-07-30 10:30 ` [PATCH 3/4] " Benjamin Herrenschmidt
2010-07-30 10:30 ` Benjamin Herrenschmidt
2010-07-30 10:30 ` Benjamin Herrenschmidt
2010-07-29 10:16 ` [PATCH 4/4] xen: do not suspend IPI IRQs Ian Campbell
2010-07-29 11:31 ` [tip:irq/core] xen: Do " tip-bot for Ian Campbell
2010-07-28 10:54 ` [PATCH 2/4] ixp4xx-beeper: Use IRQF_NO_SUSPEND not IRQF_TIMER for non-timer interrupt Ian Campbell
2010-07-28 10:54 ` [PATCH 3/4] powerpc: Use IRQF_NO_SUSPEND not IRQF_TIMER for non-timer interrupts Ian Campbell
2010-07-28 10:54 ` Ian Campbell
2010-07-28 10:54 ` [PATCH 4/4] xen: do not suspend IPI IRQs Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1280394214.24292.1594.camel@zakaz.uk.xensource.com \
--to=ian.campbell@eu.citrix.com \
--cc=benh@kernel.crashing.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dmitry.torokhov@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=jeremy@goop.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=tglx@linutronix.de \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.